Implemented the 'help' builtin, and support for :h <topic> in ex mode

:h is an alias for the 'help' builtin.

'help' takes a single argument and tries to find a suitable match among the files in '$SHED_HPATH'

if a match is found, this file is opened in your pager

calling the 'help' builtin using :h in ex mode will preserve your current pending line

Cargo.toml

@@ -35,6 +35,7 @@ rand = "0.10.0"
 regex = "1.11.1"
 scopeguard = "1.2.0"
 serde_json = "1.0.149"
+tempfile = "3.24.0"
 unicode-segmentation = "1.12.0"
 unicode-width = "0.2.0"
 vte = "0.15"

README.md

@@ -8,7 +8,7 @@ A Linux shell written in Rust. The name is a nod to the original Unix utilities
 
 ### Line Editor
 
-`shed` includes a built-in `vim` emulator as its line editor, written from scratch. It aims to provide a more precise vim-like editing experience at the shell prompt.
+`shed` includes a built-in `vim` emulator as its line editor, written from scratch. It aims to provide a more precise vim-like editing experience at the shell prompt than conventional `vi` mode implementations.
 
 - **Normal mode** - motions (`w`, `b`, `e`, `f`, `t`, `%`, `0`, `$`, etc.), verbs (`d`, `c`, `y`, `p`, `r`, `x`, `~`, etc.), text objects (`iw`, `aw`, `i"`, `a{`, `is`, etc.), registers, `.` repeat, `;`/`,` repeat, and counts
 - **Insert mode** - insert, append, replace, with Ctrl+W word deletion and undo/redo

doc/arith.txt

@@ -0,0 +1,76 @@
+*arith* *arithmetic* *arithmetic-expansion*
+
+#ARITHMETIC EXPANSION#
+
+Arithmetic expansion evaluates a mathematical expression and substitutes
+the result. The expression is subject to parameter expansion and command
+substitution before evaluation.
+
+  `$((expression))`
+
+      Example:
+        `echo $((2 + 3))`       # prints: 5
+        `x=$((width * height))`
+
+==============================================================================
+1. Operators                                   *arith-operators*
+
+  The following operators are supported, listed from highest to lowest
+  precedence:
+
+  `( )`                                        *arith-parens*
+
+      Grouping. Override default precedence.
+
+      Example:
+        `echo $(( (2+3) * 4 ))`  # prints: 20
+
+  `*` `/` `%`                                  *arith-muldivmod*
+
+      Multiplication, division, and modulo (remainder).
+
+      Example:
+        `echo $((10 / 3))`       # prints: 3
+        `echo $((10 % 3))`       # prints: 1
+
+  `+` `-`                                      *arith-addsub*
+
+      Addition and subtraction.
+
+      Example:
+        `echo $((10 - 3 + 1))`   # prints: 8
+
+==============================================================================
+2. Variables in Expressions                    *arith-variables*
+
+  Variables can be referenced by name inside arithmetic expressions.
+  They are expanded and converted to numbers.
+
+      `x=10`
+      `echo $(($x + 5))`        # prints: 15
+      `echo $((x + 5))`         # also works
+
+  If a variable is unset or not a valid number, an error is reported.
+
+==============================================================================
+3. Nesting                                     *arith-nesting*
+
+  Arithmetic expressions can be nested with parentheses to any depth:
+
+      `echo $(( (1+2) * (3+4) ))`  # prints: 21
+
+  Arithmetic expansion can also appear inside other expansions:
+
+      `echo "Total: $((price * qty))"`
+
+==============================================================================
+4. Whitespace                                  *arith-whitespace*
+
+  Whitespace inside `$((...))` is ignored and can be used freely for
+  readability:
+
+      `echo $((2+3))`           # prints: 5
+      `echo $(( 2 + 3 ))`       # same result
+
+==============================================================================
+See also: |param| |redirect| |glob|

doc/glob.txt

@@ -0,0 +1,155 @@
+*glob* *globbing* *pathname-expansion* *filename-expansion*
+
+#PATHNAME EXPANSION#
+
+After word splitting, the shell scans each word for the characters `*`,
+`?`, and `[`. If any appear (and are not quoted), the word is treated as a
+pattern and replaced with an alphabetically sorted list of matching file
+names. If no files match, the pattern is left unchanged.
+
+==============================================================================
+1. Wildcards                                   *glob-wildcards*
+
+  `*`                                          *glob-star*
+
+      Matches any string of zero or more characters, except that it does
+      not match a leading `.` (see |glob-dotglob|) or a `/`.
+
+      Example:
+        `echo *.txt`             # all .txt files
+        `ls src/*.rs`            # all .rs files in src/
+
+  `?`                                          *glob-question*
+
+      Matches exactly one character, with the same restrictions as `*`.
+
+      Example:
+        `ls file?.txt`           # file1.txt, fileA.txt, etc.
+
+  `[...]`                                      *glob-bracket*
+
+      Matches any one of the enclosed characters. A range can be specified
+      with a hyphen.
+
+      `[abc]`      matches `a`, `b`, or `c`
+      `[a-z]`      matches any lowercase letter
+      `[0-9]`      matches any digit
+      `[A-Za-z]`   matches any letter
+
+  `[!...]` `[^...]`                            *glob-bracket-negate*
+
+      Matches any character NOT in the set.
+
+      Example:
+        `ls [!.]*.txt`           # .txt files not starting with dot
+        `echo file[^0-9].txt`    # files without a digit
+
+==============================================================================
+2. Hidden Files                                *glob-dotglob*
+
+  By default, patterns do not match files whose names begin with `.`
+  (hidden files). A leading dot must be matched explicitly:
+
+      `echo .*`                  # only hidden files
+      `echo .* *`               # hidden and non-hidden files
+
+  The `dotglob` shell option changes this behavior:
+
+      `shopt core.dotglob true`
+
+  When enabled, `*` and `?` will also match files starting with `.`.
+
+==============================================================================
+3. Brace Expansion                             *brace* *brace-expansion*
+
+  Brace expansion is performed before globbing and generates multiple
+  words from a single pattern. It is not a POSIX feature.
+
+  `{a,b,c}`                                   *brace-list*
+
+      Comma-separated list. Each item becomes a separate word.
+
+      Example:
+        `echo {a,b,c}`           # prints: a b c
+        `echo file.{txt,log}`    # prints: file.txt file.log
+        `mkdir -p src/{bin,lib}`
+
+  `{N..M}`                                    *brace-range*
+
+      Numeric or character range.
+
+      Example:
+        `echo {1..5}`            # prints: 1 2 3 4 5
+        `echo {a..f}`            # prints: a b c d e f
+        `echo {5..1}`            # prints: 5 4 3 2 1
+
+  `{N..M..S}`                                 *brace-range-step*
+
+      Numeric range with step {S}.
+
+      Example:
+        `echo {0..10..2}`        # prints: 0 2 4 6 8 10
+        `echo {1..20..5}`        # prints: 1 6 11 16
+
+  `{01..10}`                                  *brace-range-pad*
+
+      Zero-padded ranges. If either endpoint has leading zeros, all
+      generated values are padded to the same width.
+
+      Example:
+        `echo {01..05}`          # prints: 01 02 03 04 05
+        `echo {001..3}`          # prints: 001 002 003
+
+  Brace expansion can be nested and combined with other expansions:
+
+      `echo {a,b{1..3},c}`      # prints: a b1 b2 b3 c
+
+==============================================================================
+4. Quoting and Escaping                        *glob-quoting*
+
+  Glob characters lose their special meaning when quoted:
+
+      `echo "*"`                 # prints literal *
+      `echo '*.txt'`            # prints literal *.txt
+      `echo \*`                 # prints literal *
+
+  This is important when passing patterns to commands like `find` or
+  `grep` where you want the command (not the shell) to interpret the
+  pattern.
+
+==============================================================================
+5. Tilde Expansion                             *tilde* *tilde-expansion*
+
+  Tilde expansion is performed before pathname expansion.
+
+  `~`                                          *tilde-home*
+
+      Expands to the value of `$HOME`.
+
+  `~/path`                                     *tilde-home-path*
+
+      Expands `~` to `$HOME`, then appends the path.
+
+      Example:
+        `cd ~/projects`
+        `ls ~/.config`
+
+  `~user`                                      *tilde-user*
+
+      Expands to the home directory of {user}.
+
+      Example:
+        `ls ~root`               # /root
+        `cat ~nobody/.profile`
+
+  `~uid`                                       *tilde-uid*
+
+      Expands to the home directory of the user with numeric uid {uid}.
+      This is a shed-specific extension.
+
+      Example:
+        `echo ~0`                # /root (uid 0)
+        `echo ~1000`             # first normal user's home
+
+==============================================================================
+See also: |param| |redirect| |arith|

doc/param.txt

@@ -0,0 +1,197 @@
+*param* *parameter-expansion* *param-expansion*
+
+#PARAMETER EXPANSION#
+
+The shell provides several forms of parameter expansion for working with
+variables. In each form, {word} is subject to tilde expansion, parameter
+expansion, command substitution, and arithmetic expansion.
+
+If {parameter} is unset or null, the behavior depends on the operator used.
+"Unset" means the variable has never been assigned. "Null" means the variable
+is set but its value is the empty string.
+
+==============================================================================
+1. Basic Forms                                  *param-basic*
+
+  `$var`           Value of {var}
+  `${var}`         Same, with explicit braces (needed for `${var}foo`)
+
+Braces are required when {var} is followed by characters that could be part
+of the name, or when using any of the operators below.
+
+==============================================================================
+2. Default Values                               *param-default*
+
+  `${var:-word}`                                *param-default-val*
+
+      Use default value. If {var} is unset or null, expand to {word}.
+      Otherwise, expand to the value of {var}.
+
+      Example:
+        `name=${1:-world}`
+        `echo "hello $name"`    # prints "hello world" if \$1 is unset
+
+  `${var-word}`                                 *param-default-nonnull*
+
+      Like `:-` but only substitutes {word} if {var} is completely unset,
+      not if it is null.
+
+==============================================================================
+3. Assign Defaults                              *param-assign*
+
+  `${var:=word}`                                *param-assign-val*
+
+      Assign default value. If {var} is unset or null, assign {word} to
+      {var} and then expand to the new value.
+
+      Note: This cannot be used with positional parameters or special
+      parameters.
+
+      Example:
+        `echo ${cache:=/tmp/cache}`    # sets and uses \$cache
+
+  `${var=word}`                                 *param-assign-nonnull*
+
+      Like `:=` but only assigns if {var} is completely unset.
+
+==============================================================================
+4. Error on Unset                               *param-error*
+
+  `${var:?word}`                                *param-error-val*
+
+      Display error. If {var} is unset or null, print {word} to stderr
+      and exit (in a non-interactive shell). If {word} is omitted, a
+      default message is printed.
+
+      Example:
+        `input=${1:?usage: myscript \<filename\>}`
+
+  `${var?word}`                                 *param-error-nonnull*
+
+      Like `:?` but only errors if {var} is completely unset.
+
+==============================================================================
+5. Alternate Value                              *param-alt*
+
+  `${var:+word}`                                *param-alt-val*
+
+      Use alternate value. If {var} is unset or null, expand to nothing.
+      Otherwise, expand to {word}.
+
+      Example:
+        `echo ${verbose:+--verbose}`   # flag only if \$verbose is set
+
+  `${var+word}`                                 *param-alt-nonnull*
+
+      Like `:+` but substitutes {word} only if {var} is set (even if null).
+
+==============================================================================
+6. String Length                                *param-length*
+
+  `${#var}`                                     *param-strlen*
+
+      Expands to the length of the value of {var} in characters.
+
+      Example:
+        `str="hello"`
+        `echo ${#str}`         # prints 5
+
+==============================================================================
+7. Substring Removal                            *param-substring*
+
+  `${var#pattern}`                              *param-trim-short-left*
+
+      Remove shortest matching prefix. Removes the shortest match of
+      {pattern} from the beginning of the value of {var}.
+
+  `${var##pattern}`                             *param-trim-long-left*
+
+      Remove longest matching prefix.
+
+      Example:
+        `path="/home/user/file.txt"`
+        `echo ${path##*/}`     # prints "file.txt"
+
+  `${var%pattern}`                              *param-trim-short-right*
+
+      Remove shortest matching suffix. Removes the shortest match of
+      {pattern} from the end of the value of {var}.
+
+  `${var%%pattern}`                             *param-trim-long-right*
+
+      Remove longest matching suffix.
+
+      Example:
+        `file="archive.tar.gz"`
+        `echo ${file%%.*}`     # prints "archive"
+        `echo ${file%.*}`      # prints "archive.tar"
+
+==============================================================================
+8. Search and Replace                           *param-replace*
+
+  `${var/pattern/replacement}`                  *param-replace-first*
+
+      Replace first match. Replaces the first occurrence of {pattern}
+      in the value of {var} with {replacement}.
+
+  `${var//pattern/replacement}`                 *param-replace-all*
+
+      Replace all matches.
+
+      Example:
+        `str="hello world"`
+        `echo ${str/o/0}`      # prints "hell0 world"
+        `echo ${str//o/0}`     # prints "hell0 w0rld"
+
+  `${var/#pattern/replacement}`                 *param-replace-prefix*
+
+      Replace if matching at the beginning.
+
+  `${var/%pattern/replacement}`                 *param-replace-suffix*
+
+      Replace if matching at the end.
+
+==============================================================================
+9. Case Modification                            *param-case*
+
+  `${var^}`                                     *param-upper-first*
+
+      Uppercase the first character of {var}.
+
+  `${var^^}`                                    *param-upper-all*
+
+      Uppercase all characters.
+
+  `${var,}`                                     *param-lower-first*
+
+      Lowercase the first character of {var}.
+
+  `${var,,}`                                    *param-lower-all*
+
+      Lowercase all characters.
+
+      Example:
+        `name="john doe"`
+        `echo ${name^}`        # prints "John doe"
+        `echo ${name^^}`       # prints "JOHN DOE"
+
+==============================================================================
+10. Substrings                                  *param-slice*
+
+  `${var:offset}`                               *param-slice-from*
+
+      Substring starting at {offset} (0-indexed).
+
+  `${var:offset:length}`                        *param-slice-range*
+
+      Substring of {length} characters starting at {offset}.
+
+      Negative offsets count from the end (note the space before the minus
+      to distinguish from `:-`):
+
+        `str="hello world"`
+        `echo ${str: -5}`      # prints "world"
+        `echo ${str:0:5}`      # prints "hello"
+
+==============================================================================
+See also: |redirect| |glob| |arith|

doc/redirect.txt

@@ -0,0 +1,181 @@
+*redirect* *redirection* *redir*
+
+#REDIRECTION#
+
+Redirections allow you to control where a command reads its input from and
+where it sends its output. A redirection applies to a specific file
+descriptor; if no descriptor number is given, output redirections default
+to stdout (fd 1) and input redirections default to stdin (fd 0).
+
+==============================================================================
+1. Output Redirection                          *redir-output*
+
+  `command > file`                             *redir-out*
+
+      Redirect stdout to {file}, creating it if it does not exist or
+      truncating it if it does.
+
+      Example:
+        `echo hello > out.txt`
+        `ls 2> errors.txt`       # redirect stderr
+
+  `command >| file`                            *redir-out-force*
+
+      Like `>` but overrides the {noclobber} option. If {noclobber} is set,
+      `>` will refuse to overwrite an existing file; `>|` forces the
+      overwrite.
+
+  `command >> file`                            *redir-append*
+
+      Append stdout to {file}, creating it if it does not exist.
+
+      Example:
+        `echo line >> log.txt`
+
+==============================================================================
+2. Input Redirection                           *redir-input*
+
+  `command < file`                             *redir-in*
+
+      Redirect {file} to stdin.
+
+      Example:
+        `sort < unsorted.txt`
+
+==============================================================================
+3. Read-Write Redirection                      *redir-readwrite*
+
+  `command <> file`                            *redir-rw*
+
+      Open {file} for both reading and writing on the specified file
+      descriptor (default fd 0). The file is created if it does not exist
+      but is not truncated.
+
+      Useful with the `seek` builtin for random-access file operations.
+
+      Example:
+        `exec 3<> data.bin`
+        `seek 3 0 set`           # seek to beginning
+
+==============================================================================
+4. File Descriptor Duplication                 *redir-dup*
+
+  `command N>&M`                               *redir-dup-out*
+
+      Duplicate output file descriptor {M} onto {N}. After this, writing
+      to fd {N} goes to the same place as fd {M}.
+
+      Example:
+        `command > out.txt 2>&1`  # stderr goes where stdout goes
+
+  `command N<&M`                               *redir-dup-in*
+
+      Duplicate input file descriptor {M} onto {N}.
+
+  `command N>&-`                               *redir-close-out*
+  `command N<&-`                               *redir-close-in*
+
+      Close file descriptor {N}.
+
+      Example:
+        `exec 3>&-`              # close fd 3
+
+==============================================================================
+5. Pipelines                                   *redir-pipe*
+
+  `command1 | command2`                        *pipe*
+
+      Connect stdout of {command1} to stdin of {command2}. Both commands
+      run concurrently.
+
+      Example:
+        `cat file.txt | grep pattern | sort`
+
+  `command1 |& command2`                       *pipe-and*
+
+      Connect both stdout and stderr of {command1} to stdin of {command2}.
+      Equivalent to `command1 2>&1 | command2`.
+
+==============================================================================
+6. Here Documents                              *heredoc*
+
+  `command << DELIM`                           *redir-heredoc*
+
+      Read input from the script body until a line containing only {DELIM}
+      is found. The text between is fed to stdin of {command}.
+
+      Parameter expansion, command substitution, and arithmetic expansion
+      are performed in the body unless the delimiter is quoted.
+
+      Example:
+        `cat << EOF`
+        `Hello $USER`
+        `EOF`
+
+  `command << 'DELIM'`                         *redir-heredoc-literal*
+
+      Quoting the delimiter (single or double quotes) suppresses all
+      expansion in the heredoc body. The text is passed literally.
+
+      Example:
+        `cat << 'EOF'`
+        `This $variable is not expanded`
+        `EOF`
+
+  `command <<- DELIM`                          *redir-heredoc-indent*
+
+      Like `<<` but strips leading tab characters from each line of the
+      body and from the closing delimiter. This allows heredocs to be
+      indented for readability without affecting the content.
+
+      Example:
+        `if true; then`
+        `	cat <<- EOF`
+        `	indented content`
+        `	EOF`
+        `fi`
+
+==============================================================================
+7. Here Strings                                *herestring*
+
+  `command <<< word`                           *redir-herestring*
+
+      Feed {word} as a single string to stdin of {command}, with a
+      trailing newline appended. {word} is subject to the usual expansions.
+
+      Example:
+        `read first rest <<< "hello world"`
+        `bc <<< "2 + 2"`
+
+==============================================================================
+8. File Descriptor Numbers                     *redir-fd*
+
+  Any redirection operator can be prefixed with a file descriptor number:
+
+      `2> file`       redirect stderr to file
+      `3< file`       open file on fd 3
+      `4>> file`      append to file on fd 4
+      `5<> file`      open file read-write on fd 5
+
+  Standard file descriptors:
+
+      0   stdin
+      1   stdout
+      2   stderr
+
+  File descriptors 3 and above are available for general use with `exec`.
+
+==============================================================================
+9. Combining Redirections                      *redir-combine*
+
+  Multiple redirections can appear on a single command, processed left
+  to right:
+
+      `command > out.txt 2>&1`   # stdout to file, stderr to same file
+      `command 2>&1 > out.txt`   # different! stderr to terminal,
+                                 # stdout to file
+
+  Order matters: each redirection is applied in sequence.
+
+==============================================================================
+See also: |param| |glob| |arith|

src/builtin/alias.rs

@@ -38,28 +38,30 @@ pub fn alias(node: Node) -> ShResult<()> {
     write(stdout, alias_output.as_bytes())?; // Write it
   } else {
     for (arg, span) in argv {
-
       let Some((name, body)) = arg.split_once('=') else {
-				let Some(alias) = read_logic(|l| l.get_alias(&arg)) else {
-					return Err(ShErr::at(
-						ShErrKind::SyntaxErr,
-						span,
-						"alias: Expected an assignment in alias args",
-					));
-				};
+        let Some(alias) = read_logic(|l| l.get_alias(&arg)) else {
+          return Err(ShErr::at(
+            ShErrKind::SyntaxErr,
+            span,
+            "alias: Expected an assignment in alias args",
+          ));
+        };
 
-				let alias_output = format!("{arg}='{alias}'");
+        let alias_output = format!("{arg}='{alias}'");
 
-				let stdout = borrow_fd(STDOUT_FILENO);
-				write(stdout, alias_output.as_bytes())?; // Write it
-				state::set_status(0);
-				return Ok(());
+        let stdout = borrow_fd(STDOUT_FILENO);
+        write(stdout, alias_output.as_bytes())?; // Write it
+        state::set_status(0);
+        return Ok(());
       };
       if name == "command" || name == "builtin" {
         return Err(ShErr::at(
           ShErrKind::ExecFail,
           span,
-          format!("alias: Cannot assign alias to reserved name '{}'", name.fg(next_color())),
+          format!(
+            "alias: Cannot assign alias to reserved name '{}'",
+            name.fg(next_color())
+          ),
         ));
       }
       write_logic(|l| l.insert_alias(name, body, span.clone()));
@@ -118,7 +120,7 @@ pub fn unalias(node: Node) -> ShResult<()> {
 mod tests {
   use crate::state::{self, read_logic};
   use crate::testutil::{TestGuard, test_input};
-	use pretty_assertions::assert_eq;
+  use pretty_assertions::assert_eq;
 
   #[test]
   fn alias_set_and_expand() {

src/builtin/arrops.rs

@@ -229,9 +229,9 @@ pub fn get_arr_op_opts(opts: Vec<Opt>) -> ShResult<ArrOpOpts> {
 
 #[cfg(test)]
 mod tests {
-  use std::collections::VecDeque;
-  use crate::state::{self, read_vars, write_vars, VarFlags, VarKind};
+  use crate::state::{self, VarFlags, VarKind, read_vars, write_vars};
   use crate::testutil::{TestGuard, test_input};
+  use std::collections::VecDeque;
 
   fn set_arr(name: &str, elems: &[&str]) {
     let arr = VecDeque::from_iter(elems.iter().map(|s| s.to_string()));

src/builtin/autocmd.rs

@@ -159,7 +159,10 @@ mod tests {
     test_input("autocmd post-cmd 'echo post'").unwrap();
 
     assert_eq!(read_logic(|l| l.get_autocmds(AutoCmdKind::PreCmd)).len(), 1);
-    assert_eq!(read_logic(|l| l.get_autocmds(AutoCmdKind::PostCmd)).len(), 1);
+    assert_eq!(
+      read_logic(|l| l.get_autocmds(AutoCmdKind::PostCmd)).len(),
+      1
+    );
   }
 
   // ===================== Pattern =====================
@@ -205,7 +208,10 @@ mod tests {
 
     test_input("autocmd -c pre-cmd").unwrap();
     assert_eq!(read_logic(|l| l.get_autocmds(AutoCmdKind::PreCmd)).len(), 0);
-    assert_eq!(read_logic(|l| l.get_autocmds(AutoCmdKind::PostCmd)).len(), 1);
+    assert_eq!(
+      read_logic(|l| l.get_autocmds(AutoCmdKind::PostCmd)).len(),
+      1
+    );
   }
 
   #[test]
@@ -245,11 +251,21 @@ mod tests {
   fn all_kinds_parse() {
     let _guard = TestGuard::new();
     let kinds = [
-      "pre-cmd", "post-cmd", "pre-change-dir", "post-change-dir",
-      "on-job-finish", "pre-prompt", "post-prompt",
-      "pre-mode-change", "post-mode-change",
-      "on-history-open", "on-history-close", "on-history-select",
-      "on-completion-start", "on-completion-cancel", "on-completion-select",
+      "pre-cmd",
+      "post-cmd",
+      "pre-change-dir",
+      "post-change-dir",
+      "on-job-finish",
+      "pre-prompt",
+      "post-prompt",
+      "pre-mode-change",
+      "post-mode-change",
+      "on-history-open",
+      "on-history-close",
+      "on-history-select",
+      "on-completion-start",
+      "on-completion-cancel",
+      "on-completion-select",
       "on-exit",
     ];
     for kind in kinds {

src/builtin/cd.rs

@@ -78,159 +78,165 @@ pub fn cd(node: Node) -> ShResult<()> {
 
 #[cfg(test)]
 pub mod tests {
-    use std::env;
-    use std::fs;
+  use std::env;
+  use std::fs;
 
-    use tempfile::TempDir;
+  use tempfile::TempDir;
 
-    use crate::state;
-    use crate::testutil::{TestGuard, test_input};
+  use crate::state;
+  use crate::testutil::{TestGuard, test_input};
 
-	// ===================== Basic Navigation =====================
+  // ===================== Basic Navigation =====================
 
-	#[test]
-	fn cd_simple() {
-		let _g = TestGuard::new();
-		let old_dir = env::current_dir().unwrap();
-		let temp_dir = TempDir::new().unwrap();
+  #[test]
+  fn cd_simple() {
+    let _g = TestGuard::new();
+    let old_dir = env::current_dir().unwrap();
+    let temp_dir = TempDir::new().unwrap();
 
-		test_input(format!("cd {}", temp_dir.path().display())).unwrap();
+    test_input(format!("cd {}", temp_dir.path().display())).unwrap();
 
-		let new_dir = env::current_dir().unwrap();
-		assert_ne!(old_dir, new_dir);
+    let new_dir = env::current_dir().unwrap();
+    assert_ne!(old_dir, new_dir);
 
-		assert_eq!(new_dir.display().to_string(), temp_dir.path().display().to_string());
-	}
+    assert_eq!(
+      new_dir.display().to_string(),
+      temp_dir.path().display().to_string()
+    );
+  }
 
-	#[test]
-	fn cd_no_args_goes_home() {
-		let _g = TestGuard::new();
-		let temp_dir = TempDir::new().unwrap();
-		unsafe { env::set_var("HOME", temp_dir.path()) };
+  #[test]
+  fn cd_no_args_goes_home() {
+    let _g = TestGuard::new();
+    let temp_dir = TempDir::new().unwrap();
+    unsafe { env::set_var("HOME", temp_dir.path()) };
 
-		test_input("cd").unwrap();
+    test_input("cd").unwrap();
 
-		let cwd = env::current_dir().unwrap();
-		assert_eq!(cwd.display().to_string(), temp_dir.path().display().to_string());
-	}
+    let cwd = env::current_dir().unwrap();
+    assert_eq!(
+      cwd.display().to_string(),
+      temp_dir.path().display().to_string()
+    );
+  }
 
-	#[test]
-	fn cd_relative_path() {
-		let _g = TestGuard::new();
-		let temp_dir = TempDir::new().unwrap();
-		let sub = temp_dir.path().join("child");
-		fs::create_dir(&sub).unwrap();
+  #[test]
+  fn cd_relative_path() {
+    let _g = TestGuard::new();
+    let temp_dir = TempDir::new().unwrap();
+    let sub = temp_dir.path().join("child");
+    fs::create_dir(&sub).unwrap();
 
-		test_input(format!("cd {}", temp_dir.path().display())).unwrap();
-		test_input("cd child").unwrap();
+    test_input(format!("cd {}", temp_dir.path().display())).unwrap();
+    test_input("cd child").unwrap();
 
-		let cwd = env::current_dir().unwrap();
-		assert_eq!(cwd.display().to_string(), sub.display().to_string());
-	}
+    let cwd = env::current_dir().unwrap();
+    assert_eq!(cwd.display().to_string(), sub.display().to_string());
+  }
 
-	// ===================== Environment =====================
+  // ===================== Environment =====================
 
-	#[test]
-	fn cd_sets_pwd_env() {
-		let _g = TestGuard::new();
-		let temp_dir = TempDir::new().unwrap();
+  #[test]
+  fn cd_sets_pwd_env() {
+    let _g = TestGuard::new();
+    let temp_dir = TempDir::new().unwrap();
 
-		test_input(format!("cd {}", temp_dir.path().display())).unwrap();
+    test_input(format!("cd {}", temp_dir.path().display())).unwrap();
 
-		let pwd = env::var("PWD").unwrap();
-		assert_eq!(pwd, env::current_dir().unwrap().display().to_string());
-	}
+    let pwd = env::var("PWD").unwrap();
+    assert_eq!(pwd, env::current_dir().unwrap().display().to_string());
+  }
 
-	#[test]
-	fn cd_status_zero_on_success() {
-		let _g = TestGuard::new();
-		let temp_dir = TempDir::new().unwrap();
+  #[test]
+  fn cd_status_zero_on_success() {
+    let _g = TestGuard::new();
+    let temp_dir = TempDir::new().unwrap();
 
-		test_input(format!("cd {}", temp_dir.path().display())).unwrap();
+    test_input(format!("cd {}", temp_dir.path().display())).unwrap();
 
-		assert_eq!(state::get_status(), 0);
-	}
+    assert_eq!(state::get_status(), 0);
+  }
 
-	// ===================== Error Cases =====================
+  // ===================== Error Cases =====================
 
-	#[test]
-	fn cd_nonexistent_dir_fails() {
-		let _g = TestGuard::new();
-		let result = test_input("cd /nonexistent_path_that_does_not_exist_xyz");
-		assert!(result.is_err());
-	}
+  #[test]
+  fn cd_nonexistent_dir_fails() {
+    let _g = TestGuard::new();
+    let result = test_input("cd /nonexistent_path_that_does_not_exist_xyz");
+    assert!(result.is_err());
+  }
 
-	#[test]
-	fn cd_file_not_directory_fails() {
-		let _g = TestGuard::new();
-		let temp_dir = TempDir::new().unwrap();
-		let file_path = temp_dir.path().join("afile.txt");
-		fs::write(&file_path, "hello").unwrap();
+  #[test]
+  fn cd_file_not_directory_fails() {
+    let _g = TestGuard::new();
+    let temp_dir = TempDir::new().unwrap();
+    let file_path = temp_dir.path().join("afile.txt");
+    fs::write(&file_path, "hello").unwrap();
 
-		let result = test_input(format!("cd {}", file_path.display()));
-		assert!(result.is_err());
-	}
+    let result = test_input(format!("cd {}", file_path.display()));
+    assert!(result.is_err());
+  }
 
-	// ===================== Multiple cd =====================
+  // ===================== Multiple cd =====================
 
-	#[test]
-	fn cd_multiple_times() {
-		let _g = TestGuard::new();
-		let dir_a = TempDir::new().unwrap();
-		let dir_b = TempDir::new().unwrap();
+  #[test]
+  fn cd_multiple_times() {
+    let _g = TestGuard::new();
+    let dir_a = TempDir::new().unwrap();
+    let dir_b = TempDir::new().unwrap();
 
-		test_input(format!("cd {}", dir_a.path().display())).unwrap();
-		assert_eq!(
-			env::current_dir().unwrap().display().to_string(),
-			dir_a.path().display().to_string()
-		);
+    test_input(format!("cd {}", dir_a.path().display())).unwrap();
+    assert_eq!(
+      env::current_dir().unwrap().display().to_string(),
+      dir_a.path().display().to_string()
+    );
 
-		test_input(format!("cd {}", dir_b.path().display())).unwrap();
-		assert_eq!(
-			env::current_dir().unwrap().display().to_string(),
-			dir_b.path().display().to_string()
-		);
-	}
+    test_input(format!("cd {}", dir_b.path().display())).unwrap();
+    assert_eq!(
+      env::current_dir().unwrap().display().to_string(),
+      dir_b.path().display().to_string()
+    );
+  }
 
-	#[test]
-	fn cd_nested_subdirectories() {
-		let _g = TestGuard::new();
-		let temp_dir = TempDir::new().unwrap();
-		let deep = temp_dir.path().join("a").join("b").join("c");
-		fs::create_dir_all(&deep).unwrap();
+  #[test]
+  fn cd_nested_subdirectories() {
+    let _g = TestGuard::new();
+    let temp_dir = TempDir::new().unwrap();
+    let deep = temp_dir.path().join("a").join("b").join("c");
+    fs::create_dir_all(&deep).unwrap();
 
-		test_input(format!("cd {}", deep.display())).unwrap();
-		assert_eq!(
-			env::current_dir().unwrap().display().to_string(),
-			deep.display().to_string()
-		);
-	}
+    test_input(format!("cd {}", deep.display())).unwrap();
+    assert_eq!(
+      env::current_dir().unwrap().display().to_string(),
+      deep.display().to_string()
+    );
+  }
 
-	// ===================== Autocmd Integration =====================
+  // ===================== Autocmd Integration =====================
 
-	#[test]
-	fn cd_fires_post_change_dir_autocmd() {
-		let guard = TestGuard::new();
-		let temp_dir = TempDir::new().unwrap();
+  #[test]
+  fn cd_fires_post_change_dir_autocmd() {
+    let guard = TestGuard::new();
+    let temp_dir = TempDir::new().unwrap();
 
-		test_input("autocmd post-change-dir 'echo cd-hook-fired'").unwrap();
-		guard.read_output();
+    test_input("autocmd post-change-dir 'echo cd-hook-fired'").unwrap();
+    guard.read_output();
 
-		test_input(format!("cd {}", temp_dir.path().display())).unwrap();
-		let out = guard.read_output();
-		assert!(out.contains("cd-hook-fired"));
-	}
+    test_input(format!("cd {}", temp_dir.path().display())).unwrap();
+    let out = guard.read_output();
+    assert!(out.contains("cd-hook-fired"));
+  }
 
-	#[test]
-	fn cd_fires_pre_change_dir_autocmd() {
-		let guard = TestGuard::new();
-		let temp_dir = TempDir::new().unwrap();
+  #[test]
+  fn cd_fires_pre_change_dir_autocmd() {
+    let guard = TestGuard::new();
+    let temp_dir = TempDir::new().unwrap();
 
-		test_input("autocmd pre-change-dir 'echo pre-cd'").unwrap();
-		guard.read_output();
+    test_input("autocmd pre-change-dir 'echo pre-cd'").unwrap();
+    guard.read_output();
 
-		test_input(format!("cd {}", temp_dir.path().display())).unwrap();
-		let out = guard.read_output();
-		assert!(out.contains("pre-cd"));
-	}
+    test_input(format!("cd {}", temp_dir.path().display())).unwrap();
+    let out = guard.read_output();
+    assert!(out.contains("pre-cd"));
+  }
 }

src/builtin/complete.rs

@@ -176,20 +176,20 @@ pub fn complete_builtin(node: Node) -> ShResult<()> {
       read_meta(|m| -> ShResult<()> {
         let specs = m.comp_specs().values();
         for spec in specs {
-					let stdout = borrow_fd(STDOUT_FILENO);
-					write(stdout, spec.source().as_bytes())?;
+          let stdout = borrow_fd(STDOUT_FILENO);
+          write(stdout, spec.source().as_bytes())?;
         }
-				Ok(())
+        Ok(())
       })?;
     } else {
       read_meta(|m| -> ShResult<()> {
         for (cmd, _) in &argv {
           if let Some(spec) = m.comp_specs().get(cmd) {
-						let stdout = borrow_fd(STDOUT_FILENO);
-						write(stdout, spec.source().as_bytes())?;
+            let stdout = borrow_fd(STDOUT_FILENO);
+            write(stdout, spec.source().as_bytes())?;
           }
         }
-				Ok(())
+        Ok(())
       })?;
     }
 
@@ -316,10 +316,10 @@ pub fn get_comp_opts(opts: Vec<Opt>) -> ShResult<CompOpts> {
 
 #[cfg(test)]
 mod tests {
+  use crate::state::{self, VarFlags, VarKind, read_meta, write_vars};
+  use crate::testutil::{TestGuard, test_input};
   use std::fs;
   use tempfile::TempDir;
-  use crate::state::{self, read_meta, write_vars, VarFlags, VarKind};
-  use crate::testutil::{TestGuard, test_input};
 
   // ===================== complete: Registration =====================
 

src/builtin/dirstack.rs

@@ -12,12 +12,13 @@ use crate::{
 };
 
 pub fn truncate_home_path(path: String) -> String {
-	if let Ok(home) = env::var("HOME")
-	&& path.starts_with(&home) {
-		let new = path.strip_prefix(&home).unwrap();
-		return format!("~{new}");
-	}
-	path.to_string()
+  if let Ok(home) = env::var("HOME")
+    && path.starts_with(&home)
+  {
+    let new = path.strip_prefix(&home).unwrap();
+    return format!("~{new}");
+  }
+  path.to_string()
 }
 
 enum StackIdx {
@@ -376,8 +377,7 @@ pub fn dirs(node: Node) -> ShResult<()> {
       .map(|d| d.to_string_lossy().to_string());
 
     if abbreviate_home {
-      stack.map(truncate_home_path)
-        .collect()
+      stack.map(truncate_home_path).collect()
     } else {
       stack.collect()
     }
@@ -428,189 +428,198 @@ pub fn dirs(node: Node) -> ShResult<()> {
 
 #[cfg(test)]
 pub mod tests {
-	use std::{env, path::PathBuf};
-	use crate::{state::{self, read_meta}, testutil::{TestGuard, test_input}};
-	use pretty_assertions::{assert_ne,assert_eq};
-use tempfile::TempDir;
+  use crate::{
+    state::{self, read_meta},
+    testutil::{TestGuard, test_input},
+  };
+  use pretty_assertions::{assert_eq, assert_ne};
+  use std::{env, path::PathBuf};
+  use tempfile::TempDir;
 
-	#[test]
-	fn test_pushd_interactive() {
-		let g = TestGuard::new();
-		let current_dir = env::current_dir().unwrap();
+  #[test]
+  fn test_pushd_interactive() {
+    let g = TestGuard::new();
+    let current_dir = env::current_dir().unwrap();
 
-		test_input("pushd /tmp").unwrap();
+    test_input("pushd /tmp").unwrap();
 
-		let new_dir = env::current_dir().unwrap();
+    let new_dir = env::current_dir().unwrap();
 
-		assert_ne!(new_dir, current_dir);
-		assert_eq!(new_dir, PathBuf::from("/tmp"));
+    assert_ne!(new_dir, current_dir);
+    assert_eq!(new_dir, PathBuf::from("/tmp"));
 
-		let dir_stack = read_meta(|m| m.dirs().clone());
-		assert_eq!(dir_stack.len(), 1);
-		assert_eq!(dir_stack[0], current_dir);
+    let dir_stack = read_meta(|m| m.dirs().clone());
+    assert_eq!(dir_stack.len(), 1);
+    assert_eq!(dir_stack[0], current_dir);
 
-		let out = g.read_output();
-		let path = super::truncate_home_path(current_dir.to_string_lossy().to_string());
-		assert_eq!(out, format!("/tmp {path}\n"));
-	}
+    let out = g.read_output();
+    let path = super::truncate_home_path(current_dir.to_string_lossy().to_string());
+    assert_eq!(out, format!("/tmp {path}\n"));
+  }
 
-	#[test]
-	fn test_popd_interactive() {
-		let g = TestGuard::new();
-		let current_dir = env::current_dir().unwrap();
-		let tempdir = TempDir::new().unwrap();
-		let tempdir_raw = tempdir.path().to_path_buf().to_string_lossy().to_string();
+  #[test]
+  fn test_popd_interactive() {
+    let g = TestGuard::new();
+    let current_dir = env::current_dir().unwrap();
+    let tempdir = TempDir::new().unwrap();
+    let tempdir_raw = tempdir.path().to_path_buf().to_string_lossy().to_string();
 
-		test_input(format!("pushd {tempdir_raw}")).unwrap();
+    test_input(format!("pushd {tempdir_raw}")).unwrap();
 
-		let dir_stack = read_meta(|m| m.dirs().clone());
-		assert_eq!(dir_stack.len(), 1);
-		assert_eq!(dir_stack[0], current_dir);
+    let dir_stack = read_meta(|m| m.dirs().clone());
+    assert_eq!(dir_stack.len(), 1);
+    assert_eq!(dir_stack[0], current_dir);
 
-		assert_eq!(env::current_dir().unwrap(), tempdir.path());
-		g.read_output(); // consume output of pushd
+    assert_eq!(env::current_dir().unwrap(), tempdir.path());
+    g.read_output(); // consume output of pushd
 
-		test_input("popd").unwrap();
+    test_input("popd").unwrap();
 
-		assert_eq!(env::current_dir().unwrap(), current_dir);
-		let out = g.read_output();
-		let path = super::truncate_home_path(current_dir.to_string_lossy().to_string());
-		assert_eq!(out, format!("{path}\n"));
-	}
+    assert_eq!(env::current_dir().unwrap(), current_dir);
+    let out = g.read_output();
+    let path = super::truncate_home_path(current_dir.to_string_lossy().to_string());
+    assert_eq!(out, format!("{path}\n"));
+  }
 
-	#[test]
-	fn test_popd_empty_stack() {
-		let _g = TestGuard::new();
+  #[test]
+  fn test_popd_empty_stack() {
+    let _g = TestGuard::new();
 
-		test_input("popd").unwrap_err();
-		assert_ne!(state::get_status(), 0);
-	}
+    test_input("popd").unwrap_err();
+    assert_ne!(state::get_status(), 0);
+  }
 
-	#[test]
-	fn test_pushd_multiple_then_popd() {
-		let g = TestGuard::new();
-		let original = env::current_dir().unwrap();
-		let tmp1 = TempDir::new().unwrap();
-		let tmp2 = TempDir::new().unwrap();
-		let path1 = tmp1.path().to_path_buf();
-		let path2 = tmp2.path().to_path_buf();
+  #[test]
+  fn test_pushd_multiple_then_popd() {
+    let g = TestGuard::new();
+    let original = env::current_dir().unwrap();
+    let tmp1 = TempDir::new().unwrap();
+    let tmp2 = TempDir::new().unwrap();
+    let path1 = tmp1.path().to_path_buf();
+    let path2 = tmp2.path().to_path_buf();
 
-		test_input(format!("pushd {}", path1.display())).unwrap();
-		test_input(format!("pushd {}", path2.display())).unwrap();
-		g.read_output();
+    test_input(format!("pushd {}", path1.display())).unwrap();
+    test_input(format!("pushd {}", path2.display())).unwrap();
+    g.read_output();
 
-		assert_eq!(env::current_dir().unwrap(), path2);
-		let stack = read_meta(|m| m.dirs().clone());
-		assert_eq!(stack.len(), 2);
-		assert_eq!(stack[0], path1);
-		assert_eq!(stack[1], original);
+    assert_eq!(env::current_dir().unwrap(), path2);
+    let stack = read_meta(|m| m.dirs().clone());
+    assert_eq!(stack.len(), 2);
+    assert_eq!(stack[0], path1);
+    assert_eq!(stack[1], original);
 
-		test_input("popd").unwrap();
-		assert_eq!(env::current_dir().unwrap(), path1);
+    test_input("popd").unwrap();
+    assert_eq!(env::current_dir().unwrap(), path1);
 
-		test_input("popd").unwrap();
-		assert_eq!(env::current_dir().unwrap(), original);
+    test_input("popd").unwrap();
+    assert_eq!(env::current_dir().unwrap(), original);
 
-		let stack = read_meta(|m| m.dirs().clone());
-		assert_eq!(stack.len(), 0);
-	}
+    let stack = read_meta(|m| m.dirs().clone());
+    assert_eq!(stack.len(), 0);
+  }
 
-	#[test]
-	fn test_pushd_rotate_plus() {
-		let g = TestGuard::new();
-		let original = env::current_dir().unwrap();
-		let tmp1 = TempDir::new().unwrap();
-		let tmp2 = TempDir::new().unwrap();
-		let path1 = tmp1.path().to_path_buf();
-		let path2 = tmp2.path().to_path_buf();
+  #[test]
+  fn test_pushd_rotate_plus() {
+    let g = TestGuard::new();
+    let original = env::current_dir().unwrap();
+    let tmp1 = TempDir::new().unwrap();
+    let tmp2 = TempDir::new().unwrap();
+    let path1 = tmp1.path().to_path_buf();
+    let path2 = tmp2.path().to_path_buf();
 
-		// Build stack: cwd=original, then pushd path1, pushd path2
-		// Stack after: cwd=path2, [path1, original]
-		test_input(format!("pushd {}", path1.display())).unwrap();
-		test_input(format!("pushd {}", path2.display())).unwrap();
-		g.read_output();
+    // Build stack: cwd=original, then pushd path1, pushd path2
+    // Stack after: cwd=path2, [path1, original]
+    test_input(format!("pushd {}", path1.display())).unwrap();
+    test_input(format!("pushd {}", path2.display())).unwrap();
+    g.read_output();
 
-		// pushd +1 rotates: [path2, path1, original] -> rotate_left(1) -> [path1, original, path2]
-		// pop front -> cwd=path1, stack=[original, path2]
-		test_input("pushd +1").unwrap();
-		assert_eq!(env::current_dir().unwrap(), path1);
+    // pushd +1 rotates: [path2, path1, original] -> rotate_left(1) -> [path1, original, path2]
+    // pop front -> cwd=path1, stack=[original, path2]
+    test_input("pushd +1").unwrap();
+    assert_eq!(env::current_dir().unwrap(), path1);
 
-		let stack = read_meta(|m| m.dirs().clone());
-		assert_eq!(stack.len(), 2);
-		assert_eq!(stack[0], original);
-		assert_eq!(stack[1], path2);
-	}
+    let stack = read_meta(|m| m.dirs().clone());
+    assert_eq!(stack.len(), 2);
+    assert_eq!(stack[0], original);
+    assert_eq!(stack[1], path2);
+  }
 
-	#[test]
-	fn test_pushd_no_cd_flag() {
-		let _g = TestGuard::new();
-		let original = env::current_dir().unwrap();
-		let tmp = TempDir::new().unwrap();
-		let path = tmp.path().to_path_buf();
+  #[test]
+  fn test_pushd_no_cd_flag() {
+    let _g = TestGuard::new();
+    let original = env::current_dir().unwrap();
+    let tmp = TempDir::new().unwrap();
+    let path = tmp.path().to_path_buf();
 
-		test_input(format!("pushd -n {}", path.display())).unwrap();
+    test_input(format!("pushd -n {}", path.display())).unwrap();
 
-		// -n means don't cd, but the dir should still be on the stack
-		assert_eq!(env::current_dir().unwrap(), original);
-	}
+    // -n means don't cd, but the dir should still be on the stack
+    assert_eq!(env::current_dir().unwrap(), original);
+  }
 
-	#[test]
-	fn test_dirs_clear() {
-		let _g = TestGuard::new();
-		let tmp = TempDir::new().unwrap();
+  #[test]
+  fn test_dirs_clear() {
+    let _g = TestGuard::new();
+    let tmp = TempDir::new().unwrap();
 
-		test_input(format!("pushd {}", tmp.path().display())).unwrap();
-		assert_eq!(read_meta(|m| m.dirs().len()), 1);
+    test_input(format!("pushd {}", tmp.path().display())).unwrap();
+    assert_eq!(read_meta(|m| m.dirs().len()), 1);
 
-		test_input("dirs -c").unwrap();
-		assert_eq!(read_meta(|m| m.dirs().len()), 0);
-	}
+    test_input("dirs -c").unwrap();
+    assert_eq!(read_meta(|m| m.dirs().len()), 0);
+  }
 
-	#[test]
-	fn test_dirs_one_per_line() {
-		let g = TestGuard::new();
-		let original = env::current_dir().unwrap();
-		let tmp = TempDir::new().unwrap();
-		let path = tmp.path().to_path_buf();
+  #[test]
+  fn test_dirs_one_per_line() {
+    let g = TestGuard::new();
+    let original = env::current_dir().unwrap();
+    let tmp = TempDir::new().unwrap();
+    let path = tmp.path().to_path_buf();
 
-		test_input(format!("pushd {}", path.display())).unwrap();
-		g.read_output();
+    test_input(format!("pushd {}", path.display())).unwrap();
+    g.read_output();
 
-		test_input("dirs -p").unwrap();
-		let out = g.read_output();
-		let lines: Vec<&str> = out.split('\n').filter(|l| !l.is_empty()).collect();
-		assert_eq!(lines.len(), 2);
-		assert_eq!(lines[0], super::truncate_home_path(path.to_string_lossy().to_string()));
-		assert_eq!(lines[1], super::truncate_home_path(original.to_string_lossy().to_string()));
-	}
+    test_input("dirs -p").unwrap();
+    let out = g.read_output();
+    let lines: Vec<&str> = out.split('\n').filter(|l| !l.is_empty()).collect();
+    assert_eq!(lines.len(), 2);
+    assert_eq!(
+      lines[0],
+      super::truncate_home_path(path.to_string_lossy().to_string())
+    );
+    assert_eq!(
+      lines[1],
+      super::truncate_home_path(original.to_string_lossy().to_string())
+    );
+  }
 
-	#[test]
-	fn test_popd_indexed_from_top() {
-		let _g = TestGuard::new();
-		let original = env::current_dir().unwrap();
-		let tmp1 = TempDir::new().unwrap();
-		let tmp2 = TempDir::new().unwrap();
-		let path1 = tmp1.path().to_path_buf();
-		let path2 = tmp2.path().to_path_buf();
+  #[test]
+  fn test_popd_indexed_from_top() {
+    let _g = TestGuard::new();
+    let original = env::current_dir().unwrap();
+    let tmp1 = TempDir::new().unwrap();
+    let tmp2 = TempDir::new().unwrap();
+    let path1 = tmp1.path().to_path_buf();
+    let path2 = tmp2.path().to_path_buf();
 
-		// Stack: cwd=path2, [path1, original]
-		test_input(format!("pushd {}", path1.display())).unwrap();
-		test_input(format!("pushd {}", path2.display())).unwrap();
+    // Stack: cwd=path2, [path1, original]
+    test_input(format!("pushd {}", path1.display())).unwrap();
+    test_input(format!("pushd {}", path2.display())).unwrap();
 
-		// popd +1 removes index (1-1)=0 from stored dirs, i.e. path1
-		test_input("popd +1").unwrap();
-		assert_eq!(env::current_dir().unwrap(), path2); // no cd
+    // popd +1 removes index (1-1)=0 from stored dirs, i.e. path1
+    test_input("popd +1").unwrap();
+    assert_eq!(env::current_dir().unwrap(), path2); // no cd
 
-		let stack = read_meta(|m| m.dirs().clone());
-		assert_eq!(stack.len(), 1);
-		assert_eq!(stack[0], original);
-	}
+    let stack = read_meta(|m| m.dirs().clone());
+    assert_eq!(stack.len(), 1);
+    assert_eq!(stack[0], original);
+  }
 
-	#[test]
-	fn test_pushd_nonexistent_dir() {
-		let _g = TestGuard::new();
+  #[test]
+  fn test_pushd_nonexistent_dir() {
+    let _g = TestGuard::new();
 
-		let result = test_input("pushd /nonexistent_dir_12345");
-		assert!(result.is_err());
-	}
+    let result = test_input("pushd /nonexistent_dir_12345");
+    assert!(result.is_err());
+  }
 }

src/builtin/echo.rs

@@ -31,7 +31,7 @@ bitflags! {
   #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
   pub struct EchoFlags: u32 {
     const NO_NEWLINE = 0b000001;
-		const NO_ESCAPE  = 0b000010;
+    const NO_ESCAPE  = 0b000010;
     const USE_ESCAPE = 0b000100;
     const USE_PROMPT = 0b001000;
   }
@@ -55,16 +55,17 @@ pub fn echo(node: Node) -> ShResult<()> {
   }
 
   let output_channel = borrow_fd(STDOUT_FILENO);
-	let xpg_echo = read_shopts(|o| o.core.xpg_echo); // If true, echo expands escape sequences by default, and -E opts out
+  let xpg_echo = read_shopts(|o| o.core.xpg_echo); // If true, echo expands escape sequences by default, and -E opts out
 
-	let use_escape = (xpg_echo && !flags.contains(EchoFlags::NO_ESCAPE)) || flags.contains(EchoFlags::USE_ESCAPE);
+  let use_escape =
+    (xpg_echo && !flags.contains(EchoFlags::NO_ESCAPE)) || flags.contains(EchoFlags::USE_ESCAPE);
 
   let mut echo_output = prepare_echo_args(
     argv
       .into_iter()
       .map(|a| a.0) // Extract the String from the tuple of (String,Span)
       .collect::<Vec<_>>(),
-		use_escape,
+    use_escape,
     flags.contains(EchoFlags::USE_PROMPT),
   )?
   .join(" ");
@@ -207,7 +208,7 @@ pub fn get_echo_flags(opts: Vec<Opt>) -> ShResult<EchoFlags> {
       Opt::Short('n') => flags |= EchoFlags::NO_NEWLINE,
       Opt::Short('e') => flags |= EchoFlags::USE_ESCAPE,
       Opt::Short('p') => flags |= EchoFlags::USE_PROMPT,
-			Opt::Short('E') => flags |= EchoFlags::NO_ESCAPE,
+      Opt::Short('E') => flags |= EchoFlags::NO_ESCAPE,
       _ => {
         return Err(ShErr::simple(
           ShErrKind::ExecFail,
@@ -308,11 +309,7 @@ mod tests {
 
   #[test]
   fn prepare_multiple_args() {
-    let result = prepare_echo_args(
-      vec!["hello".into(), "world".into()],
-      false,
-      false,
-    ).unwrap();
+    let result = prepare_echo_args(vec!["hello".into(), "world".into()], false, false).unwrap();
     assert_eq!(result, vec!["hello", "world"]);
   }
 

src/builtin/eval.rs

@@ -37,7 +37,7 @@ pub fn eval(node: Node) -> ShResult<()> {
 
 #[cfg(test)]
 mod tests {
-  use crate::state::{self, read_vars, write_vars, VarFlags, VarKind};
+  use crate::state::{self, VarFlags, VarKind, read_vars, write_vars};
   use crate::testutil::{TestGuard, test_input};
 
   // ===================== Basic =====================
@@ -80,7 +80,8 @@ mod tests {
   #[test]
   fn eval_expands_variable() {
     let guard = TestGuard::new();
-    write_vars(|v| v.set_var("CMD", VarKind::Str("echo evaluated".into()), VarFlags::NONE)).unwrap();
+    write_vars(|v| v.set_var("CMD", VarKind::Str("echo evaluated".into()), VarFlags::NONE))
+      .unwrap();
 
     test_input("eval $CMD").unwrap();
     let out = guard.read_output();

src/builtin/exec.rs

@@ -50,7 +50,7 @@ pub fn exec_builtin(node: Node) -> ShResult<()> {
 mod tests {
   use crate::state;
   use crate::testutil::{TestGuard, test_input};
-	// Testing exec is a bit tricky since it replaces the current process, so we just test that it correctly handles the case of no arguments and the case of a nonexistent command. We can't really test that it successfully executes a command since that would replace the test process itself.
+  // Testing exec is a bit tricky since it replaces the current process, so we just test that it correctly handles the case of no arguments and the case of a nonexistent command. We can't really test that it successfully executes a command since that would replace the test process itself.
 
   #[test]
   fn exec_no_args_succeeds() {
@@ -62,7 +62,9 @@ mod tests {
   #[test]
   fn exec_nonexistent_command_fails() {
     let _g = TestGuard::new();
-    let result = test_input("exec _____________no_such_______command_xyz_____________hopefully______this_doesnt______exist_____somewhere_in___your______PATH__________________");
+    let result = test_input(
+      "exec _____________no_such_______command_xyz_____________hopefully______this_doesnt______exist_____somewhere_in___your______PATH__________________",
+    );
     assert!(result.is_err());
   }
 }

src/builtin/help.rs

@@ -0,0 +1,291 @@
+use std::{env, io::Write, path::Path};
+
+use ariadne::Span as ASpan;
+use nix::libc::STDIN_FILENO;
+
+use crate::{
+	libsh::{error::{ShErr, ShErrKind, ShResult}, guards::RawModeGuard}, parse::{NdRule, Node, Redir, RedirType, execute::{exec_input, prepare_argv}, lex::{QuoteState, Span}}, procio::{IoFrame, IoMode}, readline::{complete::ScoredCandidate, markers}, state
+};
+
+const TAG_SEQ: &str = "\x1b[1;33m";       // bold yellow — searchable tags
+const REF_SEQ: &str = "\x1b[4;36m";       // underline cyan — cross-references
+const RESET_SEQ: &str = "\x1b[0m";
+const HEADER_SEQ: &str = "\x1b[1;35m";    // bold magenta — section headers
+const CODE_SEQ: &str = "\x1b[32m";        // green — inline code
+const KEYWORD_2_SEQ: &str = "\x1b[1;32m"; // bold green — {keyword}
+const KEYWORD_3_SEQ: &str = "\x1b[3;37m"; // italic white — [optional]
+
+pub fn help(node: Node) -> ShResult<()> {
+  let NdRule::Command {
+    assignments: _,
+    argv,
+  } = node.class
+  else {
+    unreachable!()
+  };
+
+  let mut argv = prepare_argv(argv)?.into_iter().peekable();
+  let help = argv.next().unwrap(); // drop 'help'
+
+	// Join all of the word-split arguments into a single string
+	// Preserve the span too
+	let (topic, span) = if argv.peek().is_none() {
+		("help.txt".to_string(), help.1)
+	} else {
+		argv.fold((String::new(), Span::default()), |mut acc, arg| {
+			if acc.1 == Span::default() {
+				acc.1 = arg.1.clone();
+			} else {
+				let new_end = arg.1.end();
+				let start = acc.1.start();
+				acc.1.set_range(start..new_end);
+			}
+
+			if acc.0.is_empty() {
+				acc.0 = arg.0;
+			} else {
+				acc.0 = acc.0 + &format!(" {}",arg.0);
+			}
+			acc
+		})
+	};
+
+	let hpath = env::var("SHED_HPATH").unwrap_or_default();
+
+	for path in hpath.split(':') {
+		let path = Path::new(&path).join(&topic);
+		if path.is_file() {
+			let Ok(contents) = std::fs::read_to_string(&path) else {
+				continue;
+			};
+			let filename = path.file_stem()
+				.unwrap()
+				.to_string_lossy()
+				.to_string();
+
+			let unescaped = unescape_help(&contents);
+			let expanded = expand_help(&unescaped);
+			open_help(&expanded, None, Some(filename))?;
+			state::set_status(0);
+			return Ok(());
+		}
+	}
+
+	// didn't find an exact filename match, its probably a tag search
+	for path in hpath.split(':') {
+		let path = Path::new(path);
+		if let Ok(entries) = path.read_dir() {
+			for entry in entries {
+				let Ok(entry) = entry else { continue };
+				let path = entry.path();
+				let filename = path.file_stem()
+					.unwrap()
+					.to_string_lossy()
+					.to_string();
+
+				if !path.is_file() {
+					continue;
+				}
+
+				let Ok(contents) = std::fs::read_to_string(&path) else {
+					continue;
+				};
+
+				let unescaped = unescape_help(&contents);
+				let expanded = expand_help(&unescaped);
+				let tags = read_tags(&expanded);
+
+				for (tag, line) in &tags {
+				}
+
+				if let Some((matched_tag, line)) = get_best_match(&topic, &tags) {
+					open_help(&expanded, Some(line), Some(filename))?;
+					state::set_status(0);
+					return Ok(());
+				} else {
+				}
+			}
+		}
+	}
+
+	state::set_status(1);
+	Err(ShErr::at(
+		ShErrKind::NotFound,
+		span,
+		"No relevant help page found for this topic",
+	))
+}
+
+pub fn open_help(content: &str, line: Option<usize>, file_name: Option<String>) -> ShResult<()> {
+	let pager = env::var("PAGER").unwrap_or("less -R".into());
+	let line_arg = line.map(|ln| format!("+{ln}")).unwrap_or_default();
+	let prompt_arg = file_name.map(|name| format!("-Ps'{name}'")).unwrap_or_default();
+
+	let mut tmp = tempfile::NamedTempFile::new()?;
+	let tmp_path = tmp.path().to_string_lossy().to_string();
+	tmp.write_all(content.as_bytes())?;
+	tmp.flush()?;
+
+	RawModeGuard::with_cooked_mode(|| {
+		exec_input(
+			format!("{pager} {line_arg} {prompt_arg} {tmp_path}"),
+			None,
+			true,
+			Some("help".into()),
+		)
+	})
+}
+
+pub fn get_best_match(topic: &str, tags: &[(String, usize)]) -> Option<(String, usize)> {
+	let mut candidates: Vec<_> = tags.iter()
+		.map(|(tag,line)| (ScoredCandidate::new(tag.to_string()), *line))
+		.collect();
+
+	for (cand,_) in candidates.iter_mut() {
+		cand.fuzzy_score(topic);
+	}
+
+	candidates.retain(|(c,_)| c.score.unwrap_or(i32::MIN) > i32::MIN);
+	candidates.sort_by_key(|(c,_)| c.score.unwrap_or(i32::MIN));
+
+	candidates.first().map(|(c,line)| (c.content.clone(), *line))
+}
+
+pub fn read_tags(raw: &str) -> Vec<(String, usize)> {
+	let mut tags = vec![];
+
+	for (line_num, line) in raw.lines().enumerate() {
+		let mut rest = line;
+
+		while let Some(pos) = rest.find(TAG_SEQ) {
+			let after_seq = &rest[pos + TAG_SEQ.len()..];
+			if let Some(end) = after_seq.find(RESET_SEQ) {
+				let tag = &after_seq[..end];
+				tags.push((tag.to_string(), line_num + 1));
+				rest = &after_seq[end + RESET_SEQ.len()..];
+			} else {
+				break;
+			}
+		}
+	}
+
+	tags
+}
+
+pub fn expand_help(raw: &str) -> String {
+	let mut result = String::new();
+	let mut chars = raw.chars();
+
+	while let Some(ch) = chars.next() {
+		match ch {
+			markers::RESET => result.push_str(RESET_SEQ),
+			markers::TAG => result.push_str(TAG_SEQ),
+			markers::REFERENCE => result.push_str(REF_SEQ),
+			markers::HEADER => result.push_str(HEADER_SEQ),
+			markers::CODE => result.push_str(CODE_SEQ),
+			markers::KEYWORD_2 => result.push_str(KEYWORD_2_SEQ),
+			markers::KEYWORD_3 => result.push_str(KEYWORD_3_SEQ),
+			_ => result.push(ch),
+		}
+	}
+	result
+}
+
+pub fn unescape_help(raw: &str) -> String {
+	let mut result = String::new();
+	let mut chars = raw.chars().peekable();
+	let mut qt_state = QuoteState::default();
+
+	while let Some(ch) = chars.next() {
+		match ch {
+			'\\' => {
+				if let Some(next_ch) = chars.next() {
+					result.push(next_ch);
+				}
+			}
+			'\n' => {
+				result.push(ch);
+				qt_state = QuoteState::default();
+			}
+			'"' => {
+				result.push(ch);
+				qt_state.toggle_double();
+			}
+			'\'' => {
+				result.push(ch);
+				qt_state.toggle_single();
+			}
+			_ if qt_state.in_quote() || chars.peek().is_none_or(|ch| ch.is_whitespace()) => {
+				result.push(ch);
+			}
+			'*' => {
+				result.push(markers::TAG);
+				while let Some(next_ch) = chars.next() {
+					if next_ch == '*' {
+						result.push(markers::RESET);
+						break;
+					} else {
+						result.push(next_ch);
+					}
+				}
+			}
+			'|' => {
+				result.push(markers::REFERENCE);
+				while let Some(next_ch) = chars.next() {
+					if next_ch == '|' {
+						result.push(markers::RESET);
+						break;
+					} else {
+						result.push(next_ch);
+					}
+				}
+			}
+			'#' => {
+				result.push(markers::HEADER);
+				while let Some(next_ch) = chars.next() {
+					if next_ch == '#' {
+						result.push(markers::RESET);
+						break;
+					} else {
+						result.push(next_ch);
+					}
+				}
+			}
+			'`' => {
+				result.push(markers::CODE);
+				while let Some(next_ch) = chars.next() {
+					if next_ch == '`' {
+						result.push(markers::RESET);
+						break;
+					} else {
+						result.push(next_ch);
+					}
+				}
+			}
+			'{' => {
+				result.push(markers::KEYWORD_2);
+				while let Some(next_ch) = chars.next() {
+					if next_ch == '}' {
+						result.push(markers::RESET);
+						break;
+					} else {
+						result.push(next_ch);
+					}
+				}
+			}
+			'[' => {
+				result.push(markers::KEYWORD_3);
+				while let Some(next_ch) = chars.next() {
+					if next_ch == ']' {
+						result.push(markers::RESET);
+						break;
+					} else {
+						result.push(next_ch);
+					}
+				}
+			}
+			_ => result.push(ch),
+		}
+	}
+	result
+}

src/builtin/intro.rs

@@ -185,7 +185,7 @@ mod tests {
     let out = guard.read_output();
     assert!(out.contains("cat"));
     assert!(out.contains("is"));
-    assert!(out.contains("/"));  // Should show a path
+    assert!(out.contains("/")); // Should show a path
   }
 
   // ===================== Not found =====================

src/builtin/keymap.rs

@@ -81,10 +81,10 @@ impl KeyMapOpts {
         opt: Opt::Short('o'), // operator-pending mode
         takes_arg: false,
       },
-			OptSpec {
-				opt: Opt::Long("remove".into()),
-				takes_arg: true,
-			},
+      OptSpec {
+        opt: Opt::Long("remove".into()),
+        takes_arg: true,
+      },
       OptSpec {
         opt: Opt::Short('r'), // replace mode
         takes_arg: false,
@@ -180,8 +180,8 @@ pub fn keymap(node: Node) -> ShResult<()> {
 #[cfg(test)]
 mod tests {
   use super::*;
-  use crate::getopt::Opt;
   use crate::expand::expand_keymap;
+  use crate::getopt::Opt;
   use crate::state::{self, read_logic};
   use crate::testutil::{TestGuard, test_input};
 
@@ -217,7 +217,8 @@ mod tests {
     let opts = KeyMapOpts::from_opts(&[
       Opt::Short('n'),
       Opt::LongWithArg("remove".into(), "jk".into()),
-    ]).unwrap();
+    ])
+    .unwrap();
     assert_eq!(opts.remove, Some("jk".into()));
   }
 
@@ -273,10 +274,7 @@ mod tests {
     let _g = TestGuard::new();
     test_input("keymap -n jk '<ESC>'").unwrap();
 
-    let maps = read_logic(|l| l.keymaps_filtered(
-      KeyMapFlags::NORMAL,
-      &expand_keymap("jk"),
-    ));
+    let maps = read_logic(|l| l.keymaps_filtered(KeyMapFlags::NORMAL, &expand_keymap("jk")));
     assert!(!maps.is_empty());
   }
 
@@ -285,10 +283,7 @@ mod tests {
     let _g = TestGuard::new();
     test_input("keymap -i jk '<ESC>'").unwrap();
 
-    let maps = read_logic(|l| l.keymaps_filtered(
-      KeyMapFlags::INSERT,
-      &expand_keymap("jk"),
-    ));
+    let maps = read_logic(|l| l.keymaps_filtered(KeyMapFlags::INSERT, &expand_keymap("jk")));
     assert!(!maps.is_empty());
   }
 
@@ -298,10 +293,7 @@ mod tests {
     test_input("keymap -n jk '<ESC>'").unwrap();
     test_input("keymap -n jk 'dd'").unwrap();
 
-    let maps = read_logic(|l| l.keymaps_filtered(
-      KeyMapFlags::NORMAL,
-      &expand_keymap("jk"),
-    ));
+    let maps = read_logic(|l| l.keymaps_filtered(KeyMapFlags::NORMAL, &expand_keymap("jk")));
     assert_eq!(maps.len(), 1);
     assert_eq!(maps[0].action, "dd");
   }
@@ -312,10 +304,7 @@ mod tests {
     test_input("keymap -n jk '<ESC>'").unwrap();
     test_input("keymap -n --remove jk").unwrap();
 
-    let maps = read_logic(|l| l.keymaps_filtered(
-      KeyMapFlags::NORMAL,
-      &expand_keymap("jk"),
-    ));
+    let maps = read_logic(|l| l.keymaps_filtered(KeyMapFlags::NORMAL, &expand_keymap("jk")));
     assert!(maps.is_empty());
   }
 

src/builtin/map.rs

@@ -389,7 +389,7 @@ pub fn get_map_opts(opts: Vec<Opt>) -> MapOpts {
 
 #[cfg(test)]
 mod tests {
-  use super::{MapNode, MapFlags, get_map_opts};
+  use super::{MapFlags, MapNode, get_map_opts};
   use crate::getopt::Opt;
   use crate::state::{self, read_vars};
   use crate::testutil::{TestGuard, test_input};
@@ -433,10 +433,7 @@ mod tests {
   #[test]
   fn mapnode_remove_nested() {
     let mut root = MapNode::default();
-    root.set(
-      &["a".into(), "b".into()],
-      MapNode::StaticLeaf("val".into()),
-    );
+    root.set(&["a".into(), "b".into()], MapNode::StaticLeaf("val".into()));
     root.remove(&["a".into(), "b".into()]);
     assert!(root.get(&["a".into(), "b".into()]).is_none());
     // Parent branch should still exist

src/builtin/mod.rs

@@ -17,20 +17,22 @@ pub mod keymap;
 pub mod map;
 pub mod pwd;
 pub mod read;
+pub mod resource;
+pub mod seek;
 pub mod shift;
 pub mod shopt;
 pub mod source;
 pub mod test; // [[ ]] thing
 pub mod trap;
 pub mod varcmds;
-pub mod resource;
+pub mod help;
 
-pub const BUILTINS: [&str; 49] = [
-  "echo", "cd", "read", "export", "local", "pwd", "source", ".", "shift", "jobs", "fg", "bg", "disown",
-  "alias", "unalias", "return", "break", "continue", "exit", "shopt", "builtin",
+pub const BUILTINS: [&str; 51] = [
+  "echo", "cd", "read", "export", "local", "pwd", "source", ".", "shift", "jobs", "fg", "bg",
+  "disown", "alias", "unalias", "return", "break", "continue", "exit", "shopt", "builtin",
   "command", "trap", "pushd", "popd", "dirs", "exec", "eval", "true", "false", ":", "readonly",
   "unset", "complete", "compgen", "map", "pop", "fpop", "push", "fpush", "rotate", "wait", "type",
-  "getopts", "keymap", "read_key", "autocmd", "ulimit", "umask"
+  "getopts", "keymap", "read_key", "autocmd", "ulimit", "umask", "seek", "help",
 ];
 
 pub fn true_builtin() -> ShResult<()> {
@@ -50,31 +52,34 @@ pub fn noop_builtin() -> ShResult<()> {
 
 #[cfg(test)]
 pub mod tests {
-    use crate::{state, testutil::{TestGuard, test_input}};
+  use crate::{
+    state,
+    testutil::{TestGuard, test_input},
+  };
 
-	// You can never be too sure!!!!!!
+  // You can never be too sure!!!!!!
 
-	#[test]
-	fn test_true() {
-		let _g = TestGuard::new();
-		test_input("true").unwrap();
+  #[test]
+  fn test_true() {
+    let _g = TestGuard::new();
+    test_input("true").unwrap();
 
-		assert_eq!(state::get_status(), 0);
-	}
+    assert_eq!(state::get_status(), 0);
+  }
 
-	#[test]
-	fn test_false() {
-		let _g = TestGuard::new();
-		test_input("false").unwrap();
+  #[test]
+  fn test_false() {
+    let _g = TestGuard::new();
+    test_input("false").unwrap();
 
-		assert_eq!(state::get_status(), 1);
-	}
+    assert_eq!(state::get_status(), 1);
+  }
 
-	#[test]
-	fn test_noop() {
-		let _g = TestGuard::new();
-		test_input(":").unwrap();
+  #[test]
+  fn test_noop() {
+    let _g = TestGuard::new();
+    test_input(":").unwrap();
 
-		assert_eq!(state::get_status(), 0);
-	}
+    assert_eq!(state::get_status(), 0);
+  }
 }

src/builtin/pwd.rs

@@ -27,10 +27,10 @@ pub fn pwd(node: Node) -> ShResult<()> {
 
 #[cfg(test)]
 mod tests {
-  use std::env;
-  use tempfile::TempDir;
   use crate::state;
   use crate::testutil::{TestGuard, test_input};
+  use std::env;
+  use tempfile::TempDir;
 
   #[test]
   fn pwd_prints_cwd() {

src/builtin/read.rs

@@ -367,7 +367,7 @@ pub fn get_read_key_opts(opts: Vec<Opt>) -> ShResult<ReadKeyOpts> {
 
 #[cfg(test)]
 mod tests {
-  use crate::state::{self, read_vars, write_vars, VarFlags, VarKind};
+  use crate::state::{self, VarFlags, VarKind, read_vars, write_vars};
   use crate::testutil::{TestGuard, test_input};
 
   // ===================== Basic read into REPLY =====================

src/builtin/resource.rs

@@ -1,92 +1,115 @@
 use ariadne::Fmt;
-use nix::{libc::STDOUT_FILENO, sys::{resource::{Resource, getrlimit, setrlimit}, stat::{Mode, umask}}, unistd::write};
-
-use crate::{
-  getopt::{Opt, OptSpec, get_opts_from_tokens_strict}, libsh::error::{ShErr, ShErrKind, ShResult, ShResultExt, next_color}, parse::{NdRule, Node}, procio::borrow_fd, state::{self}
+use nix::{
+  libc::STDOUT_FILENO,
+  sys::{
+    resource::{Resource, getrlimit, setrlimit},
+    stat::{Mode, umask},
+  },
+  unistd::write,
 };
 
-fn ulimit_opt_spec() -> [OptSpec;5] {
-	[
-		OptSpec {
-			opt: Opt::Short('n'), // file descriptors
-			takes_arg: true,
-		},
-		OptSpec {
-			opt: Opt::Short('u'), // max user processes
-			takes_arg: true,
-		},
-		OptSpec {
-			opt: Opt::Short('s'), // stack size
-			takes_arg: true,
-		},
-		OptSpec {
-			opt: Opt::Short('c'), // core dump file size
-			takes_arg: true,
-		},
-		OptSpec {
-			opt: Opt::Short('v'), // virtual memory
-			takes_arg: true,
-		}
-	]
+use crate::{
+  getopt::{Opt, OptSpec, get_opts_from_tokens_strict},
+  libsh::error::{ShErr, ShErrKind, ShResult, ShResultExt, next_color},
+  parse::{NdRule, Node},
+  procio::borrow_fd,
+  state::{self},
+};
+
+fn ulimit_opt_spec() -> [OptSpec; 5] {
+  [
+    OptSpec {
+      opt: Opt::Short('n'), // file descriptors
+      takes_arg: true,
+    },
+    OptSpec {
+      opt: Opt::Short('u'), // max user processes
+      takes_arg: true,
+    },
+    OptSpec {
+      opt: Opt::Short('s'), // stack size
+      takes_arg: true,
+    },
+    OptSpec {
+      opt: Opt::Short('c'), // core dump file size
+      takes_arg: true,
+    },
+    OptSpec {
+      opt: Opt::Short('v'), // virtual memory
+      takes_arg: true,
+    },
+  ]
 }
 
 struct UlimitOpts {
-	fds: Option<u64>,
-	procs: Option<u64>,
-	stack: Option<u64>,
-	core: Option<u64>,
-	vmem: Option<u64>,
+  fds: Option<u64>,
+  procs: Option<u64>,
+  stack: Option<u64>,
+  core: Option<u64>,
+  vmem: Option<u64>,
 }
 
 fn get_ulimit_opts(opt: &[Opt]) -> ShResult<UlimitOpts> {
-	let mut opts = UlimitOpts {
-		fds: None,
-		procs: None,
-		stack: None,
-		core: None,
-		vmem: None,
-	};
+  let mut opts = UlimitOpts {
+    fds: None,
+    procs: None,
+    stack: None,
+    core: None,
+    vmem: None,
+  };
 
-	for o in opt {
-		match o {
-			Opt::ShortWithArg('n', arg) => {
-				opts.fds = Some(arg.parse().map_err(|_| ShErr::simple(
-					ShErrKind::ParseErr,
-					format!("invalid argument for -n: {}", arg.fg(next_color())),
-				))?);
-			},
-			Opt::ShortWithArg('u', arg) => {
-				opts.procs = Some(arg.parse().map_err(|_| ShErr::simple(
-					ShErrKind::ParseErr,
-					format!("invalid argument for -u: {}", arg.fg(next_color())),
-				))?);
-			},
-			Opt::ShortWithArg('s', arg) => {
-				opts.stack = Some(arg.parse().map_err(|_| ShErr::simple(
-					ShErrKind::ParseErr,
-					format!("invalid argument for -s: {}", arg.fg(next_color())),
-				))?);
-			},
-			Opt::ShortWithArg('c', arg) => {
-				opts.core = Some(arg.parse().map_err(|_| ShErr::simple(
-					ShErrKind::ParseErr,
-					format!("invalid argument for -c: {}", arg.fg(next_color())),
-				))?);
-			},
-			Opt::ShortWithArg('v', arg) => {
-				opts.vmem = Some(arg.parse().map_err(|_| ShErr::simple(
-					ShErrKind::ParseErr,
-					format!("invalid argument for -v: {}", arg.fg(next_color())),
-				))?);
-			},
-			o => return Err(ShErr::simple(
-				ShErrKind::ParseErr,
-				format!("invalid option: {}", o.fg(next_color())),
-			)),
-		}
-	}
+  for o in opt {
+    match o {
+      Opt::ShortWithArg('n', arg) => {
+        opts.fds = Some(arg.parse().map_err(|_| {
+          ShErr::simple(
+            ShErrKind::ParseErr,
+            format!("invalid argument for -n: {}", arg.fg(next_color())),
+          )
+        })?);
+      }
+      Opt::ShortWithArg('u', arg) => {
+        opts.procs = Some(arg.parse().map_err(|_| {
+          ShErr::simple(
+            ShErrKind::ParseErr,
+            format!("invalid argument for -u: {}", arg.fg(next_color())),
+          )
+        })?);
+      }
+      Opt::ShortWithArg('s', arg) => {
+        opts.stack = Some(arg.parse().map_err(|_| {
+          ShErr::simple(
+            ShErrKind::ParseErr,
+            format!("invalid argument for -s: {}", arg.fg(next_color())),
+          )
+        })?);
+      }
+      Opt::ShortWithArg('c', arg) => {
+        opts.core = Some(arg.parse().map_err(|_| {
+          ShErr::simple(
+            ShErrKind::ParseErr,
+            format!("invalid argument for -c: {}", arg.fg(next_color())),
+          )
+        })?);
+      }
+      Opt::ShortWithArg('v', arg) => {
+        opts.vmem = Some(arg.parse().map_err(|_| {
+          ShErr::simple(
+            ShErrKind::ParseErr,
+            format!("invalid argument for -v: {}", arg.fg(next_color())),
+          )
+        })?);
+      }
+      o => {
+        return Err(ShErr::simple(
+          ShErrKind::ParseErr,
+          format!("invalid option: {}", o.fg(next_color())),
+        ));
+      }
+    }
+  }
 
-	Ok(opts)
+  Ok(opts)
 }
 
 pub fn ulimit(node: Node) -> ShResult<()> {
@@ -99,282 +122,308 @@ pub fn ulimit(node: Node) -> ShResult<()> {
     unreachable!()
   };
 
-	let (_, opts) = get_opts_from_tokens_strict(argv, &ulimit_opt_spec()).promote_err(span.clone())?;
-	let ulimit_opts = get_ulimit_opts(&opts).promote_err(span.clone())?;
+  let (_, opts) =
+    get_opts_from_tokens_strict(argv, &ulimit_opt_spec()).promote_err(span.clone())?;
+  let ulimit_opts = get_ulimit_opts(&opts).promote_err(span.clone())?;
 
-	if let Some(fds) = ulimit_opts.fds {
-		let (_, hard) =  getrlimit(Resource::RLIMIT_NOFILE).map_err(|e| ShErr::at(
-			ShErrKind::ExecFail,
-			span.clone(),
-			format!("failed to get file descriptor limit: {}", e),
-		))?;
-		setrlimit(Resource::RLIMIT_NOFILE, fds, hard).map_err(|e| ShErr::at(
-			ShErrKind::ExecFail,
-			span.clone(),
-			format!("failed to set file descriptor limit: {}", e),
-		))?;
-	}
-	if let Some(procs) = ulimit_opts.procs {
-		let (_, hard) =  getrlimit(Resource::RLIMIT_NPROC).map_err(|e| ShErr::at(
-			ShErrKind::ExecFail,
-			span.clone(),
-			format!("failed to get process limit: {}", e),
-		))?;
-		setrlimit(Resource::RLIMIT_NPROC, procs, hard).map_err(|e| ShErr::at(
-			ShErrKind::ExecFail,
-			span.clone(),
-			format!("failed to set process limit: {}", e),
-		))?;
-	}
-	if let Some(stack) = ulimit_opts.stack {
-		let (_, hard) =  getrlimit(Resource::RLIMIT_STACK).map_err(|e| ShErr::at(
-			ShErrKind::ExecFail,
-			span.clone(),
-			format!("failed to get stack size limit: {}", e),
-		))?;
-		setrlimit(Resource::RLIMIT_STACK, stack, hard).map_err(|e| ShErr::at(
-			ShErrKind::ExecFail,
-			span.clone(),
-			format!("failed to set stack size limit: {}", e),
-		))?;
-	}
-	if let Some(core) = ulimit_opts.core {
-		let (_, hard) =  getrlimit(Resource::RLIMIT_CORE).map_err(|e| ShErr::at(
-			ShErrKind::ExecFail,
-			span.clone(),
-			format!("failed to get core dump size limit: {}", e),
-		))?;
-		setrlimit(Resource::RLIMIT_CORE, core, hard).map_err(|e| ShErr::at(
-			ShErrKind::ExecFail,
-			span.clone(),
-			format!("failed to set core dump size limit: {}", e),
-		))?;
-	}
-	if let Some(vmem) = ulimit_opts.vmem {
-		let (_, hard) =  getrlimit(Resource::RLIMIT_AS).map_err(|e| ShErr::at(
-			ShErrKind::ExecFail,
-			span.clone(),
-			format!("failed to get virtual memory limit: {}", e),
-		))?;
-		setrlimit(Resource::RLIMIT_AS, vmem, hard).map_err(|e| ShErr::at(
-			ShErrKind::ExecFail,
-			span.clone(),
-			format!("failed to set virtual memory limit: {}", e),
-		))?;
-	}
+  if let Some(fds) = ulimit_opts.fds {
+    let (_, hard) = getrlimit(Resource::RLIMIT_NOFILE).map_err(|e| {
+      ShErr::at(
+        ShErrKind::ExecFail,
+        span.clone(),
+        format!("failed to get file descriptor limit: {}", e),
+      )
+    })?;
+    setrlimit(Resource::RLIMIT_NOFILE, fds, hard).map_err(|e| {
+      ShErr::at(
+        ShErrKind::ExecFail,
+        span.clone(),
+        format!("failed to set file descriptor limit: {}", e),
+      )
+    })?;
+  }
+  if let Some(procs) = ulimit_opts.procs {
+    let (_, hard) = getrlimit(Resource::RLIMIT_NPROC).map_err(|e| {
+      ShErr::at(
+        ShErrKind::ExecFail,
+        span.clone(),
+        format!("failed to get process limit: {}", e),
+      )
+    })?;
+    setrlimit(Resource::RLIMIT_NPROC, procs, hard).map_err(|e| {
+      ShErr::at(
+        ShErrKind::ExecFail,
+        span.clone(),
+        format!("failed to set process limit: {}", e),
+      )
+    })?;
+  }
+  if let Some(stack) = ulimit_opts.stack {
+    let (_, hard) = getrlimit(Resource::RLIMIT_STACK).map_err(|e| {
+      ShErr::at(
+        ShErrKind::ExecFail,
+        span.clone(),
+        format!("failed to get stack size limit: {}", e),
+      )
+    })?;
+    setrlimit(Resource::RLIMIT_STACK, stack, hard).map_err(|e| {
+      ShErr::at(
+        ShErrKind::ExecFail,
+        span.clone(),
+        format!("failed to set stack size limit: {}", e),
+      )
+    })?;
+  }
+  if let Some(core) = ulimit_opts.core {
+    let (_, hard) = getrlimit(Resource::RLIMIT_CORE).map_err(|e| {
+      ShErr::at(
+        ShErrKind::ExecFail,
+        span.clone(),
+        format!("failed to get core dump size limit: {}", e),
+      )
+    })?;
+    setrlimit(Resource::RLIMIT_CORE, core, hard).map_err(|e| {
+      ShErr::at(
+        ShErrKind::ExecFail,
+        span.clone(),
+        format!("failed to set core dump size limit: {}", e),
+      )
+    })?;
+  }
+  if let Some(vmem) = ulimit_opts.vmem {
+    let (_, hard) = getrlimit(Resource::RLIMIT_AS).map_err(|e| {
+      ShErr::at(
+        ShErrKind::ExecFail,
+        span.clone(),
+        format!("failed to get virtual memory limit: {}", e),
+      )
+    })?;
+    setrlimit(Resource::RLIMIT_AS, vmem, hard).map_err(|e| {
+      ShErr::at(
+        ShErrKind::ExecFail,
+        span.clone(),
+        format!("failed to set virtual memory limit: {}", e),
+      )
+    })?;
+  }
 
   state::set_status(0);
   Ok(())
 }
 
 pub fn umask_builtin(node: Node) -> ShResult<()> {
-	let span = node.get_span();
-	let NdRule::Command {
-		assignments: _,
-		argv,
-	} = node.class else {	unreachable!() };
+  let span = node.get_span();
+  let NdRule::Command {
+    assignments: _,
+    argv,
+  } = node.class
+  else {
+    unreachable!()
+  };
 
-	let (argv, opts) = get_opts_from_tokens_strict(
-		argv,
-		&[OptSpec { opt: Opt::Short('S'), takes_arg: false }],
-	)?;
-	let argv = &argv[1..]; // skip command name
+  let (argv, opts) = get_opts_from_tokens_strict(
+    argv,
+    &[OptSpec {
+      opt: Opt::Short('S'),
+      takes_arg: false,
+    }],
+  )?;
+  let argv = &argv[1..]; // skip command name
 
-	let old = umask(Mode::empty());
-	umask(old);
-	let mut old_bits = old.bits();
+  let old = umask(Mode::empty());
+  umask(old);
+  let mut old_bits = old.bits();
 
-	if !argv.is_empty() {
-		if argv.len() > 1 {
-			return Err(ShErr::at(
-				ShErrKind::ParseErr,
-				span.clone(),
-				format!("umask takes at most one argument, got {}", argv.len()),
-			));
-		}
-		let arg = argv[0].clone();
-		let raw = arg.as_str();
-		if raw.chars().any(|c| c.is_ascii_digit()) {
-			let mode_raw = u32::from_str_radix(raw, 8).map_err(|_| ShErr::at(
-				ShErrKind::ParseErr,
-				span.clone(),
-				format!("invalid numeric umask: {}", raw.fg(next_color())),
-			))?;
+  if !argv.is_empty() {
+    if argv.len() > 1 {
+      return Err(ShErr::at(
+        ShErrKind::ParseErr,
+        span.clone(),
+        format!("umask takes at most one argument, got {}", argv.len()),
+      ));
+    }
+    let arg = argv[0].clone();
+    let raw = arg.as_str();
+    if raw.chars().any(|c| c.is_ascii_digit()) {
+      let mode_raw = u32::from_str_radix(raw, 8).map_err(|_| {
+        ShErr::at(
+          ShErrKind::ParseErr,
+          span.clone(),
+          format!("invalid numeric umask: {}", raw.fg(next_color())),
+        )
+      })?;
 
-			let mode = Mode::from_bits(mode_raw).ok_or_else(|| ShErr::at(
-				ShErrKind::ParseErr,
-				span.clone(),
-				format!("invalid umask value: {}", raw.fg(next_color())),
-			))?;
+      let mode = Mode::from_bits(mode_raw).ok_or_else(|| {
+        ShErr::at(
+          ShErrKind::ParseErr,
+          span.clone(),
+          format!("invalid umask value: {}", raw.fg(next_color())),
+        )
+      })?;
 
-			umask(mode);
-		} else {
-			let parts = raw.split(',');
+      umask(mode);
+    } else {
+      let parts = raw.split(',');
 
-			for part in parts {
-				if let Some((who,bits)) = part.split_once('=') {
-					let mut new_bits = 0;
-					if bits.contains('r') {
-						new_bits |= 4;
-					}
-					if bits.contains('w') {
-						new_bits |= 2;
-					}
-					if bits.contains('x') {
-						new_bits |= 1;
-					}
+      for part in parts {
+        if let Some((who, bits)) = part.split_once('=') {
+          let mut new_bits = 0;
+          if bits.contains('r') {
+            new_bits |= 4;
+          }
+          if bits.contains('w') {
+            new_bits |= 2;
+          }
+          if bits.contains('x') {
+            new_bits |= 1;
+          }
 
-					for ch in who.chars() {
-						match ch {
-							'o' => {
-								old_bits &= !0o7;
-								old_bits |= !new_bits & 0o7;
-							}
-							'g' => {
-								old_bits &= !(0o7 << 3);
-								old_bits |= (!new_bits & 0o7) << 3;
-							}
-							'u' => {
-								old_bits &= !(0o7 << 6);
-								old_bits |= (!new_bits & 0o7) << 6;
-							}
-							'a' => {
-								let denied = !new_bits & 0o7;
-								old_bits = denied | (denied << 3) | (denied << 6);
-							}
-							_ => {
-								return Err(ShErr::at(
-									ShErrKind::ParseErr,
-									span.clone(),
-									format!("invalid umask 'who' character: {}", ch.fg(next_color())),
-								));
-							}
-						}
-					}
+          for ch in who.chars() {
+            match ch {
+              'o' => {
+                old_bits &= !0o7;
+                old_bits |= !new_bits & 0o7;
+              }
+              'g' => {
+                old_bits &= !(0o7 << 3);
+                old_bits |= (!new_bits & 0o7) << 3;
+              }
+              'u' => {
+                old_bits &= !(0o7 << 6);
+                old_bits |= (!new_bits & 0o7) << 6;
+              }
+              'a' => {
+                let denied = !new_bits & 0o7;
+                old_bits = denied | (denied << 3) | (denied << 6);
+              }
+              _ => {
+                return Err(ShErr::at(
+                  ShErrKind::ParseErr,
+                  span.clone(),
+                  format!("invalid umask 'who' character: {}", ch.fg(next_color())),
+                ));
+              }
+            }
+          }
 
-					umask(Mode::from_bits_truncate(old_bits));
-				} else if let Some((who,bits)) = part.split_once('+') {
-					let mut new_bits = 0;
-					if bits.contains('r') {
-						new_bits |= 4;
-					}
-					if bits.contains('w') {
-						new_bits |= 2;
-					}
-					if bits.contains('x') {
-						new_bits |= 1;
-					}
+          umask(Mode::from_bits_truncate(old_bits));
+        } else if let Some((who, bits)) = part.split_once('+') {
+          let mut new_bits = 0;
+          if bits.contains('r') {
+            new_bits |= 4;
+          }
+          if bits.contains('w') {
+            new_bits |= 2;
+          }
+          if bits.contains('x') {
+            new_bits |= 1;
+          }
 
-					for ch in who.chars() {
-						match ch {
-							'o' => {
-								old_bits &= !(new_bits & 0o7);
-							}
-							'g' => {
-								old_bits &= !((new_bits & 0o7) << 3);
-							}
-							'u' => {
-								old_bits &= !((new_bits & 0o7) << 6);
-							}
-							'a' => {
-								let mask = new_bits & 0o7;
-								old_bits &= !(mask | (mask << 3) | (mask << 6));
-							}
-							_ => {
-								return Err(ShErr::at(
-									ShErrKind::ParseErr,
-									span.clone(),
-									format!("invalid umask 'who' character: {}", ch.fg(next_color())),
-								));
-							}
-						}
-					}
+          for ch in who.chars() {
+            match ch {
+              'o' => {
+                old_bits &= !(new_bits & 0o7);
+              }
+              'g' => {
+                old_bits &= !((new_bits & 0o7) << 3);
+              }
+              'u' => {
+                old_bits &= !((new_bits & 0o7) << 6);
+              }
+              'a' => {
+                let mask = new_bits & 0o7;
+                old_bits &= !(mask | (mask << 3) | (mask << 6));
+              }
+              _ => {
+                return Err(ShErr::at(
+                  ShErrKind::ParseErr,
+                  span.clone(),
+                  format!("invalid umask 'who' character: {}", ch.fg(next_color())),
+                ));
+              }
+            }
+          }
 
-					umask(Mode::from_bits_truncate(old_bits));
-				} else if let Some((who,bits)) = part.split_once('-') {
-					let mut new_bits = 0;
-					if bits.contains('r') {
-						new_bits |= 4;
-					}
-					if bits.contains('w') {
-						new_bits |= 2;
-					}
-					if bits.contains('x') {
-						new_bits |= 1;
-					}
+          umask(Mode::from_bits_truncate(old_bits));
+        } else if let Some((who, bits)) = part.split_once('-') {
+          let mut new_bits = 0;
+          if bits.contains('r') {
+            new_bits |= 4;
+          }
+          if bits.contains('w') {
+            new_bits |= 2;
+          }
+          if bits.contains('x') {
+            new_bits |= 1;
+          }
 
-					for ch in who.chars() {
-						match ch {
-							'o' => {
-								old_bits |= new_bits & 0o7;
-							}
-							'g' => {
-								old_bits |= (new_bits << 3) & (0o7 << 3);
-							}
-							'u' => {
-								old_bits |= (new_bits << 6) & (0o7 << 6);
-							}
-							'a' => {
-								old_bits |= (new_bits | (new_bits << 3) | (new_bits << 6)) & 0o777;
-							}
-							_ => {
-								return Err(ShErr::at(
-									ShErrKind::ParseErr,
-									span.clone(),
-									format!("invalid umask 'who' character: {}", ch.fg(next_color())),
-								));
-							}
-						}
-					}
+          for ch in who.chars() {
+            match ch {
+              'o' => {
+                old_bits |= new_bits & 0o7;
+              }
+              'g' => {
+                old_bits |= (new_bits << 3) & (0o7 << 3);
+              }
+              'u' => {
+                old_bits |= (new_bits << 6) & (0o7 << 6);
+              }
+              'a' => {
+                old_bits |= (new_bits | (new_bits << 3) | (new_bits << 6)) & 0o777;
+              }
+              _ => {
+                return Err(ShErr::at(
+                  ShErrKind::ParseErr,
+                  span.clone(),
+                  format!("invalid umask 'who' character: {}", ch.fg(next_color())),
+                ));
+              }
+            }
+          }
 
-					umask(Mode::from_bits_truncate(old_bits));
-				} else {
-					return Err(ShErr::at(
-						ShErrKind::ParseErr,
-						span.clone(),
-						format!("invalid symbolic umask part: {}", part.fg(next_color())),
-					));
-				}
-			}
-		}
+          umask(Mode::from_bits_truncate(old_bits));
+        } else {
+          return Err(ShErr::at(
+            ShErrKind::ParseErr,
+            span.clone(),
+            format!("invalid symbolic umask part: {}", part.fg(next_color())),
+          ));
+        }
+      }
+    }
+  } else if !opts.is_empty() {
+    let u = (old_bits >> 6) & 0o7;
+    let g = (old_bits >> 3) & 0o7;
+    let o = old_bits & 0o7;
+    let mut u_str = String::from("u=");
+    let mut g_str = String::from("g=");
+    let mut o_str = String::from("o=");
+    let stuff = [(u, &mut u_str), (g, &mut g_str), (o, &mut o_str)];
+    for (bits, out) in stuff.into_iter() {
+      if bits & 4 == 0 {
+        out.push('r');
+      }
+      if bits & 2 == 0 {
+        out.push('w');
+      }
+      if bits & 1 == 0 {
+        out.push('x');
+      }
+    }
 
-	} else if !opts.is_empty() {
-		let u = (old_bits >> 6) & 0o7;
-		let g = (old_bits >> 3) & 0o7;
-		let o = old_bits & 0o7;
-		let mut u_str = String::from("u=");
-		let mut g_str = String::from("g=");
-		let mut o_str = String::from("o=");
-		let stuff = [
-			(u, &mut u_str),
-			(g, &mut g_str),
-			(o, &mut o_str),
-		];
-		for (bits, out) in stuff.into_iter() {
-			if bits & 4 == 0 {
-				out.push('r');
-			}
-			if bits & 2 == 0 {
-				out.push('w');
-			}
-			if bits & 1 == 0 {
-				out.push('x');
-			}
-		}
+    let msg = [u_str, g_str, o_str].join(",");
+    let stdout = borrow_fd(STDOUT_FILENO);
+    write(stdout, msg.as_bytes())?;
+    write(stdout, b"\n")?;
+  } else {
+    let raw = format!("{:04o}\n", old_bits);
 
-		let msg = [u_str,g_str,o_str].join(",");
-		let stdout = borrow_fd(STDOUT_FILENO);
-		write(stdout, msg.as_bytes())?;
-		write(stdout, b"\n")?;
-	} else {
-		let raw = format!("{:04o}\n", old_bits);
+    let stdout = borrow_fd(STDOUT_FILENO);
+    write(stdout, raw.as_bytes())?;
+  }
 
-		let stdout = borrow_fd(STDOUT_FILENO);
-		write(stdout, raw.as_bytes())?;
-	}
-
-	state::set_status(0);
-	Ok(())
+  state::set_status(0);
+  Ok(())
 }
 
 #[cfg(test)]
@@ -423,7 +472,8 @@ mod tests {
     let opts = get_ulimit_opts(&[
       Opt::ShortWithArg('n', "256".into()),
       Opt::ShortWithArg('c', "0".into()),
-    ]).unwrap();
+    ])
+    .unwrap();
     assert_eq!(opts.fds, Some(256));
     assert_eq!(opts.core, Some(0));
     assert!(opts.procs.is_none());

src/builtin/seek.rs

@@ -0,0 +1,263 @@
+use nix::{
+  libc::STDOUT_FILENO,
+  unistd::{Whence, lseek, write},
+};
+
+use crate::{
+  getopt::{Opt, OptSpec, get_opts_from_tokens},
+  libsh::error::{ShErr, ShErrKind, ShResult},
+  parse::{NdRule, Node, execute::prepare_argv},
+  procio::borrow_fd,
+  state,
+};
+
+pub const LSEEK_OPTS: [OptSpec; 2] = [
+  OptSpec {
+    opt: Opt::Short('c'),
+    takes_arg: false,
+  },
+  OptSpec {
+    opt: Opt::Short('e'),
+    takes_arg: false,
+  },
+];
+
+pub struct LseekOpts {
+  cursor_rel: bool,
+  end_rel: bool,
+}
+
+pub fn seek(node: Node) -> ShResult<()> {
+  let NdRule::Command {
+    assignments: _,
+    argv,
+  } = node.class
+  else {
+    unreachable!()
+  };
+
+  let (argv, opts) = get_opts_from_tokens(argv, &LSEEK_OPTS)?;
+  let lseek_opts = get_lseek_opts(opts)?;
+  let mut argv = prepare_argv(argv)?.into_iter();
+  argv.next(); // drop 'seek'
+
+  let Some(fd) = argv.next() else {
+    return Err(ShErr::simple(
+      ShErrKind::ExecFail,
+      "lseek: Missing required argument 'fd'",
+    ));
+  };
+  let Ok(fd) = fd.0.parse::<u32>() else {
+    return Err(
+      ShErr::at(ShErrKind::ExecFail, fd.1, "Invalid file descriptor")
+        .with_note("file descriptors are integers"),
+    );
+  };
+
+  let Some(offset) = argv.next() else {
+    return Err(ShErr::simple(
+      ShErrKind::ExecFail,
+      "lseek: Missing required argument 'offset'",
+    ));
+  };
+  let Ok(offset) = offset.0.parse::<i64>() else {
+    return Err(
+      ShErr::at(ShErrKind::ExecFail, offset.1, "Invalid offset")
+        .with_note("offset can be a positive or negative integer"),
+    );
+  };
+
+  let whence = if lseek_opts.cursor_rel {
+    Whence::SeekCur
+  } else if lseek_opts.end_rel {
+    Whence::SeekEnd
+  } else {
+    Whence::SeekSet
+  };
+
+  match lseek(fd as i32, offset, whence) {
+    Ok(new_offset) => {
+      let stdout = borrow_fd(STDOUT_FILENO);
+      let buf = new_offset.to_string() + "\n";
+      write(stdout, buf.as_bytes())?;
+    }
+    Err(e) => {
+      state::set_status(1);
+      return Err(e.into());
+    }
+  }
+
+  state::set_status(0);
+  Ok(())
+}
+
+pub fn get_lseek_opts(opts: Vec<Opt>) -> ShResult<LseekOpts> {
+  let mut lseek_opts = LseekOpts {
+    cursor_rel: false,
+    end_rel: false,
+  };
+
+  for opt in opts {
+    match opt {
+      Opt::Short('c') => lseek_opts.cursor_rel = true,
+      Opt::Short('e') => lseek_opts.end_rel = true,
+      _ => {
+        return Err(ShErr::simple(
+          ShErrKind::ExecFail,
+          format!("lseek: Unexpected flag '{opt}'"),
+        ));
+      }
+    }
+  }
+
+  Ok(lseek_opts)
+}
+
+#[cfg(test)]
+mod tests {
+  use crate::testutil::{TestGuard, test_input};
+  use pretty_assertions::assert_eq;
+
+  #[test]
+  fn seek_set_beginning() {
+    let dir = tempfile::TempDir::new().unwrap();
+    let path = dir.path().join("seek.txt");
+    std::fs::write(&path, "hello world\n").unwrap();
+    let g = TestGuard::new();
+
+    test_input(format!("exec 9<> {}", path.display())).unwrap();
+    test_input("seek 9 0").unwrap();
+
+    let out = g.read_output();
+    assert_eq!(out, "0\n");
+  }
+
+  #[test]
+  fn seek_set_offset() {
+    let dir = tempfile::TempDir::new().unwrap();
+    let path = dir.path().join("seek.txt");
+    std::fs::write(&path, "hello world\n").unwrap();
+    let g = TestGuard::new();
+
+    test_input(format!("exec 9<> {}", path.display())).unwrap();
+    test_input("seek 9 6").unwrap();
+
+    let out = g.read_output();
+    assert_eq!(out, "6\n");
+  }
+
+  #[test]
+  fn seek_then_read() {
+    let dir = tempfile::TempDir::new().unwrap();
+    let path = dir.path().join("seek.txt");
+    std::fs::write(&path, "hello world\n").unwrap();
+    let g = TestGuard::new();
+
+    test_input(format!("exec 9<> {}", path.display())).unwrap();
+    test_input("seek 9 6").unwrap();
+    // Clear the seek output
+    g.read_output();
+
+    test_input("read line <&9").unwrap();
+    let val = crate::state::read_vars(|v| v.get_var("line"));
+    assert_eq!(val, "world");
+  }
+
+  #[test]
+  fn seek_cur_relative() {
+    let dir = tempfile::TempDir::new().unwrap();
+    let path = dir.path().join("seek.txt");
+    std::fs::write(&path, "abcdefghij\n").unwrap();
+    let g = TestGuard::new();
+
+    test_input(format!("exec 9<> {}", path.display())).unwrap();
+    test_input("seek 9 3").unwrap();
+    test_input("seek -c 9 4").unwrap();
+
+    let out = g.read_output();
+    assert_eq!(out, "3\n7\n");
+  }
+
+  #[test]
+  fn seek_end() {
+    let dir = tempfile::TempDir::new().unwrap();
+    let path = dir.path().join("seek.txt");
+    std::fs::write(&path, "hello\n").unwrap(); // 6 bytes
+    let g = TestGuard::new();
+
+    test_input(format!("exec 9<> {}", path.display())).unwrap();
+    test_input("seek -e 9 0").unwrap();
+
+    let out = g.read_output();
+    assert_eq!(out, "6\n");
+  }
+
+  #[test]
+  fn seek_end_negative() {
+    let dir = tempfile::TempDir::new().unwrap();
+    let path = dir.path().join("seek.txt");
+    std::fs::write(&path, "hello\n").unwrap(); // 6 bytes
+    let g = TestGuard::new();
+
+    test_input(format!("exec 9<> {}", path.display())).unwrap();
+    test_input("seek -e 9 -2").unwrap();
+
+    let out = g.read_output();
+    assert_eq!(out, "4\n");
+  }
+
+  #[test]
+  fn seek_write_overwrite() {
+    let dir = tempfile::TempDir::new().unwrap();
+    let path = dir.path().join("seek.txt");
+    std::fs::write(&path, "hello world\n").unwrap();
+    let _g = TestGuard::new();
+
+    test_input(format!("exec 9<> {}", path.display())).unwrap();
+    test_input("seek 9 6").unwrap();
+    test_input("echo -n 'WORLD' >&9").unwrap();
+
+    let contents = std::fs::read_to_string(&path).unwrap();
+    assert_eq!(contents, "hello WORLD\n");
+  }
+
+  #[test]
+  fn seek_rewind_full_read() {
+    let dir = tempfile::TempDir::new().unwrap();
+    let path = dir.path().join("seek.txt");
+    std::fs::write(&path, "abc\n").unwrap();
+    let g = TestGuard::new();
+
+    test_input(format!("exec 9<> {}", path.display())).unwrap();
+    // Read moves cursor to EOF
+    test_input("read line <&9").unwrap();
+    // Rewind
+    test_input("seek 9 0").unwrap();
+    // Clear output from seek
+    g.read_output();
+    // Read again from beginning
+    test_input("read line <&9").unwrap();
+
+    let val = crate::state::read_vars(|v| v.get_var("line"));
+    assert_eq!(val, "abc");
+  }
+
+  #[test]
+  fn seek_bad_fd() {
+    let _g = TestGuard::new();
+
+    let result = test_input("seek 99 0");
+    assert!(result.is_err());
+  }
+
+  #[test]
+  fn seek_missing_args() {
+    let _g = TestGuard::new();
+
+    let result = test_input("seek");
+    assert!(result.is_err());
+
+    let result = test_input("seek 9");
+    assert!(result.is_err());
+  }
+}

src/builtin/source.rs

@@ -44,128 +44,128 @@ pub fn source(node: Node) -> ShResult<()> {
 
 #[cfg(test)]
 pub mod tests {
-    use std::io::Write;
+  use std::io::Write;
 
-    use tempfile::{NamedTempFile, TempDir};
-    use crate::state::{self, read_logic, read_vars};
-    use crate::testutil::{TestGuard, test_input};
+  use crate::state::{self, read_logic, read_vars};
+  use crate::testutil::{TestGuard, test_input};
+  use tempfile::{NamedTempFile, TempDir};
 
-	#[test]
-	fn source_simple() {
-		let _g = TestGuard::new();
-		let mut file = NamedTempFile::new().unwrap();
-		let path = file.path().display().to_string();
-		file.write_all(b"some_var=some_val").unwrap();
+  #[test]
+  fn source_simple() {
+    let _g = TestGuard::new();
+    let mut file = NamedTempFile::new().unwrap();
+    let path = file.path().display().to_string();
+    file.write_all(b"some_var=some_val").unwrap();
 
-		test_input(format!("source {path}")).unwrap();
-		let var = read_vars(|v| v.get_var("some_var"));
-		assert_eq!(var, "some_val".to_string());
-	}
+    test_input(format!("source {path}")).unwrap();
+    let var = read_vars(|v| v.get_var("some_var"));
+    assert_eq!(var, "some_val".to_string());
+  }
 
-	#[test]
-	fn source_multiple_commands() {
-		let _g = TestGuard::new();
-		let mut file = NamedTempFile::new().unwrap();
-		let path = file.path().display().to_string();
-		file.write_all(b"x=1\ny=2\nz=3").unwrap();
+  #[test]
+  fn source_multiple_commands() {
+    let _g = TestGuard::new();
+    let mut file = NamedTempFile::new().unwrap();
+    let path = file.path().display().to_string();
+    file.write_all(b"x=1\ny=2\nz=3").unwrap();
 
-		test_input(format!("source {path}")).unwrap();
-		assert_eq!(read_vars(|v| v.get_var("x")), "1");
-		assert_eq!(read_vars(|v| v.get_var("y")), "2");
-		assert_eq!(read_vars(|v| v.get_var("z")), "3");
-	}
+    test_input(format!("source {path}")).unwrap();
+    assert_eq!(read_vars(|v| v.get_var("x")), "1");
+    assert_eq!(read_vars(|v| v.get_var("y")), "2");
+    assert_eq!(read_vars(|v| v.get_var("z")), "3");
+  }
 
-	#[test]
-	fn source_defines_function() {
-		let _g = TestGuard::new();
-		let mut file = NamedTempFile::new().unwrap();
-		let path = file.path().display().to_string();
-		file.write_all(b"greet() { echo hi; }").unwrap();
+  #[test]
+  fn source_defines_function() {
+    let _g = TestGuard::new();
+    let mut file = NamedTempFile::new().unwrap();
+    let path = file.path().display().to_string();
+    file.write_all(b"greet() { echo hi; }").unwrap();
 
-		test_input(format!("source {path}")).unwrap();
-		let func = read_logic(|l| l.get_func("greet"));
-		assert!(func.is_some());
-	}
+    test_input(format!("source {path}")).unwrap();
+    let func = read_logic(|l| l.get_func("greet"));
+    assert!(func.is_some());
+  }
 
-	#[test]
-	fn source_defines_alias() {
-		let _g = TestGuard::new();
-		let mut file = NamedTempFile::new().unwrap();
-		let path = file.path().display().to_string();
-		file.write_all(b"alias ll='ls -la'").unwrap();
+  #[test]
+  fn source_defines_alias() {
+    let _g = TestGuard::new();
+    let mut file = NamedTempFile::new().unwrap();
+    let path = file.path().display().to_string();
+    file.write_all(b"alias ll='ls -la'").unwrap();
 
-		test_input(format!("source {path}")).unwrap();
-		let alias = read_logic(|l| l.get_alias("ll"));
-		assert!(alias.is_some());
-	}
+    test_input(format!("source {path}")).unwrap();
+    let alias = read_logic(|l| l.get_alias("ll"));
+    assert!(alias.is_some());
+  }
 
-	#[test]
-	fn source_output_captured() {
-		let guard = TestGuard::new();
-		let mut file = NamedTempFile::new().unwrap();
-		let path = file.path().display().to_string();
-		file.write_all(b"echo sourced").unwrap();
+  #[test]
+  fn source_output_captured() {
+    let guard = TestGuard::new();
+    let mut file = NamedTempFile::new().unwrap();
+    let path = file.path().display().to_string();
+    file.write_all(b"echo sourced").unwrap();
 
-		test_input(format!("source {path}")).unwrap();
-		let out = guard.read_output();
-		assert!(out.contains("sourced"));
-	}
+    test_input(format!("source {path}")).unwrap();
+    let out = guard.read_output();
+    assert!(out.contains("sourced"));
+  }
 
-	#[test]
-	fn source_multiple_files() {
-		let _g = TestGuard::new();
-		let mut file1 = NamedTempFile::new().unwrap();
-		let mut file2 = NamedTempFile::new().unwrap();
-		let path1 = file1.path().display().to_string();
-		let path2 = file2.path().display().to_string();
-		file1.write_all(b"a=from_file1").unwrap();
-		file2.write_all(b"b=from_file2").unwrap();
+  #[test]
+  fn source_multiple_files() {
+    let _g = TestGuard::new();
+    let mut file1 = NamedTempFile::new().unwrap();
+    let mut file2 = NamedTempFile::new().unwrap();
+    let path1 = file1.path().display().to_string();
+    let path2 = file2.path().display().to_string();
+    file1.write_all(b"a=from_file1").unwrap();
+    file2.write_all(b"b=from_file2").unwrap();
 
-		test_input(format!("source {path1} {path2}")).unwrap();
-		assert_eq!(read_vars(|v| v.get_var("a")), "from_file1");
-		assert_eq!(read_vars(|v| v.get_var("b")), "from_file2");
-	}
+    test_input(format!("source {path1} {path2}")).unwrap();
+    assert_eq!(read_vars(|v| v.get_var("a")), "from_file1");
+    assert_eq!(read_vars(|v| v.get_var("b")), "from_file2");
+  }
 
-	// ===================== Dot syntax =====================
+  // ===================== Dot syntax =====================
 
-	#[test]
-	fn source_dot_syntax() {
-		let _g = TestGuard::new();
-		let mut file = NamedTempFile::new().unwrap();
-		let path = file.path().display().to_string();
-		file.write_all(b"dot_var=dot_val").unwrap();
+  #[test]
+  fn source_dot_syntax() {
+    let _g = TestGuard::new();
+    let mut file = NamedTempFile::new().unwrap();
+    let path = file.path().display().to_string();
+    file.write_all(b"dot_var=dot_val").unwrap();
 
-		test_input(format!(". {path}")).unwrap();
-		assert_eq!(read_vars(|v| v.get_var("dot_var")), "dot_val");
-	}
+    test_input(format!(". {path}")).unwrap();
+    assert_eq!(read_vars(|v| v.get_var("dot_var")), "dot_val");
+  }
 
-	// ===================== Error cases =====================
+  // ===================== Error cases =====================
 
-	#[test]
-	fn source_nonexistent_file() {
-		let _g = TestGuard::new();
-		let result = test_input("source /tmp/__no_such_file_xyz__");
-		assert!(result.is_err());
-	}
+  #[test]
+  fn source_nonexistent_file() {
+    let _g = TestGuard::new();
+    let result = test_input("source /tmp/__no_such_file_xyz__");
+    assert!(result.is_err());
+  }
 
-	#[test]
-	fn source_directory_fails() {
-		let _g = TestGuard::new();
-		let dir = TempDir::new().unwrap();
-		let result = test_input(format!("source {}", dir.path().display()));
-		assert!(result.is_err());
-	}
+  #[test]
+  fn source_directory_fails() {
+    let _g = TestGuard::new();
+    let dir = TempDir::new().unwrap();
+    let result = test_input(format!("source {}", dir.path().display()));
+    assert!(result.is_err());
+  }
 
-	// ===================== Status =====================
+  // ===================== Status =====================
 
-	#[test]
-	fn source_status_zero() {
-		let _g = TestGuard::new();
-		let mut file = NamedTempFile::new().unwrap();
-		let path = file.path().display().to_string();
-		file.write_all(b"true").unwrap();
+  #[test]
+  fn source_status_zero() {
+    let _g = TestGuard::new();
+    let mut file = NamedTempFile::new().unwrap();
+    let path = file.path().display().to_string();
+    file.write_all(b"true").unwrap();
 
-		test_input(format!("source {path}")).unwrap();
-		assert_eq!(state::get_status(), 0);
-	}
+    test_input(format!("source {path}")).unwrap();
+    assert_eq!(state::get_status(), 0);
+  }
 }

src/builtin/test.rs

@@ -94,7 +94,10 @@ impl FromStr for TestOp {
       "-ge" => Ok(Self::IntGe),
       "-le" => Ok(Self::IntLe),
       _ if TEST_UNARY_OPS.contains(&s) => Ok(Self::Unary(s.parse::<UnaryOp>()?)),
-      _ => Err(ShErr::simple(ShErrKind::SyntaxErr, format!("Invalid test operator '{}'", s))),
+      _ => Err(ShErr::simple(
+        ShErrKind::SyntaxErr,
+        format!("Invalid test operator '{}'", s),
+      )),
     }
   }
 }
@@ -121,7 +124,7 @@ pub fn double_bracket_test(node: Node) -> ShResult<bool> {
   };
   let mut last_result = false;
   let mut conjunct_op: Option<ConjunctOp>;
-	log::trace!("test cases: {:#?}", cases);
+  log::trace!("test cases: {:#?}", cases);
 
   for case in cases {
     let result = match case {
@@ -305,10 +308,10 @@ pub fn double_bracket_test(node: Node) -> ShResult<bool> {
 
 #[cfg(test)]
 mod tests {
-  use std::fs;
-  use tempfile::{TempDir, NamedTempFile};
   use crate::state;
   use crate::testutil::{TestGuard, test_input};
+  use std::fs;
+  use tempfile::{NamedTempFile, TempDir};
 
   // ===================== Unary: file tests =====================
 
@@ -590,9 +593,10 @@ mod tests {
   fn parse_unary_ops() {
     use super::UnaryOp;
     use std::str::FromStr;
-    for op in ["-e", "-d", "-f", "-h", "-L", "-r", "-w", "-x", "-s",
-               "-p", "-S", "-b", "-c", "-k", "-O", "-G", "-N", "-u",
-               "-g", "-t", "-n", "-z"] {
+    for op in [
+      "-e", "-d", "-f", "-h", "-L", "-r", "-w", "-x", "-s", "-p", "-S", "-b", "-c", "-k", "-O",
+      "-G", "-N", "-u", "-g", "-t", "-n", "-z",
+    ] {
       assert!(UnaryOp::from_str(op).is_ok(), "failed to parse {op}");
     }
   }

src/builtin/trap.rs

@@ -171,10 +171,10 @@ pub fn trap(node: Node) -> ShResult<()> {
 #[cfg(test)]
 mod tests {
   use super::TrapTarget;
-  use std::str::FromStr;
-  use nix::sys::signal::Signal;
   use crate::state::{self, read_logic};
   use crate::testutil::{TestGuard, test_input};
+  use nix::sys::signal::Signal;
+  use std::str::FromStr;
 
   // ===================== Pure: TrapTarget parsing =====================
 
@@ -231,7 +231,9 @@ mod tests {
 
   #[test]
   fn display_signal_roundtrip() {
-    for name in &["INT", "QUIT", "TERM", "USR1", "USR2", "ALRM", "CHLD", "WINCH"] {
+    for name in &[
+      "INT", "QUIT", "TERM", "USR1", "USR2", "ALRM", "CHLD", "WINCH",
+    ] {
       let target = TrapTarget::from_str(name).unwrap();
       assert_eq!(target.to_string(), *name);
     }

src/builtin/varcmds.rs

@@ -245,8 +245,16 @@ mod tests {
     test_input("readonly a=1 b=2").unwrap();
     assert_eq!(read_vars(|v| v.get_var("a")), "1");
     assert_eq!(read_vars(|v| v.get_var("b")), "2");
-    assert!(read_vars(|v| v.get_var_flags("a")).unwrap().contains(VarFlags::READONLY));
-    assert!(read_vars(|v| v.get_var_flags("b")).unwrap().contains(VarFlags::READONLY));
+    assert!(
+      read_vars(|v| v.get_var_flags("a"))
+        .unwrap()
+        .contains(VarFlags::READONLY)
+    );
+    assert!(
+      read_vars(|v| v.get_var_flags("b"))
+        .unwrap()
+        .contains(VarFlags::READONLY)
+    );
   }
 
   #[test]
@@ -385,7 +393,11 @@ mod tests {
     let _g = TestGuard::new();
     test_input("local mylocal").unwrap();
     assert_eq!(read_vars(|v| v.get_var("mylocal")), "");
-    assert!(read_vars(|v| v.get_var_flags("mylocal")).unwrap().contains(VarFlags::LOCAL));
+    assert!(
+      read_vars(|v| v.get_var_flags("mylocal"))
+        .unwrap()
+        .contains(VarFlags::LOCAL)
+    );
   }
 
   #[test]

src/expand.rs

@@ -4,6 +4,7 @@ use std::str::{Chars, FromStr};
 
 use ariadne::Fmt;
 use glob::Pattern;
+use nix::unistd::{Uid, User};
 use regex::Regex;
 
 use crate::libsh::error::{ShErr, ShErrKind, ShResult, ShResultExt, next_color};
@@ -40,18 +41,26 @@ impl Tk {
 }
 
 pub struct Expander {
+  flags: TkFlags,
   raw: String,
 }
 
 impl Expander {
   pub fn new(raw: Tk) -> ShResult<Self> {
-    let raw = raw.span.as_str();
-    Self::from_raw(raw)
+    let tk_raw = raw.span.as_str();
+    Self::from_raw(tk_raw, raw.flags)
   }
-  pub fn from_raw(raw: &str) -> ShResult<Self> {
+  pub fn from_raw(raw: &str, flags: TkFlags) -> ShResult<Self> {
     let raw = expand_braces_full(raw)?.join(" ");
-    let unescaped = unescape_str(&raw);
-    Ok(Self { raw: unescaped })
+    let unescaped = if flags.contains(TkFlags::IS_HEREDOC) {
+      unescape_heredoc(&raw)
+    } else {
+      unescape_str(&raw)
+    };
+    Ok(Self {
+      raw: unescaped,
+      flags,
+    })
   }
   pub fn expand(&mut self) -> ShResult<Vec<String>> {
     let mut chars = self.raw.chars().peekable();
@@ -75,7 +84,11 @@ impl Expander {
       self.raw.insert_str(0, "./");
     }
 
-    Ok(self.split_words())
+    if self.flags.contains(TkFlags::IS_HEREDOC) {
+      Ok(vec![self.raw.clone()])
+    } else {
+      Ok(self.split_words())
+    }
   }
   pub fn split_words(&mut self) -> Vec<String> {
     let mut words = vec![];
@@ -86,6 +99,11 @@ impl Expander {
 
     'outer: while let Some(ch) = chars.next() {
       match ch {
+        markers::ESCAPE => {
+          if let Some(next_ch) = chars.next() {
+            cur_word.push(next_ch);
+          }
+        }
         markers::DUB_QUOTE | markers::SNG_QUOTE | markers::SUBSH => {
           while let Some(q_ch) = chars.next() {
             match q_ch {
@@ -456,7 +474,33 @@ pub fn expand_raw(chars: &mut Peekable<Chars<'_>>) -> ShResult<String> {
   while let Some(ch) = chars.next() {
     match ch {
       markers::TILDE_SUB => {
-        let home = env::var("HOME").unwrap_or_default();
+				let mut username = String::new();
+				while chars.peek().is_some_and(|ch| *ch != '/') {
+					let ch = chars.next().unwrap();
+					username.push(ch);
+				}
+
+				let home = if username.is_empty() {
+					// standard '~' expansion
+					env::var("HOME").unwrap_or_default()
+				}
+				else if let Ok(result) = User::from_name(&username)
+				&& let Some(user) = result {
+					// username expansion like '~user'
+					user.dir.to_string_lossy().to_string()
+				}
+				else if let Ok(id) = username.parse::<u32>()
+				&& let Ok(result) = User::from_uid(Uid::from_raw(id))
+				&& let Some(user) = result {
+					// uid expansion like '~1000'
+					// shed only feature btw B)
+					user.dir.to_string_lossy().to_string()
+				}
+				else {
+					// no match, use literal
+					format!("~{username}")
+				};
+
         result.push_str(&home);
       }
       markers::PROC_SUB_OUT => {
@@ -634,8 +678,12 @@ pub fn expand_glob(raw: &str) -> ShResult<String> {
   {
     let entry =
       entry.map_err(|_| ShErr::simple(ShErrKind::SyntaxErr, "Invalid filename found in glob"))?;
+    let entry_raw = entry
+      .to_str()
+      .ok_or_else(|| ShErr::simple(ShErrKind::SyntaxErr, "Non-UTF8 filename found in glob"))?;
+    let escaped = escape_str(entry_raw, true);
 
-    words.push(entry.to_str().unwrap().to_string())
+    words.push(escaped)
   }
   Ok(words.join(" "))
 }
@@ -973,6 +1021,11 @@ pub fn expand_cmd_sub(raw: &str) -> ShResult<String> {
   }
 }
 
+/// Strip ESCAPE markers from a string, leaving the characters they protect intact.
+fn strip_escape_markers(s: &str) -> String {
+  s.replace(markers::ESCAPE, "")
+}
+
 /// Processes strings into intermediate representations that are more readable
 /// by the program
 ///
@@ -989,6 +1042,7 @@ pub fn unescape_str(raw: &str) -> String {
       '~' if first_char => result.push(markers::TILDE_SUB),
       '\\' => {
         if let Some(next_ch) = chars.next() {
+          result.push(markers::ESCAPE);
           result.push(next_ch)
         }
       }
@@ -1139,6 +1193,25 @@ pub fn unescape_str(raw: &str) -> String {
                 }
               }
             }
+            '`' => {
+              result.push(markers::VAR_SUB);
+              result.push(markers::SUBSH);
+              while let Some(bt_ch) = chars.next() {
+                match bt_ch {
+                  '\\' => {
+                    result.push(bt_ch);
+                    if let Some(next_ch) = chars.next() {
+                      result.push(next_ch);
+                    }
+                  }
+                  '`' => {
+                    result.push(markers::SUBSH);
+                    break;
+                  }
+                  _ => result.push(bt_ch),
+                }
+              }
+            }
             '"' => {
               result.push(markers::DUB_QUOTE);
               break;
@@ -1303,6 +1376,25 @@ pub fn unescape_str(raw: &str) -> String {
           result.push('$');
         }
       }
+      '`' => {
+        result.push(markers::VAR_SUB);
+        result.push(markers::SUBSH);
+        while let Some(bt_ch) = chars.next() {
+          match bt_ch {
+            '\\' => {
+              result.push(bt_ch);
+              if let Some(next_ch) = chars.next() {
+                result.push(next_ch);
+              }
+            }
+            '`' => {
+              result.push(markers::SUBSH);
+              break;
+            }
+            _ => result.push(bt_ch),
+          }
+        }
+      }
       _ => result.push(ch),
     }
     first_char = false;
@@ -1311,6 +1403,134 @@ pub fn unescape_str(raw: &str) -> String {
   result
 }
 
+/// Like unescape_str but for heredoc bodies. Only processes:
+/// - $var / ${var} / $(cmd) substitution markers
+/// - Backslash escapes (only before $, `, \, and newline)
+///
+/// Everything else (quotes, tildes, globs, process subs, etc.) is literal.
+pub fn unescape_heredoc(raw: &str) -> String {
+  let mut chars = raw.chars().peekable();
+  let mut result = String::new();
+
+  while let Some(ch) = chars.next() {
+    match ch {
+      '\\' => {
+        match chars.peek() {
+          Some('$') | Some('`') | Some('\\') | Some('\n') => {
+            let next_ch = chars.next().unwrap();
+            if next_ch == '\n' {
+              // line continuation — discard both backslash and newline
+              continue;
+            }
+            result.push(markers::ESCAPE);
+            result.push(next_ch);
+          }
+          _ => {
+            // backslash is literal
+            result.push('\\');
+          }
+        }
+      }
+      '$' if chars.peek() == Some(&'(') => {
+        result.push(markers::VAR_SUB);
+        chars.next(); // consume '('
+        result.push(markers::SUBSH);
+        let mut paren_count = 1;
+        while let Some(subsh_ch) = chars.next() {
+          match subsh_ch {
+            '\\' => {
+              result.push(subsh_ch);
+              if let Some(next_ch) = chars.next() {
+                result.push(next_ch);
+              }
+            }
+            '(' => {
+              paren_count += 1;
+              result.push(subsh_ch);
+            }
+            ')' => {
+              paren_count -= 1;
+              if paren_count == 0 {
+                result.push(markers::SUBSH);
+                break;
+              } else {
+                result.push(subsh_ch);
+              }
+            }
+            _ => result.push(subsh_ch),
+          }
+        }
+      }
+      '$' => {
+        result.push(markers::VAR_SUB);
+        if chars.peek() == Some(&'$') {
+          chars.next();
+          result.push('$');
+        }
+      }
+      '`' => {
+        result.push(markers::VAR_SUB);
+        result.push(markers::SUBSH);
+        while let Some(bt_ch) = chars.next() {
+          match bt_ch {
+            '\\' => {
+              result.push(bt_ch);
+              if let Some(next_ch) = chars.next() {
+                result.push(next_ch);
+              }
+            }
+            '`' => {
+              result.push(markers::SUBSH);
+              break;
+            }
+            _ => result.push(bt_ch),
+          }
+        }
+      }
+      _ => result.push(ch),
+    }
+  }
+
+  result
+}
+
+/// Opposite of unescape_str - escapes a string to be executed as literal text
+/// Used for completion results, and glob filename matches.
+pub fn escape_str(raw: &str, use_marker: bool) -> String {
+  let mut result = String::new();
+  let mut chars = raw.chars();
+
+  while let Some(ch) = chars.next() {
+    match ch {
+      '\'' | '"' | '\\' | '|' | '&' | ';' | '(' | ')' | '<' | '>' | '$' | '*' | '!' | '`' | '{'
+      | '?' | '[' | '#' | ' ' | '\t' | '\n' => {
+        if use_marker {
+          result.push(markers::ESCAPE);
+        } else {
+          result.push('\\');
+        }
+        result.push(ch);
+        continue;
+      }
+      '~' if result.is_empty() => {
+        if use_marker {
+          result.push(markers::ESCAPE);
+        } else {
+          result.push('\\');
+        }
+        result.push(ch);
+        continue;
+      }
+      _ => {
+        result.push(ch);
+        continue;
+      }
+    }
+  }
+
+  result
+}
+
 pub fn unescape_math(raw: &str) -> String {
   let mut chars = raw.chars().peekable();
   let mut result = String::new();
@@ -1364,6 +1584,10 @@ pub fn unescape_math(raw: &str) -> String {
 #[derive(Debug)]
 pub enum ParamExp {
   Len,                               // #var_name
+	ToUpperFirst,											 // ^var_name
+	ToUpperAll,												 // ^^var_name
+	ToLowerFirst,											 // ,var_name
+	ToLowerAll,												 // ,,var_name
   DefaultUnsetOrNull(String),        // :-
   DefaultUnset(String),              // -
   SetDefaultUnsetOrNull(String),     // :=
@@ -1399,6 +1623,11 @@ impl FromStr for ParamExp {
       ))
     };
 
+		if s == "^^" { return Ok(ToUpperAll) }
+		if s == "^" { return Ok(ToUpperFirst) }
+		if s == ",," { return Ok(ToLowerAll) }
+		if s == "," { return Ok(ToLowerFirst) }
+
     // Handle indirect var expansion: ${!var}
     if let Some(var) = s.strip_prefix('!') {
       if var.ends_with('*') || var.ends_with('@') {
@@ -1504,7 +1733,7 @@ pub fn perform_param_expansion(raw: &str) -> ShResult<String> {
 
   while let Some(ch) = chars.next() {
     match ch {
-      '!' | '#' | '%' | ':' | '-' | '+' | '=' | '/' | '?' => {
+      '!' | '#' | '%' | ':' | '-' | '+' | '^' | ',' | '=' | '/' | '?' => {
         rest.push(ch);
         rest.push_str(&chars.collect::<String>());
         break;
@@ -1516,6 +1745,32 @@ pub fn perform_param_expansion(raw: &str) -> ShResult<String> {
   if let Ok(expansion) = rest.parse::<ParamExp>() {
     match expansion {
       ParamExp::Len => unreachable!(),
+			ParamExp::ToUpperAll => {
+				let value = vars.get_var(&var_name);
+				Ok(value.to_uppercase())
+			}
+			ParamExp::ToUpperFirst => {
+				let value = vars.get_var(&var_name);
+				let mut chars = value.chars();
+				let first = chars.next()
+					.map(|c| c.to_uppercase()
+						.to_string())
+					.unwrap_or_default();
+				Ok(first + chars.as_str())
+
+			}
+			ParamExp::ToLowerAll => {
+				let value = vars.get_var(&var_name);
+				Ok(value.to_lowercase())
+			}
+			ParamExp::ToLowerFirst => {
+				let value = vars.get_var(&var_name);
+				let mut chars = value.chars();
+				let first = chars.next()
+					.map(|c| c.to_lowercase().to_string())
+					.unwrap_or_default();
+				Ok(first + chars.as_str())
+			}
       ParamExp::DefaultUnsetOrNull(default) => {
         match vars.try_get_var(&var_name).filter(|v| !v.is_empty()) {
           Some(val) => Ok(val),
@@ -1588,7 +1843,8 @@ pub fn perform_param_expansion(raw: &str) -> ShResult<String> {
       ParamExp::RemShortestPrefix(prefix) => {
         let value = vars.get_var(&var_name);
         let unescaped = unescape_str(&prefix);
-        let expanded = expand_raw(&mut unescaped.chars().peekable()).unwrap_or(prefix);
+        let expanded =
+          strip_escape_markers(&expand_raw(&mut unescaped.chars().peekable()).unwrap_or(prefix));
         let pattern = Pattern::new(&expanded).unwrap();
         for i in 0..=value.len() {
           let sliced = &value[..i];
@@ -1601,7 +1857,8 @@ pub fn perform_param_expansion(raw: &str) -> ShResult<String> {
       ParamExp::RemLongestPrefix(prefix) => {
         let value = vars.get_var(&var_name);
         let unescaped = unescape_str(&prefix);
-        let expanded = expand_raw(&mut unescaped.chars().peekable()).unwrap_or(prefix);
+        let expanded =
+          strip_escape_markers(&expand_raw(&mut unescaped.chars().peekable()).unwrap_or(prefix));
         let pattern = Pattern::new(&expanded).unwrap();
         for i in (0..=value.len()).rev() {
           let sliced = &value[..i];
@@ -1614,7 +1871,8 @@ pub fn perform_param_expansion(raw: &str) -> ShResult<String> {
       ParamExp::RemShortestSuffix(suffix) => {
         let value = vars.get_var(&var_name);
         let unescaped = unescape_str(&suffix);
-        let expanded = expand_raw(&mut unescaped.chars().peekable()).unwrap_or(suffix);
+        let expanded =
+          strip_escape_markers(&expand_raw(&mut unescaped.chars().peekable()).unwrap_or(suffix));
         let pattern = Pattern::new(&expanded).unwrap();
         for i in (0..=value.len()).rev() {
           let sliced = &value[i..];
@@ -1627,8 +1885,9 @@ pub fn perform_param_expansion(raw: &str) -> ShResult<String> {
       ParamExp::RemLongestSuffix(suffix) => {
         let value = vars.get_var(&var_name);
         let unescaped = unescape_str(&suffix);
-        let expanded_suffix =
-          expand_raw(&mut unescaped.chars().peekable()).unwrap_or(suffix.clone());
+        let expanded_suffix = strip_escape_markers(
+          &expand_raw(&mut unescaped.chars().peekable()).unwrap_or(suffix.clone()),
+        );
         let pattern = Pattern::new(&expanded_suffix).unwrap();
         for i in 0..=value.len() {
           let sliced = &value[i..];
@@ -1642,8 +1901,10 @@ pub fn perform_param_expansion(raw: &str) -> ShResult<String> {
         let value = vars.get_var(&var_name);
         let search = unescape_str(&search);
         let replace = unescape_str(&replace);
-        let expanded_search = expand_raw(&mut search.chars().peekable()).unwrap_or(search);
-        let expanded_replace = expand_raw(&mut replace.chars().peekable()).unwrap_or(replace);
+        let expanded_search =
+          strip_escape_markers(&expand_raw(&mut search.chars().peekable()).unwrap_or(search));
+        let expanded_replace =
+          strip_escape_markers(&expand_raw(&mut replace.chars().peekable()).unwrap_or(replace));
         let regex = glob_to_regex(&expanded_search, false); // unanchored pattern
 
         if let Some(mat) = regex.find(&value) {
@@ -1659,8 +1920,10 @@ pub fn perform_param_expansion(raw: &str) -> ShResult<String> {
         let value = vars.get_var(&var_name);
         let search = unescape_str(&search);
         let replace = unescape_str(&replace);
-        let expanded_search = expand_raw(&mut search.chars().peekable()).unwrap_or(search);
-        let expanded_replace = expand_raw(&mut replace.chars().peekable()).unwrap_or(replace);
+        let expanded_search =
+          strip_escape_markers(&expand_raw(&mut search.chars().peekable()).unwrap_or(search));
+        let expanded_replace =
+          strip_escape_markers(&expand_raw(&mut replace.chars().peekable()).unwrap_or(replace));
         let regex = glob_to_regex(&expanded_search, false);
         let mut result = String::new();
         let mut last_match_end = 0;
@@ -1679,8 +1942,10 @@ pub fn perform_param_expansion(raw: &str) -> ShResult<String> {
         let value = vars.get_var(&var_name);
         let search = unescape_str(&search);
         let replace = unescape_str(&replace);
-        let expanded_search = expand_raw(&mut search.chars().peekable()).unwrap_or(search);
-        let expanded_replace = expand_raw(&mut replace.chars().peekable()).unwrap_or(replace);
+        let expanded_search =
+          strip_escape_markers(&expand_raw(&mut search.chars().peekable()).unwrap_or(search));
+        let expanded_replace =
+          strip_escape_markers(&expand_raw(&mut replace.chars().peekable()).unwrap_or(replace));
         let pattern = Pattern::new(&expanded_search).unwrap();
         for i in (0..=value.len()).rev() {
           let sliced = &value[..i];
@@ -1694,8 +1959,10 @@ pub fn perform_param_expansion(raw: &str) -> ShResult<String> {
         let value = vars.get_var(&var_name);
         let search = unescape_str(&search);
         let replace = unescape_str(&replace);
-        let expanded_search = expand_raw(&mut search.chars().peekable()).unwrap_or(search);
-        let expanded_replace = expand_raw(&mut replace.chars().peekable()).unwrap_or(replace);
+        let expanded_search =
+          strip_escape_markers(&expand_raw(&mut search.chars().peekable()).unwrap_or(search));
+        let expanded_replace =
+          strip_escape_markers(&expand_raw(&mut replace.chars().peekable()).unwrap_or(replace));
         let pattern = Pattern::new(&expanded_search).unwrap();
         for i in (0..=value.len()).rev() {
           let sliced = &value[i..];
@@ -1740,6 +2007,11 @@ pub fn expand_case_pattern(raw: &str) -> ShResult<String> {
       markers::DUB_QUOTE | markers::SNG_QUOTE => {
         in_quote = !in_quote;
       }
+      markers::ESCAPE => {
+        if let Some(next_ch) = chars.next() {
+          result.push(next_ch);
+        }
+      }
       '*' | '?' | '[' | ']' if in_quote => {
         result.push('\\');
         result.push(ch);
@@ -2381,11 +2653,11 @@ pub fn parse_key_alias(alias: &str) -> Option<KeyEvent> {
 #[cfg(test)]
 mod tests {
   use super::*;
-  use std::time::Duration;
-  use crate::readline::keys::{KeyCode, KeyEvent, ModKeys};
-  use crate::state::{write_vars, read_vars, ArrIndex, VarKind, VarFlags};
   use crate::parse::lex::Span;
+  use crate::readline::keys::{KeyCode, KeyEvent, ModKeys};
+  use crate::state::{ArrIndex, VarFlags, VarKind, read_vars, write_vars};
   use crate::testutil::{TestGuard, test_input};
+  use std::time::Duration;
 
   // ===================== has_braces =====================
 
@@ -2525,10 +2797,7 @@ mod tests {
 
   #[test]
   fn braces_simple_list() {
-    assert_eq!(
-      expand_braces_full("{a,b,c}").unwrap(),
-      vec!["a", "b", "c"]
-    );
+    assert_eq!(expand_braces_full("{a,b,c}").unwrap(), vec!["a", "b", "c"]);
   }
 
   #[test]
@@ -2614,11 +2883,23 @@ mod tests {
     assert_eq!(result, vec!["prepost", "preapost"]);
   }
 
-	#[test]
-	fn braces_cursed() {
-		let result = expand_braces_full("foo{a,{1,2,3,{1..4},5},c}{5..1}bar").unwrap();
-		assert_eq!(result, vec![ "fooa5bar", "fooa4bar", "fooa3bar", "fooa2bar", "fooa1bar", "foo15bar", "foo14bar", "foo13bar", "foo12bar", "foo11bar", "foo25bar", "foo24bar", "foo23bar", "foo22bar", "foo21bar", "foo35bar", "foo34bar", "foo33bar", "foo32bar", "foo31bar", "foo15bar", "foo14bar", "foo13bar", "foo12bar", "foo11bar", "foo25bar", "foo24bar", "foo23bar", "foo22bar", "foo21bar", "foo35bar", "foo34bar", "foo33bar", "foo32bar", "foo31bar", "foo45bar", "foo44bar", "foo43bar", "foo42bar", "foo41bar", "foo55bar", "foo54bar", "foo53bar", "foo52bar", "foo51bar", "fooc5bar", "fooc4bar", "fooc3bar", "fooc2bar", "fooc1bar", ])
-	}
+  #[test]
+  fn braces_cursed() {
+    let result = expand_braces_full("foo{a,{1,2,3,{1..4},5},c}{5..1}bar").unwrap();
+    assert_eq!(
+      result,
+      vec![
+        "fooa5bar", "fooa4bar", "fooa3bar", "fooa2bar", "fooa1bar", "foo15bar", "foo14bar",
+        "foo13bar", "foo12bar", "foo11bar", "foo25bar", "foo24bar", "foo23bar", "foo22bar",
+        "foo21bar", "foo35bar", "foo34bar", "foo33bar", "foo32bar", "foo31bar", "foo15bar",
+        "foo14bar", "foo13bar", "foo12bar", "foo11bar", "foo25bar", "foo24bar", "foo23bar",
+        "foo22bar", "foo21bar", "foo35bar", "foo34bar", "foo33bar", "foo32bar", "foo31bar",
+        "foo45bar", "foo44bar", "foo43bar", "foo42bar", "foo41bar", "foo55bar", "foo54bar",
+        "foo53bar", "foo52bar", "foo51bar", "fooc5bar", "fooc4bar", "fooc3bar", "fooc2bar",
+        "fooc1bar",
+      ]
+    )
+  }
 
   // ===================== Arithmetic =====================
 
@@ -2858,7 +3139,8 @@ mod tests {
   #[test]
   fn unescape_backslash() {
     let result = unescape_str("hello\\nworld");
-    assert_eq!(result, "hellonworld");
+    let expected = format!("hello{}nworld", markers::ESCAPE);
+    assert_eq!(result, expected);
   }
 
   #[test]
@@ -3089,10 +3371,22 @@ mod tests {
 
   #[test]
   fn key_alias_arrows() {
-    assert_eq!(parse_key_alias("UP").unwrap(), KeyEvent(KeyCode::Up, ModKeys::NONE));
-    assert_eq!(parse_key_alias("DOWN").unwrap(), KeyEvent(KeyCode::Down, ModKeys::NONE));
-    assert_eq!(parse_key_alias("LEFT").unwrap(), KeyEvent(KeyCode::Left, ModKeys::NONE));
-    assert_eq!(parse_key_alias("RIGHT").unwrap(), KeyEvent(KeyCode::Right, ModKeys::NONE));
+    assert_eq!(
+      parse_key_alias("UP").unwrap(),
+      KeyEvent(KeyCode::Up, ModKeys::NONE)
+    );
+    assert_eq!(
+      parse_key_alias("DOWN").unwrap(),
+      KeyEvent(KeyCode::Down, ModKeys::NONE)
+    );
+    assert_eq!(
+      parse_key_alias("LEFT").unwrap(),
+      KeyEvent(KeyCode::Left, ModKeys::NONE)
+    );
+    assert_eq!(
+      parse_key_alias("RIGHT").unwrap(),
+      KeyEvent(KeyCode::Right, ModKeys::NONE)
+    );
   }
 
   #[test]
@@ -3104,7 +3398,13 @@ mod tests {
   #[test]
   fn key_alias_ctrl_shift_alt_modifier() {
     let key = parse_key_alias("C-S-A-b").unwrap();
-    assert_eq!(key, KeyEvent(KeyCode::Char('B'), ModKeys::CTRL | ModKeys::SHIFT | ModKeys::ALT));
+    assert_eq!(
+      key,
+      KeyEvent(
+        KeyCode::Char('B'),
+        ModKeys::CTRL | ModKeys::SHIFT | ModKeys::ALT
+      )
+    );
   }
 
   #[test]
@@ -3296,7 +3596,14 @@ mod tests {
   #[test]
   fn param_remove_shortest_prefix() {
     let _guard = TestGuard::new();
-    write_vars(|v| v.set_var("PATH", VarKind::Str("/usr/local/bin".into()), VarFlags::NONE)).unwrap();
+    write_vars(|v| {
+      v.set_var(
+        "PATH",
+        VarKind::Str("/usr/local/bin".into()),
+        VarFlags::NONE,
+      )
+    })
+    .unwrap();
 
     let result = perform_param_expansion("PATH#*/").unwrap();
     assert_eq!(result, "usr/local/bin");
@@ -3305,7 +3612,14 @@ mod tests {
   #[test]
   fn param_remove_longest_prefix() {
     let _guard = TestGuard::new();
-    write_vars(|v| v.set_var("PATH", VarKind::Str("/usr/local/bin".into()), VarFlags::NONE)).unwrap();
+    write_vars(|v| {
+      v.set_var(
+        "PATH",
+        VarKind::Str("/usr/local/bin".into()),
+        VarFlags::NONE,
+      )
+    })
+    .unwrap();
 
     let result = perform_param_expansion("PATH##*/").unwrap();
     assert_eq!(result, "bin");
@@ -3419,7 +3733,10 @@ mod tests {
   fn word_split_default_ifs() {
     let _guard = TestGuard::new();
 
-    let mut exp = Expander { raw: "hello world\tfoo".to_string() };
+    let mut exp = Expander {
+      raw: "hello world\tfoo".to_string(),
+      flags: TkFlags::empty(),
+    };
     let words = exp.split_words();
     assert_eq!(words, vec!["hello", "world", "foo"]);
   }
@@ -3427,9 +3744,14 @@ mod tests {
   #[test]
   fn word_split_custom_ifs() {
     let _guard = TestGuard::new();
-    unsafe { std::env::set_var("IFS", ":"); }
+    unsafe {
+      std::env::set_var("IFS", ":");
+    }
 
-    let mut exp = Expander { raw: "a:b:c".to_string() };
+    let mut exp = Expander {
+      raw: "a:b:c".to_string(),
+      flags: TkFlags::empty(),
+    };
     let words = exp.split_words();
     assert_eq!(words, vec!["a", "b", "c"]);
   }
@@ -3437,9 +3759,14 @@ mod tests {
   #[test]
   fn word_split_empty_ifs() {
     let _guard = TestGuard::new();
-    unsafe { std::env::set_var("IFS", ""); }
+    unsafe {
+      std::env::set_var("IFS", "");
+    }
 
-    let mut exp = Expander { raw: "hello world".to_string() };
+    let mut exp = Expander {
+      raw: "hello world".to_string(),
+      flags: TkFlags::empty(),
+    };
     let words = exp.split_words();
     assert_eq!(words, vec!["hello world"]);
   }
@@ -3449,11 +3776,82 @@ mod tests {
     let _guard = TestGuard::new();
 
     let raw = format!("{}hello world{}", markers::DUB_QUOTE, markers::DUB_QUOTE);
-    let mut exp = Expander { raw };
+    let mut exp = Expander {
+      raw,
+      flags: TkFlags::empty(),
+    };
     let words = exp.split_words();
     assert_eq!(words, vec!["hello world"]);
   }
 
+  // ===================== Escaped Word Splitting =====================
+
+  #[test]
+  fn word_split_escaped_space() {
+    let _guard = TestGuard::new();
+
+    let raw = format!("hello{}world", unescape_str("\\ "));
+    let mut exp = Expander {
+      raw,
+      flags: TkFlags::empty(),
+    };
+    let words = exp.split_words();
+    assert_eq!(words, vec!["hello world"]);
+  }
+
+  #[test]
+  fn word_split_escaped_tab() {
+    let _guard = TestGuard::new();
+
+    let raw = format!("hello{}world", unescape_str("\\\t"));
+    let mut exp = Expander {
+      raw,
+      flags: TkFlags::empty(),
+    };
+    let words = exp.split_words();
+    assert_eq!(words, vec!["hello\tworld"]);
+  }
+
+  #[test]
+  fn word_split_escaped_custom_ifs() {
+    let _guard = TestGuard::new();
+    unsafe {
+      std::env::set_var("IFS", ":");
+    }
+
+    let raw = format!("a{}b:c", unescape_str("\\:"));
+    let mut exp = Expander {
+      raw,
+      flags: TkFlags::empty(),
+    };
+    let words = exp.split_words();
+    assert_eq!(words, vec!["a:b", "c"]);
+  }
+
+  // ===================== Parameter Expansion with Escapes (TestGuard) =====================
+
+  #[test]
+  fn param_exp_prefix_removal_escaped() {
+    let guard = TestGuard::new();
+    write_vars(|v| v.set_var("branch", VarKind::Str("## main".into()), VarFlags::NONE)).unwrap();
+
+    test_input("echo \"${branch#\\#\\# }\"").unwrap();
+
+    let out = guard.read_output();
+    assert_eq!(out, "main\n");
+  }
+
+  #[test]
+  fn param_exp_suffix_removal_escaped() {
+    let guard = TestGuard::new();
+    write_vars(|v| v.set_var("val", VarKind::Str("hello world!!".into()), VarFlags::NONE)).unwrap();
+
+    test_input("echo \"${val%\\!\\!}\"").unwrap();
+
+    let out = guard.read_output();
+    assert_eq!(out, "hello world\n");
+  }
+
   // ===================== Arithmetic with Variables (TestGuard) =====================
 
   #[test]
@@ -3478,8 +3876,13 @@ mod tests {
   fn array_index_first() {
     let _guard = TestGuard::new();
     write_vars(|v| {
-      v.set_var("arr", VarKind::arr_from_vec(vec!["a".into(), "b".into(), "c".into()]), VarFlags::NONE)
-    }).unwrap();
+      v.set_var(
+        "arr",
+        VarKind::arr_from_vec(vec!["a".into(), "b".into(), "c".into()]),
+        VarFlags::NONE,
+      )
+    })
+    .unwrap();
 
     let val = read_vars(|v| v.index_var("arr", ArrIndex::Literal(0))).unwrap();
     assert_eq!(val, "a");
@@ -3489,8 +3892,13 @@ mod tests {
   fn array_index_second() {
     let _guard = TestGuard::new();
     write_vars(|v| {
-      v.set_var("arr", VarKind::arr_from_vec(vec!["x".into(), "y".into(), "z".into()]), VarFlags::NONE)
-    }).unwrap();
+      v.set_var(
+        "arr",
+        VarKind::arr_from_vec(vec!["x".into(), "y".into(), "z".into()]),
+        VarFlags::NONE,
+      )
+    })
+    .unwrap();
 
     let val = read_vars(|v| v.index_var("arr", ArrIndex::Literal(1))).unwrap();
     assert_eq!(val, "y");
@@ -3500,8 +3908,13 @@ mod tests {
   fn array_all_elems() {
     let _guard = TestGuard::new();
     write_vars(|v| {
-      v.set_var("arr", VarKind::arr_from_vec(vec!["a".into(), "b".into(), "c".into()]), VarFlags::NONE)
-    }).unwrap();
+      v.set_var(
+        "arr",
+        VarKind::arr_from_vec(vec!["a".into(), "b".into(), "c".into()]),
+        VarFlags::NONE,
+      )
+    })
+    .unwrap();
 
     let elems = read_vars(|v| v.get_arr_elems("arr")).unwrap();
     assert_eq!(elems, vec!["a", "b", "c"]);
@@ -3511,8 +3924,13 @@ mod tests {
   fn array_elem_count() {
     let _guard = TestGuard::new();
     write_vars(|v| {
-      v.set_var("arr", VarKind::arr_from_vec(vec!["a".into(), "b".into(), "c".into()]), VarFlags::NONE)
-    }).unwrap();
+      v.set_var(
+        "arr",
+        VarKind::arr_from_vec(vec!["a".into(), "b".into(), "c".into()]),
+        VarFlags::NONE,
+      )
+    })
+    .unwrap();
 
     let elems = read_vars(|v| v.get_arr_elems("arr")).unwrap();
     assert_eq!(elems.len(), 3);
@@ -3525,7 +3943,9 @@ mod tests {
     let _guard = TestGuard::new();
     let dummy_span = Span::default();
     crate::state::SHED.with(|s| {
-      s.logic.borrow_mut().insert_alias("ll", "ls -la", dummy_span.clone());
+      s.logic
+        .borrow_mut()
+        .insert_alias("ll", "ls -la", dummy_span.clone());
     });
 
     let log_tab = crate::state::SHED.with(|s| s.logic.borrow().clone());
@@ -3538,7 +3958,9 @@ mod tests {
     let _guard = TestGuard::new();
     let dummy_span = Span::default();
     crate::state::SHED.with(|s| {
-      s.logic.borrow_mut().insert_alias("foo", "foo --verbose", dummy_span.clone());
+      s.logic
+        .borrow_mut()
+        .insert_alias("foo", "foo --verbose", dummy_span.clone());
     });
 
     let log_tab = crate::state::SHED.with(|s| s.logic.borrow().clone());
@@ -3550,26 +3972,47 @@ mod tests {
 
   // ===================== Direct Input Tests (TestGuard) =====================
 
-	#[test]
-	fn index_simple() {
-		let guard = TestGuard::new();
-		write_vars(|v| v.set_var("arr", VarKind::Arr(VecDeque::from(["foo".into(), "bar".into(), "biz".into()])), VarFlags::NONE)).unwrap();
+  #[test]
+  fn index_simple() {
+    let guard = TestGuard::new();
+    write_vars(|v| {
+      v.set_var(
+        "arr",
+        VarKind::Arr(VecDeque::from(["foo".into(), "bar".into(), "biz".into()])),
+        VarFlags::NONE,
+      )
+    })
+    .unwrap();
 
-		test_input("echo $arr").unwrap();
+    test_input("echo $arr").unwrap();
 
-		let out = guard.read_output();
-		assert_eq!(out, "foo bar biz\n");
-	}
+    let out = guard.read_output();
+    assert_eq!(out, "foo bar biz\n");
+  }
 
-	#[test]
-	fn index_cursed() {
-		let guard = TestGuard::new();
-		write_vars(|v| v.set_var("arr", VarKind::Arr(VecDeque::from(["foo".into(), "bar".into(), "biz".into()])), VarFlags::NONE)).unwrap();
-		write_vars(|v| v.set_var("i", VarKind::Arr(VecDeque::from(["0".into(), "1".into(), "2".into()])), VarFlags::NONE)).unwrap();
+  #[test]
+  fn index_cursed() {
+    let guard = TestGuard::new();
+    write_vars(|v| {
+      v.set_var(
+        "arr",
+        VarKind::Arr(VecDeque::from(["foo".into(), "bar".into(), "biz".into()])),
+        VarFlags::NONE,
+      )
+    })
+    .unwrap();
+    write_vars(|v| {
+      v.set_var(
+        "i",
+        VarKind::Arr(VecDeque::from(["0".into(), "1".into(), "2".into()])),
+        VarFlags::NONE,
+      )
+    })
+    .unwrap();
 
-		test_input("echo $echo ${var:-${arr[$(($(echo ${i[0]}) + 1))]}}").unwrap();
+    test_input("echo $echo ${var:-${arr[$(($(echo ${i[0]}) + 1))]}}").unwrap();
 
-		let out = guard.read_output();
-		assert_eq!(out, "bar\n");
-	}
+    let out = guard.read_output();
+    assert_eq!(out, "bar\n");
+  }
 }

src/getopt.rs

@@ -3,7 +3,11 @@ use std::sync::Arc;
 use ariadne::Fmt;
 use fmt::Display;
 
-use crate::{libsh::error::{ShErr, ShErrKind, ShResult, next_color}, parse::lex::Tk, prelude::*};
+use crate::{
+  libsh::error::{ShErr, ShErrKind, ShResult, next_color},
+  parse::lex::Tk,
+  prelude::*,
+};
 
 pub type OptSet = Arc<[Opt]>;
 
@@ -69,30 +73,36 @@ pub fn get_opts(words: Vec<String>) -> (Vec<String>, Vec<Opt>) {
 }
 
 pub fn get_opts_from_tokens_strict(
-	tokens: Vec<Tk>,
-	opt_specs: &[OptSpec],
+  tokens: Vec<Tk>,
+  opt_specs: &[OptSpec],
 ) -> ShResult<(Vec<Tk>, Vec<Opt>)> {
-	sort_tks(tokens, opt_specs, true)
+  sort_tks(tokens, opt_specs, true)
 }
 
 pub fn get_opts_from_tokens(
   tokens: Vec<Tk>,
   opt_specs: &[OptSpec],
 ) -> ShResult<(Vec<Tk>, Vec<Opt>)> {
-	sort_tks(tokens, opt_specs, false)
+  sort_tks(tokens, opt_specs, false)
 }
 
-pub fn sort_tks(tokens: Vec<Tk>, opt_specs: &[OptSpec], strict: bool) -> ShResult<(Vec<Tk>, Vec<Opt>)> {
+pub fn sort_tks(
+  tokens: Vec<Tk>,
+  opt_specs: &[OptSpec],
+  strict: bool,
+) -> ShResult<(Vec<Tk>, Vec<Opt>)> {
   let mut tokens_iter = tokens
     .into_iter()
     .map(|t| t.expand())
     .collect::<ShResult<Vec<_>>>()?
-    .into_iter();
+    .into_iter()
+    .peekable();
   let mut opts = vec![];
   let mut non_opts = vec![];
 
   while let Some(token) = tokens_iter.next() {
     if &token.to_string() == "--" {
+      non_opts.push(token);
       non_opts.extend(tokens_iter);
       break;
     }
@@ -125,14 +135,14 @@ pub fn sort_tks(tokens: Vec<Tk>, opt_specs: &[OptSpec], strict: bool) -> ShResul
           }
         }
         if !pushed {
-					if strict {
-						return Err(ShErr::simple(
-							ShErrKind::ParseErr,
-							format!("Unknown option: {}", opt.to_string().fg(next_color())),
-						));
-					} else {
-						non_opts.push(token.clone());
-					}
+          if strict {
+            return Err(ShErr::simple(
+              ShErrKind::ParseErr,
+              format!("Unknown option: {}", opt.to_string().fg(next_color())),
+            ));
+          } else {
+            non_opts.push(token.clone());
+          }
         }
       }
     }
@@ -140,12 +150,11 @@ pub fn sort_tks(tokens: Vec<Tk>, opt_specs: &[OptSpec], strict: bool) -> ShResul
   Ok((non_opts, opts))
 }
 
-
 #[cfg(test)]
 mod tests {
   use crate::parse::lex::{LexFlags, LexStream};
 
-use super::*;
+  use super::*;
 
   #[test]
   fn parse_short_single() {
@@ -156,7 +165,10 @@ use super::*;
   #[test]
   fn parse_short_combined() {
     let opts = Opt::parse("-abc");
-    assert_eq!(opts, vec![Opt::Short('a'), Opt::Short('b'), Opt::Short('c')]);
+    assert_eq!(
+      opts,
+      vec![Opt::Short('a'), Opt::Short('b'), Opt::Short('c')]
+    );
   }
 
   #[test]
@@ -173,7 +185,12 @@ use super::*;
 
   #[test]
   fn get_opts_basic() {
-    let words = vec!["file.txt".into(), "-v".into(), "--help".into(), "arg".into()];
+    let words = vec![
+      "file.txt".into(),
+      "-v".into(),
+      "--help".into(),
+      "arg".into(),
+    ];
     let (non_opts, opts) = get_opts(words);
     assert_eq!(non_opts, vec!["file.txt", "arg"]);
     assert_eq!(opts, vec![Opt::Short('v'), Opt::Long("help".into())]);
@@ -191,7 +208,10 @@ use super::*;
   fn get_opts_combined_short() {
     let words = vec!["-abc".into(), "file".into()];
     let (non_opts, opts) = get_opts(words);
-    assert_eq!(opts, vec![Opt::Short('a'), Opt::Short('b'), Opt::Short('c')]);
+    assert_eq!(
+      opts,
+      vec![Opt::Short('a'), Opt::Short('b'), Opt::Short('c')]
+    );
     assert_eq!(non_opts, vec!["file"]);
   }
 
@@ -215,128 +235,175 @@ use super::*;
     assert_eq!(Opt::Short('v').to_string(), "-v");
     assert_eq!(Opt::Long("help".into()).to_string(), "--help");
     assert_eq!(Opt::ShortWithArg('o', "file".into()).to_string(), "-o file");
-    assert_eq!(Opt::LongWithArg("output".into(), "file".into()).to_string(), "--output file");
+    assert_eq!(
+      Opt::LongWithArg("output".into(), "file".into()).to_string(),
+      "--output file"
+    );
   }
 
-	fn lex(input: &str) -> Vec<Tk> {
-		LexStream::new(Arc::new(input.to_string()), LexFlags::empty())
-			.collect::<ShResult<Vec<Tk>>>()
-			.unwrap()
-	}
+  fn lex(input: &str) -> Vec<Tk> {
+    LexStream::new(Arc::new(input.to_string()), LexFlags::empty())
+      .collect::<ShResult<Vec<Tk>>>()
+      .unwrap()
+  }
 
-	#[test]
-	fn get_opts_from_tks() {
-		let tokens = lex("file.txt --help -v arg");
+  #[test]
+  fn get_opts_from_tks() {
+    let tokens = lex("file.txt --help -v arg");
 
-		let opt_spec = vec![
-			OptSpec { opt: Opt::Short('v'), takes_arg: false },
-			OptSpec { opt: Opt::Long("help".into()), takes_arg: false },
-		];
+    let opt_spec = vec![
+      OptSpec {
+        opt: Opt::Short('v'),
+        takes_arg: false,
+      },
+      OptSpec {
+        opt: Opt::Long("help".into()),
+        takes_arg: false,
+      },
+    ];
 
-		let (non_opts, opts) = get_opts_from_tokens(tokens, &opt_spec).unwrap();
+    let (non_opts, opts) = get_opts_from_tokens(tokens, &opt_spec).unwrap();
 
-		let mut opts = opts.into_iter();
-		assert!(opts.any(|o| o == Opt::Short('v') || o == Opt::Long("help".into())));
-		assert!(opts.any(|o| o == Opt::Short('v') || o == Opt::Long("help".into())));
+    let mut opts = opts.into_iter();
+    assert!(opts.any(|o| o == Opt::Short('v') || o == Opt::Long("help".into())));
+    assert!(opts.any(|o| o == Opt::Short('v') || o == Opt::Long("help".into())));
 
-		let mut non_opts = non_opts.into_iter().map(|s| s.to_string());
-		assert!(non_opts.any(|s| s == "file.txt" || s == "arg"));
-		assert!(non_opts.any(|s| s == "file.txt" || s == "arg"));
-	}
+    let mut non_opts = non_opts.into_iter().map(|s| s.to_string());
+    assert!(non_opts.any(|s| s == "file.txt" || s == "arg"));
+    assert!(non_opts.any(|s| s == "file.txt" || s == "arg"));
+  }
 
-	#[test]
-	fn tks_short_with_arg() {
-		let tokens = lex("-o output.txt file.txt");
+  #[test]
+  fn tks_short_with_arg() {
+    let tokens = lex("-o output.txt file.txt");
 
-		let opt_spec = vec![
-			OptSpec { opt: Opt::Short('o'), takes_arg: true },
-		];
+    let opt_spec = vec![OptSpec {
+      opt: Opt::Short('o'),
+      takes_arg: true,
+    }];
 
-		let (non_opts, opts) = get_opts_from_tokens(tokens, &opt_spec).unwrap();
+    let (non_opts, opts) = get_opts_from_tokens(tokens, &opt_spec).unwrap();
 
-		assert_eq!(opts, vec![Opt::ShortWithArg('o', "output.txt".into())]);
-		let non_opts: Vec<String> = non_opts.into_iter().map(|s| s.to_string()).collect();
-		assert!(non_opts.contains(&"file.txt".to_string()));
-	}
+    assert_eq!(opts, vec![Opt::ShortWithArg('o', "output.txt".into())]);
+    let non_opts: Vec<String> = non_opts.into_iter().map(|s| s.to_string()).collect();
+    assert!(non_opts.contains(&"file.txt".to_string()));
+  }
 
-	#[test]
-	fn tks_long_with_arg() {
-		let tokens = lex("--output result.txt input.txt");
+  #[test]
+  fn tks_long_with_arg() {
+    let tokens = lex("--output result.txt input.txt");
 
-		let opt_spec = vec![
-			OptSpec { opt: Opt::Long("output".into()), takes_arg: true },
-		];
+    let opt_spec = vec![OptSpec {
+      opt: Opt::Long("output".into()),
+      takes_arg: true,
+    }];
 
-		let (non_opts, opts) = get_opts_from_tokens(tokens, &opt_spec).unwrap();
+    let (non_opts, opts) = get_opts_from_tokens(tokens, &opt_spec).unwrap();
 
-		assert_eq!(opts, vec![Opt::LongWithArg("output".into(), "result.txt".into())]);
-		let non_opts: Vec<String> = non_opts.into_iter().map(|s| s.to_string()).collect();
-		assert!(non_opts.contains(&"input.txt".to_string()));
-	}
+    assert_eq!(
+      opts,
+      vec![Opt::LongWithArg("output".into(), "result.txt".into())]
+    );
+    let non_opts: Vec<String> = non_opts.into_iter().map(|s| s.to_string()).collect();
+    assert!(non_opts.contains(&"input.txt".to_string()));
+  }
 
-	#[test]
-	fn tks_double_dash_stops() {
-		let tokens = lex("-v -- -a --foo");
+  #[test]
+  fn tks_double_dash_stops() {
+    let tokens = lex("-v -- -a --foo");
 
-		let opt_spec = vec![
-			OptSpec { opt: Opt::Short('v'), takes_arg: false },
-			OptSpec { opt: Opt::Short('a'), takes_arg: false },
-		];
+    let opt_spec = vec![
+      OptSpec {
+        opt: Opt::Short('v'),
+        takes_arg: false,
+      },
+      OptSpec {
+        opt: Opt::Short('a'),
+        takes_arg: false,
+      },
+    ];
 
-		let (non_opts, opts) = get_opts_from_tokens(tokens, &opt_spec).unwrap();
+    let (non_opts, opts) = get_opts_from_tokens(tokens, &opt_spec).unwrap();
 
-		assert_eq!(opts, vec![Opt::Short('v')]);
-		let non_opts: Vec<String> = non_opts.into_iter().map(|s| s.to_string()).collect();
-		assert!(non_opts.contains(&"-a".to_string()));
-		assert!(non_opts.contains(&"--foo".to_string()));
-	}
+    assert_eq!(opts, vec![Opt::Short('v')]);
+    let non_opts: Vec<String> = non_opts.into_iter().map(|s| s.to_string()).collect();
+    assert!(non_opts.contains(&"-a".to_string()));
+    assert!(non_opts.contains(&"--foo".to_string()));
+  }
 
-	#[test]
-	fn tks_combined_short_with_spec() {
-		let tokens = lex("-abc");
+  #[test]
+  fn tks_combined_short_with_spec() {
+    let tokens = lex("-abc");
 
-		let opt_spec = vec![
-			OptSpec { opt: Opt::Short('a'), takes_arg: false },
-			OptSpec { opt: Opt::Short('b'), takes_arg: false },
-			OptSpec { opt: Opt::Short('c'), takes_arg: false },
-		];
+    let opt_spec = vec![
+      OptSpec {
+        opt: Opt::Short('a'),
+        takes_arg: false,
+      },
+      OptSpec {
+        opt: Opt::Short('b'),
+        takes_arg: false,
+      },
+      OptSpec {
+        opt: Opt::Short('c'),
+        takes_arg: false,
+      },
+    ];
 
-		let (_non_opts, opts) = get_opts_from_tokens(tokens, &opt_spec).unwrap();
+    let (_non_opts, opts) = get_opts_from_tokens(tokens, &opt_spec).unwrap();
 
-		assert_eq!(opts, vec![Opt::Short('a'), Opt::Short('b'), Opt::Short('c')]);
-	}
+    assert_eq!(
+      opts,
+      vec![Opt::Short('a'), Opt::Short('b'), Opt::Short('c')]
+    );
+  }
 
-	#[test]
-	fn tks_unknown_opt_becomes_non_opt() {
-		let tokens = lex("-v -x file");
+  #[test]
+  fn tks_unknown_opt_becomes_non_opt() {
+    let tokens = lex("-v -x file");
 
-		let opt_spec = vec![
-			OptSpec { opt: Opt::Short('v'), takes_arg: false },
-		];
+    let opt_spec = vec![OptSpec {
+      opt: Opt::Short('v'),
+      takes_arg: false,
+    }];
 
-		let (non_opts, opts) = get_opts_from_tokens(tokens, &opt_spec).unwrap();
+    let (non_opts, opts) = get_opts_from_tokens(tokens, &opt_spec).unwrap();
 
-		assert_eq!(opts, vec![Opt::Short('v')]);
-		// -x is not in spec, so its token goes to non_opts
-		assert!(non_opts.into_iter().map(|s| s.to_string()).any(|s| s == "-x" || s == "file"));
-	}
+    assert_eq!(opts, vec![Opt::Short('v')]);
+    // -x is not in spec, so its token goes to non_opts
+    assert!(
+      non_opts
+        .into_iter()
+        .map(|s| s.to_string())
+        .any(|s| s == "-x" || s == "file")
+    );
+  }
 
-	#[test]
-	fn tks_mixed_short_and_long_with_args() {
-		let tokens = lex("-n 5 --output file.txt input");
+  #[test]
+  fn tks_mixed_short_and_long_with_args() {
+    let tokens = lex("-n 5 --output file.txt input");
 
-		let opt_spec = vec![
-			OptSpec { opt: Opt::Short('n'), takes_arg: true },
-			OptSpec { opt: Opt::Long("output".into()), takes_arg: true },
-		];
+    let opt_spec = vec![
+      OptSpec {
+        opt: Opt::Short('n'),
+        takes_arg: true,
+      },
+      OptSpec {
+        opt: Opt::Long("output".into()),
+        takes_arg: true,
+      },
+    ];
 
-		let (non_opts, opts) = get_opts_from_tokens(tokens, &opt_spec).unwrap();
+    let (non_opts, opts) = get_opts_from_tokens(tokens, &opt_spec).unwrap();
 
-		assert_eq!(opts, vec![
-			Opt::ShortWithArg('n', "5".into()),
-			Opt::LongWithArg("output".into(), "file.txt".into()),
-		]);
-		let non_opts: Vec<String> = non_opts.into_iter().map(|s| s.to_string()).collect();
-		assert!(non_opts.contains(&"input".to_string()));
-	}
+    assert_eq!(
+      opts,
+      vec![
+        Opt::ShortWithArg('n', "5".into()),
+        Opt::LongWithArg("output".into(), "file.txt".into()),
+      ]
+    );
+    let non_opts: Vec<String> = non_opts.into_iter().map(|s| s.to_string()).collect();
+    assert!(non_opts.contains(&"input".to_string()));
+  }
 }

src/libsh/error.rs

@@ -1,10 +1,10 @@
 use ariadne::{Color, Fmt};
 use ariadne::{Report, ReportKind};
 use rand::TryRng;
-use yansi::Paint;
 use std::cell::RefCell;
 use std::collections::{HashMap, VecDeque};
 use std::fmt::Display;
+use yansi::Paint;
 
 use crate::procio::RedirGuard;
 use crate::{
@@ -150,7 +150,7 @@ impl Display for Note {
       writeln!(f, "{note}: {main}")?;
     } else {
       let bar_break = Fmt::fg("-", Color::Cyan);
-			let bar_break = bar_break.bold();
+      let bar_break = bar_break.bold();
       let indent = "  ".repeat(self.depth);
       writeln!(f, "  {indent}{bar_break} {main}")?;
     }
@@ -201,6 +201,7 @@ impl ShErr {
   pub fn is_flow_control(&self) -> bool {
     self.kind.is_flow_control()
   }
+  /// Promotes a shell error from a simple error to an error that blames a span
   pub fn promote(mut self, span: Span) -> Self {
     if self.notes.is_empty() {
       return self;
@@ -208,6 +209,8 @@ impl ShErr {
     let first = self.notes[0].clone();
     if self.notes.len() > 1 {
       self.notes = self.notes[1..].to_vec();
+    } else {
+      self.notes = vec![];
     }
 
     self.labeled(span, first)

src/libsh/guards.rs

@@ -3,7 +3,7 @@ use std::collections::HashSet;
 use std::os::fd::{BorrowedFd, RawFd};
 
 use nix::sys::termios::{self, LocalFlags, Termios, tcgetattr, tcsetattr};
-use nix::unistd::isatty;
+use nix::unistd::{isatty, write};
 use scopeguard::guard;
 
 thread_local! {
@@ -147,11 +147,10 @@ impl RawModeGuard {
     let orig = ORIG_TERMIOS
       .with(|cell| cell.borrow().clone())
       .expect("with_cooked_mode called before raw_mode()");
-    tcsetattr(borrow_fd(*TTY_FILENO), termios::SetArg::TCSANOW, &orig)
-      .expect("Failed to restore cooked mode");
+    tcsetattr(borrow_fd(*TTY_FILENO), termios::SetArg::TCSANOW, &orig).ok();
     let res = f();
-    tcsetattr(borrow_fd(*TTY_FILENO), termios::SetArg::TCSANOW, &current)
-      .expect("Failed to restore raw mode");
+    tcsetattr(borrow_fd(*TTY_FILENO), termios::SetArg::TCSANOW, &current).ok();
+    unsafe { write(BorrowedFd::borrow_raw(*TTY_FILENO), b"\x1b[?1l\x1b>").ok() };
     res
   }
 }
@@ -159,11 +158,12 @@ impl RawModeGuard {
 impl Drop for RawModeGuard {
   fn drop(&mut self) {
     unsafe {
-      let _ = termios::tcsetattr(
+      termios::tcsetattr(
         BorrowedFd::borrow_raw(self.fd),
         termios::SetArg::TCSANOW,
         &self.orig,
-      );
+      )
+      .ok();
     }
   }
 }

src/libsh/sys.rs

@@ -2,6 +2,15 @@ use std::sync::LazyLock;
 
 use crate::prelude::*;
 
+/// Minimum fd number for shell-internal file descriptors.
+const MIN_INTERNAL_FD: RawFd = 10;
+
 pub static TTY_FILENO: LazyLock<RawFd> = LazyLock::new(|| {
-  open("/dev/tty", OFlag::O_RDWR, Mode::empty()).expect("Failed to open /dev/tty")
+  let fd = open("/dev/tty", OFlag::O_RDWR, Mode::empty()).expect("Failed to open /dev/tty");
+  // Move the tty fd above the user-accessible range so that
+  // `exec 3>&-` and friends don't collide with shell internals.
+  let high =
+    fcntl(fd, FcntlArg::F_DUPFD_CLOEXEC(MIN_INTERNAL_FD)).expect("Failed to dup /dev/tty high");
+  close(fd).ok();
+  high
 });

src/main.rs

@@ -39,9 +39,11 @@ use crate::procio::borrow_fd;
 use crate::readline::term::{LineWriter, RawModeGuard, raw_mode};
 use crate::readline::{Prompt, ReadlineEvent, ShedVi};
 use crate::signal::{GOT_SIGWINCH, JOB_DONE, QUIT_CODE, check_signals, sig_setup, signals_pending};
-use crate::state::{AutoCmdKind, read_logic, read_shopts, source_rc, write_jobs, write_meta};
+use crate::state::{
+  AutoCmdKind, read_logic, read_shopts, source_rc, write_jobs, write_meta, write_shopts,
+};
 use clap::Parser;
-use state::{read_vars, write_vars};
+use state::write_vars;
 
 #[derive(Parser, Debug)]
 struct ShedArgs {
@@ -63,20 +65,6 @@ struct ShedArgs {
   login_shell: bool,
 }
 
-/// Force evaluation of lazily-initialized values early in shell startup.
-///
-/// In particular, this ensures that the variable table is initialized, which
-/// populates environment variables from the system. If this initialization is
-/// deferred too long, features like prompt expansion may fail due to missing
-/// environment variables.
-///
-/// This function triggers initialization by calling `read_vars` with a no-op
-/// closure, which forces access to the variable table and causes its `LazyLock`
-/// constructor to run.
-fn kickstart_lazy_evals() {
-  read_vars(|_| {});
-}
-
 /// We need to make sure that even if we panic, our child processes get sighup
 fn setup_panic_handler() {
   let default_panic_hook = std::panic::take_hook();
@@ -111,7 +99,6 @@ fn setup_panic_handler() {
 fn main() -> ExitCode {
   yansi::enable();
   env_logger::init();
-  kickstart_lazy_evals();
   setup_panic_handler();
 
   let mut args = ShedArgs::parse();
@@ -130,14 +117,24 @@ fn main() -> ExitCode {
     return ExitCode::SUCCESS;
   }
 
+  // Increment SHLVL, or set to 1 if not present or invalid.
+  // This var represents how many nested shell instances we're in
+  if let Ok(var) = env::var("SHLVL")
+    && let Ok(lvl) = var.parse::<u32>()
+  {
+    unsafe { env::set_var("SHLVL", (lvl + 1).to_string()) };
+  } else {
+    unsafe { env::set_var("SHLVL", "1") };
+  }
+
   if let Err(e) = if let Some(path) = args.script {
     run_script(path, args.script_args)
   } else if let Some(cmd) = args.command {
     exec_dash_c(cmd)
   } else {
     let res = shed_interactive(args);
-		write(borrow_fd(*TTY_FILENO), b"\x1b[?2004l").ok(); // disable bracketed paste mode on exit
-		res
+    write(borrow_fd(*TTY_FILENO), b"\x1b[?2004l").ok(); // disable bracketed paste mode on exit
+    res
   } {
     e.print_error();
   };
@@ -207,7 +204,7 @@ fn shed_interactive(args: ShedArgs) -> ShResult<()> {
     }
   };
 
-	readline.writer.flush_write("\x1b[?2004h")?; // enable bracketed paste mode
+  readline.writer.flush_write("\x1b[?2004h")?; // enable bracketed paste mode
 
   // Main poll loop
   loop {
@@ -226,9 +223,9 @@ fn shed_interactive(args: ShedArgs) -> ShResult<()> {
             readline.reset_active_widget(false)?;
           }
           ShErrKind::CleanExit(code) => {
-						QUIT_CODE.store(*code, Ordering::SeqCst);
-						return Ok(());
-					}
+            QUIT_CODE.store(*code, Ordering::SeqCst);
+            return Ok(());
+          }
           _ => e.print_error(),
         }
       }
@@ -255,14 +252,38 @@ fn shed_interactive(args: ShedArgs) -> ShResult<()> {
       PollFlags::POLLIN,
     )];
 
+    let mut exec_if_timeout = None;
+
     let timeout = if readline.pending_keymap.is_empty() {
-      PollTimeout::MAX
+      let screensaver_cmd = read_shopts(|o| o.prompt.screensaver_cmd.clone());
+      let screensaver_idle_time = read_shopts(|o| o.prompt.screensaver_idle_time);
+      if screensaver_idle_time > 0 && !screensaver_cmd.is_empty() {
+        exec_if_timeout = Some(screensaver_cmd);
+        PollTimeout::from((screensaver_idle_time * 1000) as u16)
+      } else {
+        PollTimeout::MAX
+      }
     } else {
       PollTimeout::from(1000u16)
     };
 
     match poll(&mut fds, timeout) {
-      Ok(_) => {}
+      Ok(0) => {
+        // We timed out.
+        if let Some(cmd) = exec_if_timeout {
+          let prepared = ReadlineEvent::Line(cmd);
+          let saved_hist_opt = read_shopts(|o| o.core.auto_hist);
+          let _guard = scopeguard::guard(saved_hist_opt, |opt| {
+            write_shopts(|o| o.core.auto_hist = opt);
+          });
+          write_shopts(|o| o.core.auto_hist = false); // don't save screensaver command to history
+
+          match handle_readline_event(&mut readline, Ok(prepared))? {
+            true => return Ok(()),
+            false => continue,
+          }
+        }
+      }
       Err(Errno::EINTR) => {
         // Interrupted by signal, loop back to handle it
         continue;
@@ -271,6 +292,7 @@ fn shed_interactive(args: ShedArgs) -> ShResult<()> {
         eprintln!("poll error: {e}");
         break;
       }
+      Ok(_) => {}
     }
 
     // Timeout — resolve pending keymap ambiguity

src/parse/execute.rs

@@ -8,7 +8,7 @@ use ariadne::Fmt;
 
 use crate::{
   builtin::{
-    alias::{alias, unalias}, arrops::{arr_fpop, arr_fpush, arr_pop, arr_push, arr_rotate}, autocmd::autocmd, cd::cd, complete::{compgen_builtin, complete_builtin}, dirstack::{dirs, popd, pushd}, echo::echo, eval, exec, flowctl::flowctl, getopts::getopts, intro, jobctl::{self, JobBehavior, continue_job, disown, jobs}, keymap, map, pwd::pwd, read::{self, read_builtin}, resource::{ulimit, umask_builtin}, shift::shift, shopt::shopt, source::source, test::double_bracket_test, trap::{TrapTarget, trap}, varcmds::{export, local, readonly, unset}
+    alias::{alias, unalias}, arrops::{arr_fpop, arr_fpush, arr_pop, arr_push, arr_rotate}, autocmd::autocmd, cd::cd, complete::{compgen_builtin, complete_builtin}, dirstack::{dirs, popd, pushd}, echo::echo, eval, exec, flowctl::flowctl, getopts::getopts, help::help, intro, jobctl::{self, JobBehavior, continue_job, disown, jobs}, keymap, map, pwd::pwd, read::{self, read_builtin}, resource::{ulimit, umask_builtin}, seek::seek, shift::shift, shopt::shopt, source::source, test::double_bracket_test, trap::{TrapTarget, trap}, varcmds::{export, local, readonly, unset}
   },
   expand::{expand_aliases, expand_case_pattern, glob_to_regex},
   jobs::{ChildProc, JobStack, attach_tty, dispatch_job},
@@ -136,13 +136,18 @@ pub fn exec_dash_c(input: String) -> ShResult<()> {
   if nodes.len() == 1 {
     let is_single_cmd = match &nodes[0].class {
       NdRule::Command { .. } => true,
-      NdRule::Pipeline { cmds } => cmds.len() == 1 && matches!(cmds[0].class, NdRule::Command { .. }),
+      NdRule::Pipeline { cmds } => {
+        cmds.len() == 1 && matches!(cmds[0].class, NdRule::Command { .. })
+      }
       NdRule::Conjunction { elements } => {
-        elements.len() == 1 && match &elements[0].cmd.class {
-          NdRule::Pipeline { cmds } => cmds.len() == 1 && matches!(cmds[0].class, NdRule::Command { .. }),
-          NdRule::Command { .. } => true,
-          _ => false,
-        }
+        elements.len() == 1
+          && match &elements[0].cmd.class {
+            NdRule::Pipeline { cmds } => {
+              cmds.len() == 1 && matches!(cmds[0].class, NdRule::Command { .. })
+            }
+            NdRule::Command { .. } => true,
+            _ => false,
+          }
       }
       _ => false,
     };
@@ -151,8 +156,12 @@ pub fn exec_dash_c(input: String) -> ShResult<()> {
       let mut node = nodes.remove(0);
       loop {
         match node.class {
-          NdRule::Conjunction { mut elements } => { node = *elements.remove(0).cmd; }
-          NdRule::Pipeline { mut cmds } => { node = cmds.remove(0); }
+          NdRule::Conjunction { mut elements } => {
+            node = *elements.remove(0).cmd;
+          }
+          NdRule::Pipeline { mut cmds } => {
+            node = cmds.remove(0);
+          }
           NdRule::Command { .. } => break,
           _ => break,
         }
@@ -250,7 +259,7 @@ impl Dispatcher {
       NdRule::CaseNode { .. } => self.exec_case(node)?,
       NdRule::BraceGrp { .. } => self.exec_brc_grp(node)?,
       NdRule::FuncDef { .. } => self.exec_func_def(node)?,
-			NdRule::Negate { .. } => self.exec_negated(node)?,
+      NdRule::Negate { .. } => self.exec_negated(node)?,
       NdRule::Command { .. } => self.dispatch_cmd(node)?,
       NdRule::Test { .. } => self.exec_test(node)?,
       _ => unreachable!(),
@@ -258,6 +267,15 @@ impl Dispatcher {
     Ok(())
   }
   pub fn dispatch_cmd(&mut self, node: Node) -> ShResult<()> {
+    let (line, _) = node.get_span().clone().line_and_col();
+    write_vars(|v| {
+      v.set_var(
+        "LINENO",
+        VarKind::Str((line + 1).to_string()),
+        VarFlags::NONE,
+      )
+    })?;
+
     let Some(cmd) = node.get_command() else {
       return self.exec_cmd(node); // Argv is empty, probably an assignment
     };
@@ -285,40 +303,35 @@ impl Dispatcher {
       self.exec_cmd(node)
     }
   }
-	pub fn exec_negated(&mut self, node: Node) -> ShResult<()> {
-		let NdRule::Negate { cmd } = node.class else {
-			unreachable!()
-		};
-		self.dispatch_node(*cmd)?;
-		let status = state::get_status();
-		state::set_status(if status == 0 { 1 } else { 0 });
+  pub fn exec_negated(&mut self, node: Node) -> ShResult<()> {
+    let NdRule::Negate { cmd } = node.class else {
+      unreachable!()
+    };
+    self.dispatch_node(*cmd)?;
+    let status = state::get_status();
+    state::set_status(if status == 0 { 1 } else { 0 });
 
-		Ok(())
-	}
+    Ok(())
+  }
   pub fn exec_conjunction(&mut self, conjunction: Node) -> ShResult<()> {
     let NdRule::Conjunction { elements } = conjunction.class else {
       unreachable!()
     };
 
     let mut elem_iter = elements.into_iter();
+    let mut skip = false;
     while let Some(element) = elem_iter.next() {
       let ConjunctNode { cmd, operator } = element;
-      self.dispatch_node(*cmd)?;
+      if !skip {
+        self.dispatch_node(*cmd)?;
+      }
 
       let status = state::get_status();
-      match operator {
-        ConjunctOp::And => {
-          if status != 0 {
-            break;
-          }
-        }
-        ConjunctOp::Or => {
-          if status == 0 {
-            break;
-          }
-        }
+      skip = match operator {
+        ConjunctOp::And => status != 0,
+        ConjunctOp::Or => status == 0,
         ConjunctOp::Null => break,
-      }
+      };
     }
     Ok(())
   }
@@ -338,7 +351,11 @@ impl Dispatcher {
     };
     let body_span = body.get_span();
     let body = body_span.as_str().to_string();
-    let name = name.span.as_str().strip_suffix("()").unwrap();
+    let name = name
+      .span
+      .as_str()
+      .strip_suffix("()")
+      .unwrap_or(name.span.as_str());
 
     if KEYWORDS.contains(&name) {
       return Err(ShErr::at(
@@ -361,7 +378,7 @@ impl Dispatcher {
     Ok(())
   }
   fn exec_subsh(&mut self, subsh: Node) -> ShResult<()> {
-		let _blame = subsh.get_span().clone();
+    let _blame = subsh.get_span().clone();
     let NdRule::Command { assignments, argv } = subsh.class else {
       unreachable!()
     };
@@ -765,7 +782,18 @@ impl Dispatcher {
     if cmds.len() == 1 {
       self.fg_job = !is_bg && self.interactive;
       let cmd = cmds.into_iter().next().unwrap();
-      self.dispatch_node(cmd)?;
+      if is_bg && !matches!(cmd.class, NdRule::Command { .. }) {
+        self.run_fork(
+          &cmd.get_command().map(|t| t.to_string()).unwrap_or_default(),
+          |s| {
+            if let Err(e) = s.dispatch_node(cmd) {
+              e.print_error();
+            }
+          },
+        )?;
+      } else {
+        self.dispatch_node(cmd)?;
+      }
 
       // Give the pipeline terminal control as soon as the first child
       // establishes the PGID, so later children (e.g. nvim) don't get
@@ -838,7 +866,10 @@ impl Dispatcher {
 
     if fork_builtins {
       log::trace!("Forking builtin: {}", cmd_raw);
-      let _guard = self.io_stack.pop_frame().redirect()?;
+      let guard = self.io_stack.pop_frame().redirect()?;
+      if cmd_raw.as_str() == "exec" {
+        guard.persist();
+      }
       self.run_fork(&cmd_raw, |s| {
         if let Err(e) = s.dispatch_builtin(cmd) {
           e.print_error();
@@ -961,8 +992,10 @@ impl Dispatcher {
       "keymap" => keymap::keymap(cmd),
       "read_key" => read::read_key(cmd),
       "autocmd" => autocmd(cmd),
-			"ulimit" => ulimit(cmd),
-			"umask" => umask_builtin(cmd),
+      "ulimit" => ulimit(cmd),
+      "umask" => umask_builtin(cmd),
+      "seek" => seek(cmd),
+			"help" => help(cmd),
       "true" | ":" => {
         state::set_status(0);
         Ok(())
@@ -1100,6 +1133,7 @@ impl Dispatcher {
     match unsafe { fork()? } {
       ForkResult::Child => {
         let _ = setpgid(Pid::from_raw(0), existing_pgid.unwrap_or(Pid::from_raw(0)));
+        self.interactive = false;
         f(self);
         exit(state::get_status())
       }
@@ -1319,83 +1353,94 @@ mod tests {
     assert_eq!(state::get_status(), 0);
   }
 
-	// ===================== other stuff =====================
+  // ===================== other stuff =====================
 
-	#[test]
-	fn for_loop_var_zip() {
-		let g = TestGuard::new();
-		test_input("for a b in 1 2 3 4 5 6; do echo $a $b; done").unwrap();
-		let out = g.read_output();
-		assert_eq!(out, "1 2\n3 4\n5 6\n");
-	}
+  #[test]
+  fn for_loop_var_zip() {
+    let g = TestGuard::new();
+    test_input("for a b in 1 2 3 4 5 6; do echo $a $b; done").unwrap();
+    let out = g.read_output();
+    assert_eq!(out, "1 2\n3 4\n5 6\n");
+  }
 
-	#[test]
-	fn for_loop_unsets_zipped() {
-		let g = TestGuard::new();
-		test_input("for a b c d in 1 2 3 4 5 6; do echo $a $b $c $d; done").unwrap();
-		let out = g.read_output();
-		assert_eq!(out, "1 2 3 4\n5 6\n");
-	}
+  #[test]
+  fn for_loop_unsets_zipped() {
+    let g = TestGuard::new();
+    test_input("for a b c d in 1 2 3 4 5 6; do echo $a $b $c $d; done").unwrap();
+    let out = g.read_output();
+    assert_eq!(out, "1 2 3 4\n5 6\n");
+  }
 
-	// ===================== negation (!) status =====================
+  // ===================== negation (!) status =====================
 
-	#[test]
-	fn negate_true() {
-		let _g = TestGuard::new();
-		test_input("! true").unwrap();
-		assert_eq!(state::get_status(), 1);
-	}
+  #[test]
+  fn negate_true() {
+    let _g = TestGuard::new();
+    test_input("! true").unwrap();
+    assert_eq!(state::get_status(), 1);
+  }
 
-	#[test]
-	fn negate_false() {
-		let _g = TestGuard::new();
-		test_input("! false").unwrap();
-		assert_eq!(state::get_status(), 0);
-	}
+  #[test]
+  fn negate_false() {
+    let _g = TestGuard::new();
+    test_input("! false").unwrap();
+    assert_eq!(state::get_status(), 0);
+  }
 
-	#[test]
-	fn double_negate_true() {
-		let _g = TestGuard::new();
-		test_input("! ! true").unwrap();
-		assert_eq!(state::get_status(), 0);
-	}
+  #[test]
+  fn double_negate_true() {
+    let _g = TestGuard::new();
+    test_input("! ! true").unwrap();
+    assert_eq!(state::get_status(), 0);
+  }
 
-	#[test]
-	fn double_negate_false() {
-		let _g = TestGuard::new();
-		test_input("! ! false").unwrap();
-		assert_eq!(state::get_status(), 1);
-	}
+  #[test]
+  fn double_negate_false() {
+    let _g = TestGuard::new();
+    test_input("! ! false").unwrap();
+    assert_eq!(state::get_status(), 1);
+  }
 
-	#[test]
-	fn negate_pipeline_last_cmd() {
-		let _g = TestGuard::new();
-		// pipeline status = last cmd (false) = 1, negated → 0
-		test_input("! true | false").unwrap();
-		assert_eq!(state::get_status(), 0);
-	}
+  #[test]
+  fn negate_pipeline_last_cmd() {
+    let _g = TestGuard::new();
+    // pipeline status = last cmd (false) = 1, negated → 0
+    test_input("! true | false").unwrap();
+    assert_eq!(state::get_status(), 0);
+  }
 
-	#[test]
-	fn negate_pipeline_last_cmd_true() {
-		let _g = TestGuard::new();
-		// pipeline status = last cmd (true) = 0, negated → 1
-		test_input("! false | true").unwrap();
-		assert_eq!(state::get_status(), 1);
-	}
+  #[test]
+  fn negate_pipeline_last_cmd_true() {
+    let _g = TestGuard::new();
+    // pipeline status = last cmd (true) = 0, negated → 1
+    test_input("! false | true").unwrap();
+    assert_eq!(state::get_status(), 1);
+  }
 
-	#[test]
-	fn negate_in_conjunction() {
-		let _g = TestGuard::new();
-		// ! binds to pipeline, not conjunction: (! (true && false)) && true
-		test_input("! (true && false) && true").unwrap();
-		assert_eq!(state::get_status(), 0);
-	}
+  #[test]
+  fn negate_in_conjunction() {
+    let _g = TestGuard::new();
+    // ! binds to pipeline, not conjunction: (! (true && false)) && true
+    test_input("! (true && false) && true").unwrap();
+    assert_eq!(state::get_status(), 0);
+  }
 
-	#[test]
-	fn negate_in_if_condition() {
-		let g = TestGuard::new();
-		test_input("if ! false; then echo yes; fi").unwrap();
-		assert_eq!(state::get_status(), 0);
-		assert_eq!(g.read_output(), "yes\n");
-	}
+  #[test]
+  fn negate_in_if_condition() {
+    let g = TestGuard::new();
+    test_input("if ! false; then echo yes; fi").unwrap();
+    assert_eq!(state::get_status(), 0);
+    assert_eq!(g.read_output(), "yes\n");
+  }
+
+  #[test]
+  fn empty_var_in_test() {
+    let _g = TestGuard::new();
+    // POSIX specifies that a quoted unset variable expands to an empty string, so the shell actually sees `[ -n "" ]`, which returns false
+    test_input("[ -n \"$EMPTYVAR_PROBABLY_NOT_SET_TO_ANYTHING\" ]").unwrap();
+    assert_eq!(state::get_status(), 1);
+    // Without quotes, word splitting causes an empty var to be removed entirely, so the shell actually sees `[ -n ]`, testing the value of ']', which returns true
+    test_input("[ -n $EMPTYVAR_PROBABLY_NOT_SET_TO_ANYTHING ]").unwrap();
+    assert_eq!(state::get_status(), 0);
+  }
 }

src/parse/lex.rs

@@ -19,7 +19,7 @@ use crate::{
 
 pub const KEYWORDS: [&str; 17] = [
   "if", "then", "elif", "else", "fi", "while", "until", "select", "for", "in", "do", "done",
-  "case", "esac", "[[", "]]", "!"
+  "case", "esac", "[[", "]]", "!",
 ];
 
 pub const OPENERS: [&str; 6] = ["if", "while", "until", "for", "select", "case"];
@@ -166,7 +166,7 @@ pub enum TkRule {
   ErrPipe,
   And,
   Or,
-	Bang,
+  Bang,
   Bg,
   Sep,
   Redir,
@@ -217,6 +217,31 @@ impl Tk {
     };
     self.span.as_str().trim() == ";;"
   }
+
+  pub fn is_opener(&self) -> bool {
+    OPENERS.contains(&self.as_str())
+      || matches!(self.class, TkRule::BraceGrpStart)
+      || matches!(self.class, TkRule::CasePattern)
+  }
+  pub fn is_closer(&self) -> bool {
+    matches!(self.as_str(), "fi" | "done" | "esac")
+      || self.has_double_semi()
+      || matches!(self.class, TkRule::BraceGrpEnd)
+  }
+
+  pub fn is_closer_for(&self, other: &Tk) -> bool {
+    if (matches!(other.class, TkRule::BraceGrpStart) && matches!(self.class, TkRule::BraceGrpEnd))
+      || (matches!(other.class, TkRule::CasePattern) && self.has_double_semi())
+    {
+      return true;
+    }
+    match other.as_str() {
+      "for" | "while" | "until" => matches!(self.as_str(), "done"),
+      "if" => matches!(self.as_str(), "fi"),
+      "case" => matches!(self.as_str(), "esac"),
+      _ => false,
+    }
+  }
 }
 
 impl Display for Tk {
@@ -241,20 +266,12 @@ bitflags! {
     const ASSIGN       = 0b0000000001000000;
     const BUILTIN      = 0b0000000010000000;
     const IS_PROCSUB   = 0b0000000100000000;
+    const IS_HEREDOC   = 0b0000001000000000;
+    const LIT_HEREDOC  = 0b0000010000000000;
+    const TAB_HEREDOC  = 0b0000100000000000;
   }
 }
 
-pub struct LexStream {
-  source: Arc<String>,
-  pub cursor: usize,
-  pub name: String,
-  quote_state: QuoteState,
-  brc_grp_depth: usize,
-  brc_grp_start: Option<usize>,
-  case_depth: usize,
-  flags: LexFlags,
-}
-
 bitflags! {
   #[derive(Debug, Clone, Copy)]
   pub struct LexFlags: u32 {
@@ -296,6 +313,18 @@ pub fn clean_input(input: &str) -> String {
   output
 }
 
+pub struct LexStream {
+  source: Arc<String>,
+  pub cursor: usize,
+  pub name: String,
+  quote_state: QuoteState,
+  brc_grp_depth: usize,
+  brc_grp_start: Option<usize>,
+  case_depth: usize,
+  heredoc_skip: Option<usize>,
+  flags: LexFlags,
+}
+
 impl LexStream {
   pub fn new(source: Arc<String>, flags: LexFlags) -> Self {
     let flags = flags | LexFlags::FRESH | LexFlags::NEXT_IS_CMD;
@@ -307,6 +336,7 @@ impl LexStream {
       quote_state: QuoteState::default(),
       brc_grp_depth: 0,
       brc_grp_start: None,
+      heredoc_skip: None,
       case_depth: 0,
     }
   }
@@ -367,7 +397,7 @@ impl LexStream {
   }
   pub fn read_redir(&mut self) -> Option<ShResult<Tk>> {
     assert!(self.cursor <= self.source.len());
-    let slice = self.slice(self.cursor..)?;
+    let slice = self.slice(self.cursor..)?.to_string();
     let mut pos = self.cursor;
     let mut chars = slice.chars().peekable();
     let mut tk = Tk::default();
@@ -379,33 +409,47 @@ impl LexStream {
             return None; // It's a process sub
           }
           pos += 1;
+          if let Some('|') = chars.peek() {
+            // noclobber force '>|'
+            chars.next();
+            pos += 1;
+            tk = self.get_token(self.cursor..pos, TkRule::Redir);
+            break;
+          }
+
           if let Some('>') = chars.peek() {
             chars.next();
             pos += 1;
           }
-          if let Some('&') = chars.peek() {
-            chars.next();
-            pos += 1;
+          let Some('&') = chars.peek() else {
+            tk = self.get_token(self.cursor..pos, TkRule::Redir);
+            break;
+          };
 
-            let mut found_fd = false;
+          chars.next();
+          pos += 1;
+
+          let mut found_fd = false;
+          if chars.peek().is_some_and(|ch| *ch == '-') {
+            chars.next();
+            found_fd = true;
+            pos += 1;
+          } else {
             while chars.peek().is_some_and(|ch| ch.is_ascii_digit()) {
               chars.next();
               found_fd = true;
               pos += 1;
             }
+          }
 
-            if !found_fd && !self.flags.contains(LexFlags::LEX_UNFINISHED) {
-              let span_start = self.cursor;
-              self.cursor = pos;
-              return Some(Err(ShErr::at(
-                ShErrKind::ParseErr,
-                Span::new(span_start..pos, self.source.clone()),
-                "Invalid redirection",
-              )));
-            } else {
-              tk = self.get_token(self.cursor..pos, TkRule::Redir);
-              break;
-            }
+          if !found_fd && !self.flags.contains(LexFlags::LEX_UNFINISHED) {
+            let span_start = self.cursor;
+            self.cursor = pos;
+            return Some(Err(ShErr::at(
+              ShErrKind::ParseErr,
+              Span::new(span_start..pos, self.source.clone()),
+              "Invalid redirection",
+            )));
           } else {
             tk = self.get_token(self.cursor..pos, TkRule::Redir);
             break;
@@ -417,14 +461,94 @@ impl LexStream {
           }
           pos += 1;
 
-          for _ in 0..2 {
-            if let Some('<') = chars.peek() {
+          match chars.peek() {
+            Some('<') => {
               chars.next();
               pos += 1;
-            } else {
+
+              match chars.peek() {
+                Some('<') => {
+                  chars.next();
+                  pos += 1;
+                }
+
+                Some(ch) => {
+                  let mut ch = *ch;
+                  while is_field_sep(ch) {
+                    let Some(next_ch) = chars.next() else {
+                      // Incomplete input — fall through to emit << as Redir
+                      break;
+                    };
+                    pos += next_ch.len_utf8();
+                    ch = next_ch;
+                  }
+
+                  if is_field_sep(ch) {
+                    // Ran out of input while skipping whitespace — fall through
+                  } else {
+                    let saved_cursor = self.cursor;
+                    match self.read_heredoc(pos) {
+                      Ok(Some(heredoc_tk)) => {
+                        // cursor is set to after the delimiter word;
+                        // heredoc_skip is set to after the body
+                        pos = self.cursor;
+                        self.cursor = saved_cursor;
+                        tk = heredoc_tk;
+                        break;
+                      }
+                      Ok(None) => {
+                        // Incomplete heredoc — restore cursor and fall through
+                        self.cursor = saved_cursor;
+                      }
+                      Err(e) => return Some(Err(e)),
+                    }
+                  }
+                }
+                _ => {
+                  // No delimiter yet — input is incomplete
+                  // Fall through to emit the << as a Redir token
+                }
+              }
+            }
+            Some('>') => {
+              chars.next();
+              pos += 1;
+              tk = self.get_token(self.cursor..pos, TkRule::Redir);
               break;
             }
+            Some('&') => {
+              chars.next();
+              pos += 1;
+
+              let mut found_fd = false;
+              if chars.peek().is_some_and(|ch| *ch == '-') {
+                chars.next();
+                found_fd = true;
+                pos += 1;
+              } else {
+                while chars.peek().is_some_and(|ch| ch.is_ascii_digit()) {
+                  chars.next();
+                  found_fd = true;
+                  pos += 1;
+                }
+              }
+
+              if !found_fd && !self.flags.contains(LexFlags::LEX_UNFINISHED) {
+                let span_start = self.cursor;
+                self.cursor = pos;
+                return Some(Err(ShErr::at(
+                  ShErrKind::ParseErr,
+                  Span::new(span_start..pos, self.source.clone()),
+                  "Invalid redirection",
+                )));
+              } else {
+                tk = self.get_token(self.cursor..pos, TkRule::Redir);
+                break;
+              }
+            }
+            _ => {}
           }
+
           tk = self.get_token(self.cursor..pos, TkRule::Redir);
           break;
         }
@@ -448,6 +572,133 @@ impl LexStream {
     self.cursor = pos;
     Some(Ok(tk))
   }
+  pub fn read_heredoc(&mut self, mut pos: usize) -> ShResult<Option<Tk>> {
+    let slice = self.slice(pos..).unwrap_or_default().to_string();
+    let mut chars = slice.chars();
+    let mut delim = String::new();
+    let mut flags = TkFlags::empty();
+    let mut first_char = true;
+    // Parse the delimiter word, stripping quotes
+    while let Some(ch) = chars.next() {
+      match ch {
+        '-' if first_char => {
+          pos += 1;
+          flags |= TkFlags::TAB_HEREDOC;
+        }
+        '\"' => {
+          pos += 1;
+          self.quote_state.toggle_double();
+          flags |= TkFlags::LIT_HEREDOC;
+        }
+        '\'' => {
+          pos += 1;
+          self.quote_state.toggle_single();
+          flags |= TkFlags::LIT_HEREDOC;
+        }
+        _ if self.quote_state.in_quote() => {
+          pos += ch.len_utf8();
+          delim.push(ch);
+        }
+        ch if is_hard_sep(ch) => {
+          break;
+        }
+        ch => {
+          pos += ch.len_utf8();
+          delim.push(ch);
+        }
+      }
+      first_char = false;
+    }
+
+    // pos is now right after the delimiter word — this is where
+    // the cursor should return so the rest of the line gets lexed
+    let cursor_after_delim = pos;
+
+    // Re-slice from cursor_after_delim so iterator and pos are in sync
+    // (the old chars iterator consumed the hard_sep without advancing pos)
+    let rest = self
+      .slice(cursor_after_delim..)
+      .unwrap_or_default()
+      .to_string();
+    let mut chars = rest.chars();
+
+    // Scan forward to the newline (or use heredoc_skip from a previous heredoc)
+    let body_start = if let Some(skip) = self.heredoc_skip {
+      // A previous heredoc on this line already read its body;
+      // our body starts where that one ended
+      let skip_offset = skip - cursor_after_delim;
+      for _ in 0..skip_offset {
+        chars.next();
+      }
+      skip
+    } else {
+      // Skip the rest of the current line to find where the body begins
+      let mut scan = pos;
+      let mut found_newline = false;
+      while let Some(ch) = chars.next() {
+        scan += ch.len_utf8();
+        if ch == '\n' {
+          found_newline = true;
+          break;
+        }
+      }
+      if !found_newline {
+        if self.flags.contains(LexFlags::LEX_UNFINISHED) {
+          return Ok(None);
+        } else {
+          return Err(ShErr::at(
+            ShErrKind::ParseErr,
+            Span::new(pos..pos, self.source.clone()),
+            "Heredoc delimiter not found",
+          ));
+        }
+      }
+      scan
+    };
+
+    pos = body_start;
+    let start = pos;
+
+    // Read lines until we find one that matches the delimiter exactly
+    let mut line = String::new();
+    let mut line_start = pos;
+    while let Some(ch) = chars.next() {
+      pos += ch.len_utf8();
+      if ch == '\n' {
+        let trimmed = line.trim_end_matches('\r');
+        if trimmed == delim {
+          let mut tk = self.get_token(start..line_start, TkRule::Redir);
+          tk.flags |= TkFlags::IS_HEREDOC | flags;
+          self.heredoc_skip = Some(pos);
+          self.cursor = cursor_after_delim;
+          return Ok(Some(tk));
+        }
+        line.clear();
+        line_start = pos;
+      } else {
+        line.push(ch);
+      }
+    }
+    // Check the last line (no trailing newline)
+    let trimmed = line.trim_end_matches('\r');
+    if trimmed == delim {
+      let mut tk = self.get_token(start..line_start, TkRule::Redir);
+      tk.flags |= TkFlags::IS_HEREDOC | flags;
+      self.heredoc_skip = Some(pos);
+      self.cursor = cursor_after_delim;
+      return Ok(Some(tk));
+    }
+
+    if !self.flags.contains(LexFlags::LEX_UNFINISHED) {
+      Err(ShErr::at(
+        ShErrKind::ParseErr,
+        Span::new(start..pos, self.source.clone()),
+        format!("Heredoc delimiter '{}' not found", delim),
+      ))
+    } else {
+      Ok(None)
+    }
+  }
   pub fn read_string(&mut self) -> ShResult<Tk> {
     assert!(self.cursor <= self.source.len());
     let slice = self.slice_from_cursor().unwrap().to_string();
@@ -625,6 +876,16 @@ impl LexStream {
             ));
           }
         }
+        '(' if can_be_subshell && chars.peek() == Some(&')') => {
+          // standalone "()" — function definition marker
+          pos += 2;
+          chars.next();
+          let mut tk = self.get_token(self.cursor..pos, TkRule::Str);
+          tk.mark(TkFlags::KEYWORD);
+          self.cursor = pos;
+          self.set_next_is_cmd(true);
+          return Ok(tk);
+        }
         '(' if self.next_is_cmd() && can_be_subshell => {
           pos += 1;
           let mut paren_count = 1;
@@ -845,10 +1106,19 @@ impl Iterator for LexStream {
 
     let token = match get_char(&self.source, self.cursor).unwrap() {
       '\r' | '\n' | ';' => {
+        let ch = get_char(&self.source, self.cursor).unwrap();
         let ch_idx = self.cursor;
         self.cursor += 1;
         self.set_next_is_cmd(true);
 
+        // If a heredoc was parsed on this line, skip past the body
+        // Only on newline — ';' is a command separator within the same line
+        if (ch == '\n' || ch == '\r')
+          && let Some(skip) = self.heredoc_skip.take()
+        {
+          self.cursor = skip;
+        }
+
         while let Some(ch) = get_char(&self.source, self.cursor) {
           match ch {
             '\\' if get_char(&self.source, self.cursor + 1) == Some('\n') => {
@@ -883,14 +1153,14 @@ impl Iterator for LexStream {
           return self.next();
         }
       }
-			'!' if self.next_is_cmd() => {
-				self.cursor += 1;
-				let tk_type = TkRule::Bang;
+      '!' if self.next_is_cmd() => {
+        self.cursor += 1;
+        let tk_type = TkRule::Bang;
 
-				let mut tk = self.get_token((self.cursor - 1)..self.cursor, tk_type);
-				tk.flags |= TkFlags::KEYWORD;
-				tk
-			}
+        let mut tk = self.get_token((self.cursor - 1)..self.cursor, tk_type);
+        tk.flags |= TkFlags::KEYWORD;
+        tk
+      }
       '|' => {
         let ch_idx = self.cursor;
         self.cursor += 1;

src/prelude.rs

@@ -19,7 +19,7 @@ pub use std::os::unix::io::{AsRawFd, BorrowedFd, FromRawFd, IntoRawFd, OwnedFd,
 pub use bitflags::bitflags;
 pub use nix::{
   errno::Errno,
-  fcntl::{OFlag, open},
+  fcntl::{FcntlArg, OFlag, fcntl, open},
   libc::{self, STDERR_FILENO, STDIN_FILENO, STDOUT_FILENO},
   sys::{
     signal::{self, SigHandler, SigSet, SigmaskHow, Signal, kill, killpg, pthread_sigmask, signal},
@@ -33,5 +33,4 @@ pub use nix::{
   },
 };
 
-
 // Additional utilities, if needed, can be added here

src/procio.rs

@@ -8,15 +8,27 @@ use crate::{
   expand::Expander,
   libsh::{
     error::{ShErr, ShErrKind, ShResult},
+    sys::TTY_FILENO,
     utils::RedirVecUtils,
   },
-  parse::{Redir, RedirType, get_redir_file},
+  parse::{Redir, RedirType, get_redir_file, lex::TkFlags},
   prelude::*,
+  state,
 };
 
 // Credit to fish-shell for many of the implementation ideas present in this
 // module https://fishshell.com/
 
+/// Minimum fd number for shell-internal file descriptors.
+/// User-visible fds (0-9) are kept clear so `exec 3>&-` etc. work as expected.
+const MIN_INTERNAL_FD: RawFd = 10;
+
+/// Like `dup()`, but places the new fd at `MIN_INTERNAL_FD` or above so it
+/// doesn't collide with user-managed fds.
+fn dup_high(fd: RawFd) -> nix::Result<RawFd> {
+  fcntl(fd, FcntlArg::F_DUPFD_CLOEXEC(MIN_INTERNAL_FD))
+}
+
 #[derive(Clone, Debug)]
 pub enum IoMode {
   Fd {
@@ -37,8 +49,9 @@ pub enum IoMode {
     pipe: Arc<OwnedFd>,
   },
   Buffer {
+    tgt_fd: RawFd,
     buf: String,
-    pipe: Arc<OwnedFd>,
+    flags: TkFlags, // so we can see if its a heredoc or not
   },
   Close {
     tgt_fd: RawFd,
@@ -79,19 +92,34 @@ impl IoMode {
     if let IoMode::File { tgt_fd, path, mode } = self {
       let path_raw = path.as_os_str().to_str().unwrap_or_default().to_string();
 
-      let expanded_path = Expander::from_raw(&path_raw)?.expand()?.join(" "); // should just be one string, will have to find some way to handle a return of
-      // multiple
+      let expanded_path = Expander::from_raw(&path_raw, TkFlags::empty())?
+        .expand()?
+        .join(" "); // should just be one string, will have to find some way to handle a return of multiple paths
 
       let expanded_pathbuf = PathBuf::from(expanded_path);
 
       let file = get_redir_file(mode, expanded_pathbuf)?;
+      // Move the opened fd above the user-accessible range so it never
+      // collides with the target fd (e.g. `3>/tmp/foo` where open() returns 3,
+      // causing dup2(3,3) to be a no-op and then OwnedFd drop closes it).
+      let raw = file.as_raw_fd();
+      let high = fcntl(raw, FcntlArg::F_DUPFD_CLOEXEC(MIN_INTERNAL_FD)).map_err(ShErr::from)?;
+      drop(file); // closes the original low fd
       self = IoMode::OpenedFile {
         tgt_fd,
-        file: Arc::new(OwnedFd::from(file)),
+        file: Arc::new(unsafe { OwnedFd::from_raw_fd(high) }),
       }
     }
     Ok(self)
   }
+  pub fn buffer(tgt_fd: RawFd, buf: String, flags: TkFlags) -> ShResult<Self> {
+    Ok(Self::Buffer { tgt_fd, buf, flags })
+  }
+	pub fn loaded_pipe(tgt_fd: RawFd, buf: &[u8]) -> ShResult<Self> {
+		let (rpipe, wpipe) = nix::unistd::pipe()?;
+		write(wpipe, buf)?;
+		Ok(Self::Pipe { tgt_fd, pipe: rpipe.into() })
+	}
   pub fn get_pipes() -> (Self, Self) {
     let (rpipe, wpipe) = nix::unistd::pipe2(OFlag::O_CLOEXEC).unwrap();
     (
@@ -206,24 +234,107 @@ impl<'e> IoFrame {
     )
   }
   pub fn save(&'e mut self) {
-    let saved_in = dup(STDIN_FILENO).unwrap();
-    let saved_out = dup(STDOUT_FILENO).unwrap();
-    let saved_err = dup(STDERR_FILENO).unwrap();
+    let saved_in = dup_high(STDIN_FILENO).unwrap();
+    let saved_out = dup_high(STDOUT_FILENO).unwrap();
+    let saved_err = dup_high(STDERR_FILENO).unwrap();
     self.saved_io = Some(IoGroup(saved_in, saved_out, saved_err));
   }
   pub fn redirect(mut self) -> ShResult<RedirGuard> {
     self.save();
-    for redir in &mut self.redirs {
-      let io_mode = &mut redir.io_mode;
-      if let IoMode::File { .. } = io_mode {
-        *io_mode = io_mode.clone().open_file()?;
-      };
-      let tgt_fd = io_mode.tgt_fd();
-      let src_fd = io_mode.src_fd();
-      dup2(src_fd, tgt_fd)?;
+    if let Err(e) = self.apply_redirs() {
+      // Restore saved fds before propagating the error so they don't leak.
+      self.restore().ok();
+      return Err(e);
     }
     Ok(RedirGuard::new(self))
   }
+  fn apply_redirs(&mut self) -> ShResult<()> {
+    for redir in &mut self.redirs {
+      let io_mode = &mut redir.io_mode;
+      match io_mode {
+        IoMode::Close { tgt_fd } => {
+          if *tgt_fd == *TTY_FILENO {
+            // Don't let user close the shell's tty fd.
+            continue;
+          }
+          close(*tgt_fd).ok();
+          continue;
+        }
+        IoMode::File { .. } => match io_mode.clone().open_file() {
+          Ok(file) => *io_mode = file,
+          Err(e) => {
+            if let Some(span) = redir.span.as_ref() {
+              return Err(e.promote(span.clone()));
+            }
+            return Err(e);
+          }
+        },
+        IoMode::Buffer { tgt_fd, buf, flags } => {
+          let (rpipe, wpipe) = nix::unistd::pipe()?;
+          let mut text = if flags.contains(TkFlags::LIT_HEREDOC) {
+            buf.clone()
+          } else {
+            let words = Expander::from_raw(buf, *flags)?.expand()?;
+            if flags.contains(TkFlags::IS_HEREDOC) {
+              words.into_iter().next().unwrap_or_default()
+            } else {
+              let ifs = state::get_separator();
+              words.join(&ifs).trim().to_string() + "\n"
+            }
+          };
+          if flags.contains(TkFlags::TAB_HEREDOC) {
+            let lines = text.lines();
+            let mut min_tabs = usize::MAX;
+            for line in lines {
+              if line.is_empty() {
+                continue;
+              }
+              let line_len = line.len();
+              let after_strip = line.trim_start_matches('\t').len();
+              let delta = line_len - after_strip;
+              min_tabs = min_tabs.min(delta);
+            }
+            if min_tabs == usize::MAX {
+              // let's avoid possibly allocating a string with 18 quintillion tabs
+              min_tabs = 0;
+            }
+
+            if min_tabs > 0 {
+              let stripped = text
+                .lines()
+                .fold(vec![], |mut acc, ln| {
+                  if ln.is_empty() {
+                    acc.push("");
+                    return acc;
+                  }
+                  let stripped_ln = ln.strip_prefix(&"\t".repeat(min_tabs)).unwrap();
+                  acc.push(stripped_ln);
+                  acc
+                })
+                .join("\n");
+              text = stripped + "\n";
+            }
+          }
+          write(wpipe, text.as_bytes())?;
+          *io_mode = IoMode::Pipe {
+            tgt_fd: *tgt_fd,
+            pipe: rpipe.into(),
+          };
+        }
+        _ => {}
+      }
+      let tgt_fd = io_mode.tgt_fd();
+      let src_fd = io_mode.src_fd();
+      if let Err(e) = dup2(src_fd, tgt_fd) {
+        if let Some(span) = redir.span.as_ref() {
+          return Err(ShErr::from(e).promote(span.clone()));
+        } else {
+          return Err(e.into());
+        }
+      }
+    }
+    Ok(())
+  }
   pub fn restore(&mut self) -> ShResult<()> {
     if let Some(saved) = self.saved_io.take() {
       dup2(saved.0, STDIN_FILENO)?;
@@ -334,6 +445,8 @@ pub fn borrow_fd<'f>(fd: i32) -> BorrowedFd<'f> {
 }
 
 type PipeFrames = Map<PipeGenerator, fn((Option<Redir>, Option<Redir>)) -> IoFrame>;
+
+/// An iterator that lazily creates a specific number of pipes.
 pub struct PipeGenerator {
   num_cmds: usize,
   cursor: usize,
@@ -389,154 +502,166 @@ impl Iterator for PipeGenerator {
 
 #[cfg(test)]
 pub mod tests {
-	use crate::testutil::{TestGuard, has_cmd, has_cmds, test_input};
-	use pretty_assertions::assert_eq;
+  use crate::testutil::{TestGuard, has_cmd, has_cmds, test_input};
+  use pretty_assertions::assert_eq;
 
-	#[test]
-	fn pipeline_simple() {
-		if !has_cmd("sed") { return };
-		let g = TestGuard::new();
+  #[test]
+  fn pipeline_simple() {
+    if !has_cmd("sed") {
+      return;
+    };
+    let g = TestGuard::new();
 
-		test_input("echo foo | sed 's/foo/bar/'").unwrap();
+    test_input("echo foo | sed 's/foo/bar/'").unwrap();
 
-		let out = g.read_output();
-		assert_eq!(out, "bar\n");
-	}
+    let out = g.read_output();
+    assert_eq!(out, "bar\n");
+  }
 
-	#[test]
-	fn pipeline_multi() {
-		if !has_cmds(&[
-			"cut",
-			"sed"
-		]) { return; }
-		let g = TestGuard::new();
+  #[test]
+  fn pipeline_multi() {
+    if !has_cmds(&["cut", "sed"]) {
+      return;
+    }
+    let g = TestGuard::new();
 
-		test_input("echo foo bar baz | cut -d ' ' -f 2 | sed 's/a/A/'").unwrap();
+    test_input("echo foo bar baz | cut -d ' ' -f 2 | sed 's/a/A/'").unwrap();
 
-		let out = g.read_output();
-		assert_eq!(out, "bAr\n");
-	}
+    let out = g.read_output();
+    assert_eq!(out, "bAr\n");
+  }
 
-	#[test]
-	fn rube_goldberg_pipeline() {
-		if !has_cmds(&[
-			"sed",
-			"cat",
-		]) { return }
-		let g = TestGuard::new();
+  #[test]
+  fn rube_goldberg_pipeline() {
+    if !has_cmds(&["sed", "cat"]) {
+      return;
+    }
+    let g = TestGuard::new();
 
-		test_input("{ echo foo; echo bar } | if cat; then :; else echo failed; fi | (read line && echo $line | sed 's/foo/baz/'; sed 's/bar/buzz/')").unwrap();
+    test_input("{ echo foo; echo bar } | if cat; then :; else echo failed; fi | (read line && echo $line | sed 's/foo/baz/'; sed 's/bar/buzz/')").unwrap();
 
-		let out = g.read_output();
-		assert_eq!(out, "baz\nbuzz\n");
-	}
+    let out = g.read_output();
+    assert_eq!(out, "baz\nbuzz\n");
+  }
 
-	#[test]
-	fn simple_file_redir() {
-		let mut g = TestGuard::new();
+  #[test]
+  fn simple_file_redir() {
+    let mut g = TestGuard::new();
 
-		test_input("echo this is in a file > /tmp/simple_file_redir.txt").unwrap();
+    test_input("echo this is in a file > /tmp/simple_file_redir.txt").unwrap();
 
-		g.add_cleanup(|| { std::fs::remove_file("/tmp/simple_file_redir.txt").ok(); });
-		let contents = std::fs::read_to_string("/tmp/simple_file_redir.txt").unwrap();
+    g.add_cleanup(|| {
+      std::fs::remove_file("/tmp/simple_file_redir.txt").ok();
+    });
+    let contents = std::fs::read_to_string("/tmp/simple_file_redir.txt").unwrap();
 
-		assert_eq!(contents, "this is in a file\n");
-	}
+    assert_eq!(contents, "this is in a file\n");
+  }
 
-	#[test]
-	fn append_file_redir() {
-		let dir = tempfile::TempDir::new().unwrap();
-		let path = dir.path().join("append.txt");
-		let _g = TestGuard::new();
+  #[test]
+  fn append_file_redir() {
+    let dir = tempfile::TempDir::new().unwrap();
+    let path = dir.path().join("append.txt");
+    let _g = TestGuard::new();
 
-		test_input(format!("echo first > {}", path.display())).unwrap();
-		test_input(format!("echo second >> {}", path.display())).unwrap();
+    test_input(format!("echo first > {}", path.display())).unwrap();
+    test_input(format!("echo second >> {}", path.display())).unwrap();
 
-		let contents = std::fs::read_to_string(&path).unwrap();
-		assert_eq!(contents, "first\nsecond\n");
-	}
+    let contents = std::fs::read_to_string(&path).unwrap();
+    assert_eq!(contents, "first\nsecond\n");
+  }
 
-	#[test]
-	fn input_redir() {
-		if !has_cmd("cat") { return; }
-		let dir = tempfile::TempDir::new().unwrap();
-		let path = dir.path().join("input.txt");
-		std::fs::write(&path, "hello from file\n").unwrap();
-		let g = TestGuard::new();
+  #[test]
+  fn input_redir() {
+    if !has_cmd("cat") {
+      return;
+    }
+    let dir = tempfile::TempDir::new().unwrap();
+    let path = dir.path().join("input.txt");
+    std::fs::write(&path, "hello from file\n").unwrap();
+    let g = TestGuard::new();
 
-		test_input(format!("cat < {}", path.display())).unwrap();
+    test_input(format!("cat < {}", path.display())).unwrap();
 
-		let out = g.read_output();
-		assert_eq!(out, "hello from file\n");
-	}
+    let out = g.read_output();
+    assert_eq!(out, "hello from file\n");
+  }
 
-	#[test]
-	fn stderr_redir_to_file() {
-		let dir = tempfile::TempDir::new().unwrap();
-		let path = dir.path().join("err.txt");
-		let g = TestGuard::new();
+  #[test]
+  fn stderr_redir_to_file() {
+    let dir = tempfile::TempDir::new().unwrap();
+    let path = dir.path().join("err.txt");
+    let g = TestGuard::new();
 
-		test_input(format!("echo error msg 2> {} >&2", path.display())).unwrap();
+    test_input(format!("echo error msg 2> {} >&2", path.display())).unwrap();
 
-		let contents = std::fs::read_to_string(&path).unwrap();
-		assert_eq!(contents, "error msg\n");
-		// stdout should be empty since we redirected to stderr
-		let out = g.read_output();
-		assert_eq!(out, "");
-	}
+    let contents = std::fs::read_to_string(&path).unwrap();
+    assert_eq!(contents, "error msg\n");
+    // stdout should be empty since we redirected to stderr
+    let out = g.read_output();
+    assert_eq!(out, "");
+  }
 
-	#[test]
-	fn pipe_and_stderr() {
-		if !has_cmd("cat") { return; }
-		let g = TestGuard::new();
+  #[test]
+  fn pipe_and_stderr() {
+    if !has_cmd("cat") {
+      return;
+    }
+    let g = TestGuard::new();
 
-		test_input("echo on stderr >&2 |& cat").unwrap();
+    test_input("echo on stderr >&2 |& cat").unwrap();
 
-		let out = g.read_output();
-		assert_eq!(out, "on stderr\n");
-	}
+    let out = g.read_output();
+    assert_eq!(out, "on stderr\n");
+  }
 
-	#[test]
-	fn output_redir_clobber() {
-		let dir = tempfile::TempDir::new().unwrap();
-		let path = dir.path().join("clobber.txt");
-		let _g = TestGuard::new();
+  #[test]
+  fn output_redir_clobber() {
+    let dir = tempfile::TempDir::new().unwrap();
+    let path = dir.path().join("clobber.txt");
+    let _g = TestGuard::new();
 
-		test_input(format!("echo first > {}", path.display())).unwrap();
-		test_input(format!("echo second > {}", path.display())).unwrap();
+    test_input(format!("echo first > {}", path.display())).unwrap();
+    test_input(format!("echo second > {}", path.display())).unwrap();
 
-		let contents = std::fs::read_to_string(&path).unwrap();
-		assert_eq!(contents, "second\n");
-	}
+    let contents = std::fs::read_to_string(&path).unwrap();
+    assert_eq!(contents, "second\n");
+  }
 
-	#[test]
-	fn pipeline_preserves_exit_status() {
-		if !has_cmd("cat") { return; }
-		let _g = TestGuard::new();
+  #[test]
+  fn pipeline_preserves_exit_status() {
+    if !has_cmd("cat") {
+      return;
+    }
+    let _g = TestGuard::new();
 
-		test_input("false | cat").unwrap();
+    test_input("false | cat").unwrap();
 
-		// Pipeline exit status is the last command
-		let status = crate::state::get_status();
-		assert_eq!(status, 0);
+    // Pipeline exit status is the last command
+    let status = crate::state::get_status();
+    assert_eq!(status, 0);
 
-		test_input("cat < /dev/null | false").unwrap();
+    test_input("cat < /dev/null | false").unwrap();
 
-		let status = crate::state::get_status();
-		assert_ne!(status, 0);
-	}
+    let status = crate::state::get_status();
+    assert_ne!(status, 0);
+  }
 
-	#[test]
-	fn fd_duplication() {
-		let dir = tempfile::TempDir::new().unwrap();
-		let path = dir.path().join("dup.txt");
-		let _g = TestGuard::new();
+  #[test]
+  fn fd_duplication() {
+    let dir = tempfile::TempDir::new().unwrap();
+    let path = dir.path().join("dup.txt");
+    let _g = TestGuard::new();
 
-		// Redirect stdout to file, then dup stderr to stdout — both should go to file
-		test_input(format!("{{ echo out; echo err >&2 }} > {} 2>&1", path.display())).unwrap();
+    // Redirect stdout to file, then dup stderr to stdout — both should go to file
+    test_input(format!(
+      "{{ echo out; echo err >&2 }} > {} 2>&1",
+      path.display()
+    ))
+    .unwrap();
 
-		let contents = std::fs::read_to_string(&path).unwrap();
-		assert!(contents.contains("out"));
-		assert!(contents.contains("err"));
-	}
+    let contents = std::fs::read_to_string(&path).unwrap();
+    assert!(contents.contains("out"));
+    assert!(contents.contains("err"));
+  }
 }

src/readline/complete.rs

@@ -6,9 +6,11 @@ use std::{
 };
 
 use nix::sys::signal::Signal;
+use unicode_width::UnicodeWidthStr;
 
 use crate::{
   builtin::complete::{CompFlags, CompOptFlags, CompOpts},
+  expand::escape_str,
   libsh::{error::ShResult, guards::var_ctx_guard, sys::TTY_FILENO, utils::TkVecUtils},
   parse::{
     execute::exec_input,
@@ -22,7 +24,9 @@ use crate::{
     term::{LineWriter, TermWriter, calc_str_width, get_win_size},
     vimode::{ViInsert, ViMode},
   },
-  state::{VarFlags, VarKind, read_jobs, read_logic, read_meta, read_vars, write_vars},
+  state::{
+    VarFlags, VarKind, read_jobs, read_logic, read_meta, read_shopts, read_vars, write_vars,
+  },
 };
 
 pub fn complete_signals(start: &str) -> Vec<String> {
@@ -173,6 +177,11 @@ fn complete_commands(start: &str) -> Vec<String> {
       .collect()
   });
 
+  if read_shopts(|o| o.core.autocd) {
+    let dirs = complete_dirs(start);
+    candidates.extend(dirs);
+  }
+
   candidates.sort();
   candidates
 }
@@ -559,15 +568,17 @@ pub trait Completer {
   fn reset(&mut self);
   fn reset_stay_active(&mut self);
   fn is_active(&self) -> bool;
-	fn all_candidates(&self) -> Vec<String> { vec![] }
+  fn all_candidates(&self) -> Vec<String> {
+    vec![]
+  }
   fn selected_candidate(&self) -> Option<String>;
   fn token_span(&self) -> (usize, usize);
   fn original_input(&self) -> &str;
-	fn token(&self) -> &str {
-		let orig = self.original_input();
-		let (s,e) = self.token_span();
-		orig.get(s..e).unwrap_or(orig)
-	}
+  fn token(&self) -> &str {
+    let orig = self.original_input();
+    let (s, e) = self.token_span();
+    orig.get(s..e).unwrap_or(orig)
+  }
   fn draw(&mut self, writer: &mut TermWriter) -> ShResult<()>;
   fn clear(&mut self, _writer: &mut TermWriter) -> ShResult<()> {
     Ok(())
@@ -728,7 +739,7 @@ impl QueryEditor {
   }
 }
 
-#[derive(Clone, Debug)]
+#[derive(Clone, Default, Debug)]
 pub struct FuzzySelector {
   query: QueryEditor,
   filtered: Vec<ScoredCandidate>,
@@ -787,21 +798,21 @@ impl FuzzySelector {
     }
   }
 
-	pub fn candidates(&self) -> &[String] {
-		&self.candidates
-	}
+  pub fn candidates(&self) -> &[String] {
+    &self.candidates
+  }
 
-	pub fn filtered(&self) -> &[ScoredCandidate] {
-		&self.filtered
-	}
+  pub fn filtered(&self) -> &[ScoredCandidate] {
+    &self.filtered
+  }
 
-	pub fn filtered_len(&self) -> usize {
-		self.filtered.len()
-	}
+  pub fn filtered_len(&self) -> usize {
+    self.filtered.len()
+  }
 
-	pub fn candidates_len(&self) -> usize {
-		self.candidates.len()
-	}
+  pub fn candidates_len(&self) -> usize {
+    self.candidates.len()
+  }
 
   pub fn activate(&mut self, candidates: Vec<String>) {
     self.active = true;
@@ -1156,9 +1167,9 @@ impl Default for FuzzyCompleter {
 }
 
 impl Completer for FuzzyCompleter {
-	fn all_candidates(&self) -> Vec<String> {
-		self.selector.candidates.clone()
-	}
+  fn all_candidates(&self) -> Vec<String> {
+    self.selector.candidates.clone()
+  }
   fn set_prompt_line_context(&mut self, line_width: u16, cursor_col: u16) {
     self
       .selector
@@ -1171,13 +1182,19 @@ impl Completer for FuzzyCompleter {
     log::debug!("Getting completed line for candidate: {}", _candidate);
 
     let selected = self.selector.selected_candidate().unwrap_or_default();
-    log::debug!("Selected candidate: {}", selected);
-    let (start, end) = self.completer.token_span;
-    log::debug!("Token span: ({}, {})", start, end);
+    let (mut start, end) = self.completer.token_span;
+    let slice = self
+      .completer
+      .original_input
+      .get(start..end)
+      .unwrap_or_default();
+    start += slice.width();
+    let completion = selected.strip_prefix(slice).unwrap_or(&selected);
+    let escaped = escape_str(completion, false);
     let ret = format!(
       "{}{}{}",
       &self.completer.original_input[..start],
-      selected,
+      escaped,
       &self.completer.original_input[end..]
     );
     log::debug!("Completed line: {}", ret);
@@ -1249,9 +1266,9 @@ pub struct SimpleCompleter {
 }
 
 impl Completer for SimpleCompleter {
-	fn all_candidates(&self) -> Vec<String> {
-	  self.candidates.clone()
-	}
+  fn all_candidates(&self) -> Vec<String> {
+    self.candidates.clone()
+  }
   fn reset_stay_active(&mut self) {
     let active = self.is_active();
     self.reset();
@@ -1430,11 +1447,15 @@ impl SimpleCompleter {
     }
 
     let selected = &self.candidates[self.selected_idx];
-    let (start, end) = self.token_span;
+    let (mut start, end) = self.token_span;
+    let slice = self.original_input.get(start..end).unwrap_or("");
+    start += slice.width();
+    let completion = selected.strip_prefix(slice).unwrap_or(selected);
+    let escaped = escape_str(completion, false);
     format!(
       "{}{}{}",
       &self.original_input[..start],
-      selected,
+      escaped,
       &self.original_input[end..]
     )
   }
@@ -1593,10 +1614,12 @@ impl SimpleCompleter {
         .set_range(self.token_span.0..self.token_span.1);
     }
 
-    // If token contains '=', only complete after the '='
+    // If token contains any COMP_WORDBREAKS, break the word
     let token_str = cur_token.span.as_str();
-    if let Some(eq_pos) = token_str.rfind('=') {
-      self.token_span.0 = cur_token.span.range().start + eq_pos + 1;
+
+    let word_breaks = read_vars(|v| v.try_get_var("COMP_WORDBREAKS")).unwrap_or("=".into());
+    if let Some(break_pos) = token_str.rfind(|c: char| word_breaks.contains(c)) {
+      self.token_span.0 = cur_token.span.range().start + break_pos + 1;
       cur_token
         .span
         .set_range(self.token_span.0..self.token_span.1);
@@ -1642,3 +1665,462 @@ impl SimpleCompleter {
     Ok(CompResult::from_candidates(candidates))
   }
 }
+
+#[cfg(test)]
+mod tests {
+  use super::*;
+  use crate::{
+    readline::{Prompt, ShedVi},
+    state::{VarFlags, VarKind, write_vars},
+    testutil::TestGuard,
+  };
+  use std::os::fd::AsRawFd;
+
+  fn test_vi(initial: &str) -> (ShedVi, TestGuard) {
+    let g = TestGuard::new();
+    let prompt = Prompt::default();
+    let vi = ShedVi::new_no_hist(prompt, g.pty_slave().as_raw_fd())
+      .unwrap()
+      .with_initial(initial);
+    (vi, g)
+  }
+
+  // ===================== extract_var_name =====================
+
+  #[test]
+  fn extract_var_simple() {
+    let (name, start, end) = extract_var_name("$HOME").unwrap();
+    assert_eq!(name, "HOME");
+    assert_eq!(start, 1);
+    assert_eq!(end, 5);
+  }
+
+  #[test]
+  fn extract_var_braced() {
+    let (name, start, end) = extract_var_name("${PATH}").unwrap();
+    assert_eq!(name, "PATH");
+    // '$' hits continue (no pos++), '{' is at pos=0, so name_start = 1
+    assert_eq!(start, 1);
+    assert_eq!(end, 5);
+  }
+
+  #[test]
+  fn extract_var_partial() {
+    let (name, start, _end) = extract_var_name("$HO").unwrap();
+    assert_eq!(name, "HO");
+    assert_eq!(start, 1);
+  }
+
+  #[test]
+  fn extract_var_none() {
+    assert!(extract_var_name("hello").is_none());
+  }
+
+  // ===================== ScoredCandidate::fuzzy_score =====================
+
+  #[test]
+  fn fuzzy_exact_match() {
+    let mut c = ScoredCandidate::new("hello".into());
+    let score = c.fuzzy_score("hello");
+    assert!(score > 0);
+  }
+
+  #[test]
+  fn fuzzy_prefix_match() {
+    let mut c = ScoredCandidate::new("hello_world".into());
+    let score = c.fuzzy_score("hello");
+    assert!(score > 0);
+  }
+
+  #[test]
+  fn fuzzy_no_match() {
+    let mut c = ScoredCandidate::new("abc".into());
+    let score = c.fuzzy_score("xyz");
+    assert_eq!(score, i32::MIN);
+  }
+
+  #[test]
+  fn fuzzy_empty_query() {
+    let mut c = ScoredCandidate::new("anything".into());
+    let score = c.fuzzy_score("");
+    assert_eq!(score, 0);
+  }
+
+  #[test]
+  fn fuzzy_boundary_bonus() {
+    let mut a = ScoredCandidate::new("foo_bar".into());
+    let mut b = ScoredCandidate::new("fxxxbxr".into());
+    let score_a = a.fuzzy_score("fbr");
+    let score_b = b.fuzzy_score("fbr");
+    // word-boundary match should score higher
+    assert!(score_a > score_b);
+  }
+
+  // ===================== CompResult::from_candidates =====================
+
+  #[test]
+  fn comp_result_no_match() {
+    let result = CompResult::from_candidates(vec![]);
+    assert!(matches!(result, CompResult::NoMatch));
+  }
+
+  #[test]
+  fn comp_result_single() {
+    let result = CompResult::from_candidates(vec!["foo".into()]);
+    assert!(matches!(result, CompResult::Single { .. }));
+  }
+
+  #[test]
+  fn comp_result_many() {
+    let result = CompResult::from_candidates(vec!["foo".into(), "bar".into()]);
+    assert!(matches!(result, CompResult::Many { .. }));
+  }
+
+  // ===================== complete_signals =====================
+
+  #[test]
+  fn complete_signals_int() {
+    let results = complete_signals("INT");
+    assert!(results.contains(&"INT".to_string()));
+  }
+
+  #[test]
+  fn complete_signals_empty() {
+    let results = complete_signals("");
+    assert!(!results.is_empty());
+  }
+
+  #[test]
+  fn complete_signals_no_match() {
+    let results = complete_signals("ZZZZZZZ");
+    assert!(results.is_empty());
+  }
+
+  // ===================== COMP_WORDBREAKS =====================
+
+  #[test]
+  fn wordbreak_equals_default() {
+    let _g = TestGuard::new();
+    let mut comp = SimpleCompleter::new();
+
+    let line = "cmd --foo=bar".to_string();
+    let cursor = line.len();
+    let _ = comp.get_candidates(line.clone(), cursor);
+
+    let eq_idx = line.find('=').unwrap();
+    assert_eq!(
+      comp.token_span.0,
+      eq_idx + 1,
+      "token_span.0 ({}) should be right after '=' ({})",
+      comp.token_span.0,
+      eq_idx
+    );
+  }
+
+  #[test]
+  fn wordbreak_colon_when_set() {
+    let _g = TestGuard::new();
+    write_vars(|v| v.set_var("COMP_WORDBREAKS", VarKind::Str("=:".into()), VarFlags::NONE))
+      .unwrap();
+
+    let mut comp = SimpleCompleter::new();
+    let line = "scp host:foo".to_string();
+    let cursor = line.len();
+    let _ = comp.get_candidates(line.clone(), cursor);
+
+    let colon_idx = line.find(':').unwrap();
+    assert_eq!(
+      comp.token_span.0,
+      colon_idx + 1,
+      "token_span.0 ({}) should be right after ':' ({})",
+      comp.token_span.0,
+      colon_idx
+    );
+  }
+
+  #[test]
+  fn wordbreak_rightmost_wins() {
+    let _g = TestGuard::new();
+    write_vars(|v| v.set_var("COMP_WORDBREAKS", VarKind::Str("=:".into()), VarFlags::NONE))
+      .unwrap();
+
+    let mut comp = SimpleCompleter::new();
+    let line = "cmd --opt=host:val".to_string();
+    let cursor = line.len();
+    let _ = comp.get_candidates(line.clone(), cursor);
+
+    let colon_idx = line.rfind(':').unwrap();
+    assert_eq!(
+      comp.token_span.0,
+      colon_idx + 1,
+      "should break at rightmost wordbreak char"
+    );
+  }
+
+  // ===================== SimpleCompleter cycling =====================
+
+  #[test]
+  fn cycle_wraps_forward() {
+    let _g = TestGuard::new();
+    let mut comp = SimpleCompleter {
+      candidates: vec!["aaa".into(), "bbb".into(), "ccc".into()],
+      selected_idx: 2,
+      original_input: "".into(),
+      token_span: (0, 0),
+      active: true,
+      dirs_only: false,
+      add_space: false,
+    };
+    comp.cycle_completion(1);
+    assert_eq!(comp.selected_idx, 0);
+  }
+
+  #[test]
+  fn cycle_wraps_backward() {
+    let _g = TestGuard::new();
+    let mut comp = SimpleCompleter {
+      candidates: vec!["aaa".into(), "bbb".into(), "ccc".into()],
+      selected_idx: 0,
+      original_input: "".into(),
+      token_span: (0, 0),
+      active: true,
+      dirs_only: false,
+      add_space: false,
+    };
+    comp.cycle_completion(-1);
+    assert_eq!(comp.selected_idx, 2);
+  }
+
+  // ===================== Completion escaping =====================
+
+  #[test]
+  fn escape_str_special_chars() {
+    use crate::expand::escape_str;
+    let escaped = escape_str("hello world", false);
+    assert_eq!(escaped, "hello\\ world");
+  }
+
+  #[test]
+  fn escape_str_multiple_specials() {
+    use crate::expand::escape_str;
+    let escaped = escape_str("a&b|c", false);
+    assert_eq!(escaped, "a\\&b\\|c");
+  }
+
+  #[test]
+  fn escape_str_no_specials() {
+    use crate::expand::escape_str;
+    let escaped = escape_str("hello", false);
+    assert_eq!(escaped, "hello");
+  }
+
+  #[test]
+  fn escape_str_all_shell_metacharacters() {
+    use crate::expand::escape_str;
+    for ch in [
+      '\'', '"', '\\', '|', '&', ';', '(', ')', '<', '>', '$', '*', '!', '`', '{', '?', '[', '#',
+      ' ', '\t', '\n',
+    ] {
+      let input = format!("a{ch}b");
+      let escaped = escape_str(&input, false);
+      let expected = format!("a\\{ch}b");
+      assert_eq!(escaped, expected, "failed to escape {:?}", ch);
+    }
+  }
+
+  #[test]
+  fn escape_str_kitchen_sink() {
+    use crate::expand::escape_str;
+    let input = "f$le (with) 'spaces' & {braces} | pipes; #hash ~tilde `backtick` !bang";
+    let escaped = escape_str(input, false);
+    assert_eq!(
+      escaped,
+      "f\\$le\\ \\(with\\)\\ \\'spaces\\'\\ \\&\\ \\{braces}\\ \\|\\ pipes\\;\\ \\#hash\\ ~tilde\\ \\`backtick\\`\\ \\!bang"
+    );
+  }
+
+  #[test]
+  fn completed_line_only_escapes_new_text() {
+    let _g = TestGuard::new();
+    // Simulate: user typed "echo hel", completion candidate is "hello world"
+    let comp = SimpleCompleter {
+      candidates: vec!["hello world".into()],
+      selected_idx: 0,
+      original_input: "echo hel".into(),
+      token_span: (5, 8), // "hel" spans bytes 5..8
+      active: true,
+      dirs_only: false,
+      add_space: false,
+    };
+    let result = comp.get_completed_line();
+    // "hel" is the user's text (not escaped), "lo world" is new (escaped)
+    assert_eq!(result, "echo hello\\ world");
+  }
+
+  #[test]
+  fn completed_line_no_new_text() {
+    let _g = TestGuard::new();
+    // User typed the full token, nothing new to escape
+    let comp = SimpleCompleter {
+      candidates: vec!["hello".into()],
+      selected_idx: 0,
+      original_input: "echo hello".into(),
+      token_span: (5, 10),
+      active: true,
+      dirs_only: false,
+      add_space: false,
+    };
+    let result = comp.get_completed_line();
+    assert_eq!(result, "echo hello");
+  }
+
+  #[test]
+  fn completed_line_appends_suffix_with_escape() {
+    let _g = TestGuard::new();
+    // User typed "echo hel", candidate is "hello world" (from filesystem)
+    // strip_prefix("hel") => "lo world", which gets escaped
+    let comp = SimpleCompleter {
+      candidates: vec!["hello world".into()],
+      selected_idx: 0,
+      original_input: "echo hel".into(),
+      token_span: (5, 8),
+      active: true,
+      dirs_only: false,
+      add_space: false,
+    };
+    let result = comp.get_completed_line();
+    assert_eq!(result, "echo hello\\ world");
+  }
+
+  #[test]
+  fn completed_line_suffix_only_escapes_new_part() {
+    let _g = TestGuard::new();
+    // User typed "echo hello", candidate is "hello world&done"
+    // strip_prefix("hello") => " world&done", only that gets escaped
+    let comp = SimpleCompleter {
+      candidates: vec!["hello world&done".into()],
+      selected_idx: 0,
+      original_input: "echo hello".into(),
+      token_span: (5, 10),
+      active: true,
+      dirs_only: false,
+      add_space: false,
+    };
+    let result = comp.get_completed_line();
+    // "hello" is preserved as-is, " world&done" gets escaped
+    assert_eq!(result, "echo hello\\ world\\&done");
+  }
+
+  #[test]
+  fn tab_escapes_special_in_filename() {
+    let tmp = std::env::temp_dir().join("shed_test_tab_esc");
+    let _ = std::fs::create_dir_all(&tmp);
+    std::fs::write(tmp.join("hello world.txt"), "").unwrap();
+
+    let (mut vi, _g) = test_vi("");
+    std::env::set_current_dir(&tmp).unwrap();
+
+    vi.feed_bytes(b"echo hello\t");
+    let _ = vi.process_input();
+
+    let line = vi.editor.as_str().to_string();
+    assert!(
+      line.contains("hello\\ world.txt"),
+      "expected escaped space in completion: {line:?}"
+    );
+
+    std::fs::remove_dir_all(&tmp).ok();
+  }
+
+  #[test]
+  fn tab_does_not_escape_user_text() {
+    let tmp = std::env::temp_dir().join("shed_test_tab_noesc");
+    let _ = std::fs::create_dir_all(&tmp);
+    std::fs::write(tmp.join("my file.txt"), "").unwrap();
+
+    let (mut vi, _g) = test_vi("");
+    std::env::set_current_dir(&tmp).unwrap();
+
+    // User types "echo my\ " with the space already escaped
+    vi.feed_bytes(b"echo my\\ \t");
+    let _ = vi.process_input();
+
+    let line = vi.editor.as_str().to_string();
+    // The user's "my\ " should be preserved, not double-escaped to "my\\\ "
+    assert!(
+      !line.contains("my\\\\ "),
+      "user text should not be double-escaped: {line:?}"
+    );
+    assert!(
+      line.contains("my\\ file.txt"),
+      "expected completion with preserved user escape: {line:?}"
+    );
+
+    std::fs::remove_dir_all(&tmp).ok();
+  }
+
+  // ===================== Integration tests (pty) =====================
+
+  #[test]
+  fn tab_completes_filename() {
+    let tmp = std::env::temp_dir().join("shed_test_tab_fn");
+    let _ = std::fs::create_dir_all(&tmp);
+    std::fs::write(tmp.join("unique_shed_test_file.txt"), "").unwrap();
+
+    let (mut vi, _g) = test_vi("");
+    std::env::set_current_dir(&tmp).unwrap();
+
+    // Type "echo unique_shed_test" then press Tab
+    vi.feed_bytes(b"echo unique_shed_test\t");
+    let _ = vi.process_input();
+
+    let line = vi.editor.as_str().to_string();
+    assert!(
+      line.contains("unique_shed_test_file.txt"),
+      "expected completion in line: {line:?}"
+    );
+
+    std::fs::remove_dir_all(&tmp).ok();
+  }
+
+  #[test]
+  fn tab_completes_directory_with_slash() {
+    let tmp = std::env::temp_dir().join("shed_test_tab_dir");
+    let _ = std::fs::create_dir_all(tmp.join("mysubdir"));
+
+    let (mut vi, _g) = test_vi("");
+    std::env::set_current_dir(&tmp).unwrap();
+
+    vi.feed_bytes(b"cd mysub\t");
+    let _ = vi.process_input();
+
+    let line = vi.editor.as_str().to_string();
+    assert!(
+      line.contains("mysubdir/"),
+      "expected dir completion with trailing slash: {line:?}"
+    );
+
+    std::fs::remove_dir_all(&tmp).ok();
+  }
+
+  #[test]
+  fn tab_after_equals() {
+    let tmp = std::env::temp_dir().join("shed_test_tab_eq");
+    let _ = std::fs::create_dir_all(&tmp);
+    std::fs::write(tmp.join("eqfile.txt"), "").unwrap();
+
+    let (mut vi, _g) = test_vi("");
+    std::env::set_current_dir(&tmp).unwrap();
+
+    vi.feed_bytes(b"cmd --opt=eqf\t");
+    let _ = vi.process_input();
+
+    let line = vi.editor.as_str().to_string();
+    assert!(
+      line.contains("--opt=eqfile.txt"),
+      "expected completion after '=': {line:?}"
+    );
+
+    std::fs::remove_dir_all(&tmp).ok();
+  }
+}

src/readline/highlight.rs

@@ -88,7 +88,9 @@ impl Highlighter {
     while prefix_chars.peek().is_some() {
       match chars.next() {
         Some(c) if c == markers::VISUAL_MODE_START || c == markers::VISUAL_MODE_END => continue,
-        Some(c) if Some(&c) == prefix_chars.peek() => { prefix_chars.next(); }
+        Some(c) if Some(&c) == prefix_chars.peek() => {
+          prefix_chars.next();
+        }
         _ => return text.to_string(), // mismatch, return original
       }
     }
@@ -104,7 +106,9 @@ impl Highlighter {
     let mut si = suffix_chars.len();
 
     while si > 0 {
-      if ti == 0 { return text.to_string(); }
+      if ti == 0 {
+        return text.to_string();
+      }
       ti -= 1;
       if chars[ti] == markers::VISUAL_MODE_START || chars[ti] == markers::VISUAL_MODE_END {
         continue; // skip visual markers
@@ -346,7 +350,9 @@ impl Highlighter {
           recursive_highlighter.highlight();
           // Read back visual state — selection may have started/ended inside
           self.in_selection = recursive_highlighter.in_selection;
-          self.style_stack.append(&mut recursive_highlighter.style_stack);
+          self
+            .style_stack
+            .append(&mut recursive_highlighter.style_stack);
           if selection_at_entry {
             self.emit_style(Style::BgWhite | Style::Black);
             self.output.push_str(prefix);

src/readline/history.rs

@@ -203,6 +203,7 @@ fn dedupe_entries(entries: &[HistEntry]) -> Vec<HistEntry> {
     .collect()
 }
 
+#[derive(Default,Clone,Debug)]
 pub struct History {
   path: PathBuf,
   pub pending: Option<LineBuf>, // command, cursor_pos
@@ -214,6 +215,7 @@ pub struct History {
   //search_direction: Direction,
   ignore_dups: bool,
   max_size: Option<u32>,
+	stateless: bool
 }
 
 impl History {
@@ -229,6 +231,7 @@ impl History {
       //search_direction: Direction::Backward,
       ignore_dups: false,
       max_size: None,
+			stateless: true,
     }
   }
   pub fn new() -> ShResult<Self> {
@@ -266,6 +269,7 @@ impl History {
       //search_direction: Direction::Backward,
       ignore_dups,
       max_size,
+			stateless: false,
     })
   }
 
@@ -450,6 +454,9 @@ impl History {
   }
 
   pub fn save(&mut self) -> ShResult<()> {
+		if self.stateless {
+			return Ok(());
+		}
     let mut file = OpenOptions::new()
       .create(true)
       .append(true)
@@ -500,12 +507,8 @@ mod tests {
       env::set_var(key, val);
     }
     guard(prev, move |p| match p {
-      Some(v) => unsafe {
-        env::set_var(key, v)
-      },
-      None => unsafe {
-        env::remove_var(key)
-      },
+      Some(v) => unsafe { env::set_var(key, v) },
+      None => unsafe { env::remove_var(key) },
     })
   }
 
@@ -522,12 +525,7 @@ mod tests {
   fn write_history_file(path: &Path) {
     fs::write(
       path,
-      [
-        ": 1;1;first\n",
-        ": 2;1;second\n",
-        ": 3;1;third\n",
-      ]
-      .concat(),
+      [": 1;1;first\n", ": 2;1;second\n", ": 3;1;third\n"].concat(),
     )
     .unwrap();
   }
@@ -586,12 +584,7 @@ mod tests {
     let hist_path = tmp.path().join("history");
     fs::write(
       &hist_path,
-      [
-        ": 1;1;repeat\n",
-        ": 2;1;unique\n",
-        ": 3;1;repeat\n",
-      ]
-      .concat(),
+      [": 1;1;repeat\n", ": 2;1;unique\n", ": 3;1;repeat\n"].concat(),
     )
     .unwrap();
 

src/readline/mod.rs

@@ -9,14 +9,14 @@ use vimode::{CmdReplay, ModeReport, ViInsert, ViMode, ViNormal, ViReplace, ViVis
 
 use crate::builtin::keymap::{KeyMapFlags, KeyMapMatch};
 use crate::expand::expand_prompt;
-use crate::libsh::sys::TTY_FILENO;
 use crate::libsh::utils::AutoCmdVecUtils;
 use crate::parse::lex::{LexStream, QuoteState};
 use crate::readline::complete::{FuzzyCompleter, SelectorResponse};
 use crate::readline::term::{Pos, TermReader, calc_str_width};
 use crate::readline::vimode::{ViEx, ViVerbatim};
 use crate::state::{
-  AutoCmdKind, ShellParam, Var, VarFlags, VarKind, read_logic, read_shopts, with_vars, write_meta, write_vars
+  AutoCmdKind, ShellParam, Var, VarFlags, VarKind, read_logic, read_shopts, with_vars, write_meta,
+  write_vars,
 };
 use crate::{
   libsh::error::ShResult,
@@ -132,6 +132,18 @@ pub mod markers {
   pub fn is_marker(c: Marker) -> bool {
     ('\u{e000}'..'\u{efff}').contains(&c)
   }
+
+	// Help command formatting markers
+	pub const TAG: Marker = '\u{e180}';
+	pub const REFERENCE: Marker = '\u{e181}';
+	pub const HEADER: Marker = '\u{e182}';
+	pub const CODE: Marker = '\u{e183}';
+	/// angle brackets
+	pub const KEYWORD_1: Marker = '\u{e184}';
+	/// curly brackets
+	pub const KEYWORD_2: Marker = '\u{e185}';
+	/// square brackets
+	pub const KEYWORD_3: Marker = '\u{e186}';
 }
 type Marker = char;
 
@@ -241,6 +253,7 @@ impl Default for Prompt {
 pub struct ShedVi {
   pub reader: PollReader,
   pub writer: TermWriter,
+  pub tty: RawFd,
 
   pub prompt: Prompt,
   pub highlighter: Highlighter,
@@ -252,10 +265,10 @@ pub struct ShedVi {
   pub repeat_action: Option<CmdReplay>,
   pub repeat_motion: Option<MotionCmd>,
   pub editor: LineBuf,
-  pub next_is_escaped: bool,
 
   pub old_layout: Option<Layout>,
   pub history: History,
+	pub ex_history: History,
 
   pub needs_redraw: bool,
 }
@@ -266,10 +279,10 @@ impl ShedVi {
       reader: PollReader::new(),
       writer: TermWriter::new(tty),
       prompt,
+      tty,
       completer: Box::new(FuzzyCompleter::default()),
       highlighter: Highlighter::new(),
       mode: Box::new(ViInsert::new()),
-      next_is_escaped: false,
       saved_mode: None,
       pending_keymap: Vec::new(),
       old_layout: None,
@@ -277,6 +290,7 @@ impl ShedVi {
       repeat_motion: None,
       editor: LineBuf::new(),
       history: History::new()?,
+			ex_history: History::empty(),
       needs_redraw: true,
     };
     write_vars(|v| {
@@ -292,36 +306,37 @@ impl ShedVi {
     Ok(new)
   }
 
-	pub fn new_no_hist(prompt: Prompt, tty: RawFd) -> ShResult<Self> {
-		let mut new = Self {
-			reader: PollReader::new(),
-			writer: TermWriter::new(tty),
-			prompt,
-			completer: Box::new(FuzzyCompleter::default()),
-			highlighter: Highlighter::new(),
-			mode: Box::new(ViInsert::new()),
-			next_is_escaped: false,
-			saved_mode: None,
-			pending_keymap: Vec::new(),
-			old_layout: None,
-			repeat_action: None,
-			repeat_motion: None,
-			editor: LineBuf::new(),
-			history: History::empty(),
-			needs_redraw: true,
-		};
-		write_vars(|v| {
-			v.set_var(
-				"SHED_VI_MODE",
-				VarKind::Str(new.mode.report_mode().to_string()),
-				VarFlags::NONE,
-			)
-		})?;
-		new.prompt.refresh();
-		new.writer.flush_write("\n")?; // ensure we start on a new line, in case the previous command didn't end with a newline
-		new.print_line(false)?;
-		Ok(new)
-	}
+  pub fn new_no_hist(prompt: Prompt, tty: RawFd) -> ShResult<Self> {
+    let mut new = Self {
+      reader: PollReader::new(),
+      writer: TermWriter::new(tty),
+      tty,
+      prompt,
+      completer: Box::new(FuzzyCompleter::default()),
+      highlighter: Highlighter::new(),
+      mode: Box::new(ViInsert::new()),
+      saved_mode: None,
+      pending_keymap: Vec::new(),
+      old_layout: None,
+      repeat_action: None,
+      repeat_motion: None,
+      editor: LineBuf::new(),
+      history: History::empty(),
+			ex_history: History::empty(),
+      needs_redraw: true,
+    };
+    write_vars(|v| {
+      v.set_var(
+        "SHED_VI_MODE",
+        VarKind::Str(new.mode.report_mode().to_string()),
+        VarFlags::NONE,
+      )
+    })?;
+    new.prompt.refresh();
+    new.writer.flush_write("\n")?; // ensure we start on a new line, in case the previous command didn't end with a newline
+    new.print_line(false)?;
+    Ok(new)
+  }
 
   pub fn with_initial(mut self, initial: &str) -> Self {
     self.editor = LineBuf::new().with_initial(initial, 0);
@@ -333,7 +348,7 @@ impl ShedVi {
 
   /// Feed raw bytes from stdin into the reader's buffer
   pub fn feed_bytes(&mut self, bytes: &[u8]) {
-		self.reader.feed_bytes(bytes);
+    self.reader.feed_bytes(bytes);
   }
 
   /// Mark that the display needs to be redrawn (e.g., after SIGWINCH)
@@ -344,7 +359,7 @@ impl ShedVi {
   pub fn fix_column(&mut self) -> ShResult<()> {
     self
       .writer
-      .fix_cursor_column(&mut TermReader::new(*TTY_FILENO))
+      .fix_cursor_column(&mut TermReader::new(self.tty))
   }
 
   pub fn reset_active_widget(&mut self, full_redraw: bool) -> ShResult<()> {
@@ -352,10 +367,10 @@ impl ShedVi {
       self.completer.reset_stay_active();
       self.needs_redraw = true;
       Ok(())
-		} else if self.history.fuzzy_finder.is_active() {
-			self.history.fuzzy_finder.reset_stay_active();
-			self.needs_redraw = true;
-			Ok(())
+    } else if self.history.fuzzy_finder.is_active() {
+      self.history.fuzzy_finder.reset_stay_active();
+      self.needs_redraw = true;
+      Ok(())
     } else {
       self.reset(full_redraw)
     }
@@ -414,7 +429,7 @@ impl ShedVi {
       LexStream::new(Arc::clone(&input), LexFlags::LEX_UNFINISHED).collect::<ShResult<Vec<_>>>();
     let lex_result2 =
       LexStream::new(Arc::clone(&input), LexFlags::empty()).collect::<ShResult<Vec<_>>>();
-    let is_top_level = self.editor.auto_indent_level == 0;
+    let is_top_level = self.editor.indent_ctx.ctx().is_empty();
 
     let is_complete = match (lex_result1.is_err(), lex_result2.is_err()) {
       (true, true) => {
@@ -441,7 +456,6 @@ impl ShedVi {
 
     // Process all available keys
     while let Some(key) = self.reader.read_key()? {
-			log::debug!("Read key: {key:?} in mode {:?}, self.reader.verbatim = {}", self.mode.report_mode(), self.reader.verbatim);
       // If completer or history search are active, delegate input to it
       if self.history.fuzzy_finder.is_active() {
         self.print_line(false)?;
@@ -624,10 +638,6 @@ impl ShedVi {
 
   pub fn handle_key(&mut self, key: KeyEvent) -> ShResult<Option<ReadlineEvent>> {
     if self.should_accept_hint(&key) {
-      log::debug!(
-        "Accepting hint on key {key:?} in mode {:?}",
-        self.mode.report_mode()
-      );
       self.editor.accept_hint();
       if !self.history.at_pending() {
         self.history.reset_to_pending();
@@ -686,13 +696,14 @@ impl ShedVi {
             .update_pending_cmd((self.editor.as_str(), self.editor.cursor.get()));
           let hint = self.history.get_hint();
           self.editor.set_hint(hint);
-					write_vars(|v| {
-						v.set_var(
-							"SHED_VI_MODE",
-							VarKind::Str(self.mode.report_mode().to_string()),
-							VarFlags::NONE,
-						)
-					}).ok();
+          write_vars(|v| {
+            v.set_var(
+              "SHED_VI_MODE",
+              VarKind::Str(self.mode.report_mode().to_string()),
+              VarFlags::NONE,
+            )
+          })
+          .ok();
 
           // If we are here, we hit a case where pressing tab returned a single candidate
           // So we can just go ahead and reset the completer after this
@@ -700,15 +711,21 @@ impl ShedVi {
         }
         Ok(None) => {
           let post_cmds = read_logic(|l| l.get_autocmds(AutoCmdKind::OnCompletionStart));
-					let candidates = self.completer.all_candidates();
-					let num_candidates = candidates.len();
-					with_vars([
-						("_NUM_MATCHES".into(), Into::<Var>::into(num_candidates)),
-						("_MATCHES".into(), Into::<Var>::into(candidates)),
-						("_SEARCH_STR".into(), Into::<Var>::into(self.completer.token())),
-					], || {
-						post_cmds.exec();
-					});
+          let candidates = self.completer.all_candidates();
+          let num_candidates = candidates.len();
+          with_vars(
+            [
+              ("_NUM_MATCHES".into(), Into::<Var>::into(num_candidates)),
+              ("_MATCHES".into(), Into::<Var>::into(candidates)),
+              (
+                "_SEARCH_STR".into(),
+                Into::<Var>::into(self.completer.token()),
+              ),
+            ],
+            || {
+              post_cmds.exec();
+            },
+          );
 
           if self.completer.is_active() {
             write_vars(|v| {
@@ -723,22 +740,21 @@ impl ShedVi {
             self.needs_redraw = true;
             self.editor.set_hint(None);
           } else {
-						self.writer.send_bell().ok();
-					}
+            self.writer.send_bell().ok();
+          }
         }
       }
 
       self.needs_redraw = true;
       return Ok(None);
     } else if let KeyEvent(KeyCode::Char('R'), ModKeys::CTRL) = key
-			&& self.mode.report_mode() == ModeReport::Insert {
+      && self.mode.report_mode() == ModeReport::Insert
+    {
       let initial = self.editor.as_str();
       match self.history.start_search(initial) {
         Some(entry) => {
           let post_cmds = read_logic(|l| l.get_autocmds(AutoCmdKind::OnHistorySelect));
-          with_vars([
-						("_HIST_ENTRY".into(), entry.clone()),
-					], || {
+          with_vars([("_HIST_ENTRY".into(), entry.clone())], || {
             post_cmds.exec_with(&entry);
           });
 
@@ -751,25 +767,30 @@ impl ShedVi {
         }
         None => {
           let post_cmds = read_logic(|l| l.get_autocmds(AutoCmdKind::OnHistoryOpen));
-					let entries = self.history.fuzzy_finder.candidates();
-					let matches = self.history.fuzzy_finder
-						.filtered()
-						.iter()
-						.cloned()
-						.map(|sc| sc.content)
-						.collect::<Vec<_>>();
+          let entries = self.history.fuzzy_finder.candidates();
+          let matches = self
+            .history
+            .fuzzy_finder
+            .filtered()
+            .iter()
+            .cloned()
+            .map(|sc| sc.content)
+            .collect::<Vec<_>>();
 
-					let num_entries = entries.len();
-					let num_matches = matches.len();
-					with_vars([
-						("_ENTRIES".into(),Into::<Var>::into(entries)),
-						("_NUM_ENTRIES".into(),Into::<Var>::into(num_entries)),
-						("_MATCHES".into(),Into::<Var>::into(matches)),
-						("_NUM_MATCHES".into(),Into::<Var>::into(num_matches)),
-						("_SEARCH_STR".into(), Into::<Var>::into(initial)),
-					], || {
-						post_cmds.exec();
-					});
+          let num_entries = entries.len();
+          let num_matches = matches.len();
+          with_vars(
+            [
+              ("_ENTRIES".into(), Into::<Var>::into(entries)),
+              ("_NUM_ENTRIES".into(), Into::<Var>::into(num_entries)),
+              ("_MATCHES".into(), Into::<Var>::into(matches)),
+              ("_NUM_MATCHES".into(), Into::<Var>::into(num_matches)),
+              ("_SEARCH_STR".into(), Into::<Var>::into(initial)),
+            ],
+            || {
+              post_cmds.exec();
+            },
+          );
 
           if self.history.fuzzy_finder.is_active() {
             write_vars(|v| {
@@ -784,23 +805,16 @@ impl ShedVi {
             self.needs_redraw = true;
             self.editor.set_hint(None);
           } else {
-						self.writer.send_bell().ok();
-					}
+            self.writer.send_bell().ok();
+          }
         }
       }
     }
 
-    if let KeyEvent(KeyCode::Char('\\'), ModKeys::NONE) = key
-      && !self.next_is_escaped
-    {
-      self.next_is_escaped = true;
-    } else {
-      self.next_is_escaped = false;
-    }
-
     let Ok(cmd) = self.mode.handle_key_fallible(key) else {
       // it's an ex mode error
-      self.mode = Box::new(ViNormal::new()) as Box<dyn ViMode>;
+      self.swap_mode(&mut (Box::new(ViNormal::new()) as Box<dyn ViMode>));
+
       return Ok(None);
     };
 
@@ -816,8 +830,7 @@ impl ShedVi {
     }
 
     if cmd.is_submit_action()
-      && !self.next_is_escaped
-      && !self.editor.buffer.ends_with('\\')
+      && !self.editor.cursor_is_escaped()
       && (self.should_submit()? || !read_shopts(|o| o.prompt.linebreak_on_incomplete))
     {
       if self.editor.attempt_history_expansion(&self.history) {
@@ -847,9 +860,22 @@ impl ShedVi {
     }
 
     let has_edit_verb = cmd.verb().is_some_and(|v| v.1.is_edit());
+    let is_shell_cmd = cmd.verb().is_some_and(|v| matches!(v.1, Verb::ShellCmd(_)));
+		let is_ex_cmd = cmd.flags.contains(CmdFlags::IS_EX_CMD);
+		log::debug!("is_ex_cmd: {is_ex_cmd}");
+    if is_shell_cmd {
+      self.old_layout = None;
+    }
+		if is_ex_cmd {
+			self.ex_history.push(cmd.raw_seq.clone());
+			self.ex_history.reset();
+			log::debug!("ex_history: {:?}", self.ex_history.entries());
+		}
 
     let before = self.editor.buffer.clone();
+
     self.exec_cmd(cmd, false)?;
+
     if let Some(keys) = write_meta(|m| m.take_pending_widget_keys()) {
       for key in keys {
         self.handle_key(key)?;
@@ -874,7 +900,7 @@ impl ShedVi {
 
   pub fn get_layout(&mut self, line: &str) -> Layout {
     let to_cursor = self.editor.slice_to_cursor().unwrap_or_default();
-    let (cols, _) = get_win_size(*TTY_FILENO);
+    let (cols, _) = get_win_size(self.tty);
     Layout::from_parts(cols, self.prompt.get_ps1(), to_cursor, line)
   }
   pub fn scroll_history(&mut self, cmd: ViCmd) {
@@ -1053,6 +1079,7 @@ impl ShedVi {
       let pending_seq = self.mode.pending_seq().unwrap_or_default();
       write!(buf, "\n: {pending_seq}").unwrap();
       new_layout.end.row += 1;
+      new_layout.cursor.row += 1;
     }
 
     write!(buf, "{}", &self.mode.cursor_style()).unwrap();
@@ -1126,10 +1153,14 @@ impl ShedVi {
       match cmd.verb().unwrap().1 {
         Verb::Change | Verb::InsertModeLineBreak(_) | Verb::InsertMode => {
           is_insert_mode = true;
-          Box::new(ViInsert::new().with_count(count as u16).record_cmd(cmd.clone()))
+          Box::new(
+            ViInsert::new()
+              .with_count(count as u16)
+              .record_cmd(cmd.clone()),
+          )
         }
 
-        Verb::ExMode => Box::new(ViEx::new()),
+        Verb::ExMode => Box::new(ViEx::new(self.ex_history.clone())),
 
         Verb::VerbatimMode => {
           self.reader.verbatim_single = true;
@@ -1214,17 +1245,17 @@ impl ShedVi {
     Ok(())
   }
 
-	pub fn clone_mode(&self) -> Box<dyn ViMode> {
-		match self.mode.report_mode() {
-			ModeReport::Normal => Box::new(ViNormal::new()),
-			ModeReport::Insert => Box::new(ViInsert::new()),
-			ModeReport::Visual => Box::new(ViVisual::new()),
-			ModeReport::Ex => Box::new(ViEx::new()),
-			ModeReport::Replace => Box::new(ViReplace::new()),
-			ModeReport::Verbatim => Box::new(ViVerbatim::new()),
-			ModeReport::Unknown => unreachable!(),
-		}
-	}
+  pub fn clone_mode(&self) -> Box<dyn ViMode> {
+    match self.mode.report_mode() {
+      ModeReport::Normal => Box::new(ViNormal::new()),
+      ModeReport::Insert => Box::new(ViInsert::new()),
+      ModeReport::Visual => Box::new(ViVisual::new()),
+      ModeReport::Ex => Box::new(ViEx::new(self.ex_history.clone())),
+      ModeReport::Replace => Box::new(ViReplace::new()),
+      ModeReport::Verbatim => Box::new(ViVerbatim::new()),
+      ModeReport::Unknown => unreachable!(),
+    }
+  }
 
   pub fn exec_cmd(&mut self, mut cmd: ViCmd, from_replay: bool) -> ShResult<()> {
     if cmd.is_mode_transition() {
@@ -1241,35 +1272,35 @@ impl ShedVi {
             repeat = count as u16;
           }
 
-					let old_mode = self.mode.report_mode();
+          let old_mode = self.mode.report_mode();
 
           for _ in 0..repeat {
             let cmds = cmds.clone();
             for (i, cmd) in cmds.iter().enumerate() {
-							log::debug!("Replaying command {cmd:?} in mode {:?}, replay {i}/{repeat}", self.mode.report_mode());
               self.exec_cmd(cmd.clone(), true)?;
               // After the first command, start merging so all subsequent
               // edits fold into one undo entry (e.g. cw + inserted chars)
               if i == 0
-							&& let Some(edit) = self.editor.undo_stack.last_mut() {
-								edit.start_merge();
-							}
+                && let Some(edit) = self.editor.undo_stack.last_mut()
+              {
+                edit.start_merge();
+              }
             }
             // Stop merging at the end of the replay
             if let Some(edit) = self.editor.undo_stack.last_mut() {
               edit.stop_merge();
             }
 
-						let old_mode_clone = match old_mode {
-							ModeReport::Normal => Box::new(ViNormal::new()) as Box<dyn ViMode>,
-							ModeReport::Insert => Box::new(ViInsert::new()) as Box<dyn ViMode>,
-							ModeReport::Visual => Box::new(ViVisual::new()) as Box<dyn ViMode>,
-							ModeReport::Ex => Box::new(ViEx::new()) as Box<dyn ViMode>,
-							ModeReport::Replace => Box::new(ViReplace::new()) as Box<dyn ViMode>,
-							ModeReport::Verbatim => Box::new(ViVerbatim::new()) as Box<dyn ViMode>,
-							ModeReport::Unknown => unreachable!(),
-						};
-						self.mode = old_mode_clone;
+            let old_mode_clone = match old_mode {
+              ModeReport::Normal => Box::new(ViNormal::new()) as Box<dyn ViMode>,
+              ModeReport::Insert => Box::new(ViInsert::new()) as Box<dyn ViMode>,
+              ModeReport::Visual => Box::new(ViVisual::new()) as Box<dyn ViMode>,
+              ModeReport::Ex => Box::new(ViEx::new(self.ex_history.clone())) as Box<dyn ViMode>,
+              ModeReport::Replace => Box::new(ViReplace::new()) as Box<dyn ViMode>,
+              ModeReport::Verbatim => Box::new(ViVerbatim::new()) as Box<dyn ViMode>,
+              ModeReport::Unknown => unreachable!(),
+            };
+            self.mode = old_mode_clone;
           }
         }
         CmdReplay::Single(mut cmd) => {
@@ -1351,7 +1382,11 @@ impl ShedVi {
 
     self.editor.exec_cmd(cmd.clone())?;
 
-    if self.mode.report_mode() == ModeReport::Visual && cmd.verb().is_some_and(|v| v.1.is_edit() || v.1 == Verb::Yank) {
+    if self.mode.report_mode() == ModeReport::Visual
+      && cmd
+        .verb()
+        .is_some_and(|v| v.1.is_edit() || v.1 == Verb::Yank)
+    {
       self.editor.stop_selecting();
       let mut mode: Box<dyn ViMode> = Box::new(ViNormal::new());
       self.swap_mode(&mut mode);
@@ -1500,7 +1535,7 @@ pub fn get_insertions(input: &str) -> Vec<(usize, Marker)> {
 pub fn marker_for(class: &TkRule) -> Option<Marker> {
   match class {
     TkRule::Pipe
-		| TkRule::Bang
+    | TkRule::Bang
     | TkRule::ErrPipe
     | TkRule::And
     | TkRule::Or
@@ -1592,6 +1627,12 @@ pub fn annotate_token(token: Tk) -> Vec<(usize, Marker)> {
 
   let mut insertions: Vec<(usize, Marker)> = vec![];
 
+  // Heredoc tokens have spans covering the body content far from the <<
+  // operator, which breaks position tracking after marker insertions
+  if token.flags.contains(TkFlags::IS_HEREDOC) {
+    return insertions;
+  }
+
   if token.class != TkRule::Str
     && let Some(marker) = marker_for(&token.class)
   {

src/readline/register.rs

@@ -7,17 +7,17 @@ pub static SAVED_REGISTERS: Mutex<Option<Registers>> = Mutex::new(None);
 
 #[cfg(test)]
 pub fn save_registers() {
-	let mut saved = SAVED_REGISTERS.lock().unwrap();
-	*saved = Some(REGISTERS.lock().unwrap().clone());
+  let mut saved = SAVED_REGISTERS.lock().unwrap();
+  *saved = Some(REGISTERS.lock().unwrap().clone());
 }
 
 #[cfg(test)]
 pub fn restore_registers() {
-	let mut saved = SAVED_REGISTERS.lock().unwrap();
-	if let Some(ref registers) = *saved {
-		*REGISTERS.lock().unwrap() = registers.clone();
-	}
-	*saved = None;
+  let mut saved = SAVED_REGISTERS.lock().unwrap();
+  if let Some(ref registers) = *saved {
+    *REGISTERS.lock().unwrap() = registers.clone();
+  }
+  *saved = None;
 }
 
 pub fn read_register(ch: Option<char>) -> Option<RegisterContent> {

src/readline/term.rs

@@ -294,12 +294,14 @@ impl Read for TermBuffer {
 
 struct KeyCollector {
   events: VecDeque<KeyEvent>,
+  ss3_pending: bool,
 }
 
 impl KeyCollector {
   fn new() -> Self {
     Self {
       events: VecDeque::new(),
+      ss3_pending: false,
     }
   }
 
@@ -337,7 +339,55 @@ impl Default for KeyCollector {
 
 impl Perform for KeyCollector {
   fn print(&mut self, c: char) {
+    log::trace!("print: {c:?}");
     // vte routes 0x7f (DEL) to print instead of execute
+    if self.ss3_pending {
+      self.ss3_pending = false;
+      match c {
+        'A' => {
+          self.push(KeyEvent(KeyCode::Up, ModKeys::empty()));
+          return;
+        }
+        'B' => {
+          self.push(KeyEvent(KeyCode::Down, ModKeys::empty()));
+          return;
+        }
+        'C' => {
+          self.push(KeyEvent(KeyCode::Right, ModKeys::empty()));
+          return;
+        }
+        'D' => {
+          self.push(KeyEvent(KeyCode::Left, ModKeys::empty()));
+          return;
+        }
+        'H' => {
+          self.push(KeyEvent(KeyCode::Home, ModKeys::empty()));
+          return;
+        }
+        'F' => {
+          self.push(KeyEvent(KeyCode::End, ModKeys::empty()));
+          return;
+        }
+        'P' => {
+          self.push(KeyEvent(KeyCode::F(1), ModKeys::empty()));
+          return;
+        }
+        'Q' => {
+          self.push(KeyEvent(KeyCode::F(2), ModKeys::empty()));
+          return;
+        }
+        'R' => {
+          self.push(KeyEvent(KeyCode::F(3), ModKeys::empty()));
+          return;
+        }
+        'S' => {
+          self.push(KeyEvent(KeyCode::F(4), ModKeys::empty()));
+          return;
+        }
+        _ => {}
+      }
+    }
+
     if c == '\x7f' {
       self.push(KeyEvent(KeyCode::Backspace, ModKeys::empty()));
     } else {
@@ -346,6 +396,7 @@ impl Perform for KeyCollector {
   }
 
   fn execute(&mut self, byte: u8) {
+    log::trace!("execute: {byte:#04x}");
     let event = match byte {
       0x00 => KeyEvent(KeyCode::Char(' '), ModKeys::CTRL), // Ctrl+Space / Ctrl+@
       0x09 => KeyEvent(KeyCode::Tab, ModKeys::empty()),    // Tab (Ctrl+I)
@@ -370,6 +421,9 @@ impl Perform for KeyCollector {
     _ignore: bool,
     action: char,
   ) {
+    log::trace!(
+      "CSI dispatch: params={params:?}, intermediates={intermediates:?}, action={action:?}"
+    );
     let params: Vec<u16> = params
       .iter()
       .map(|p| p.first().copied().unwrap_or(0))
@@ -444,8 +498,8 @@ impl Perform for KeyCollector {
           21 => KeyCode::F(10),
           23 => KeyCode::F(11),
           24 => KeyCode::F(12),
-					200 => KeyCode::BracketedPasteStart,
-					201 => KeyCode::BracketedPasteEnd,
+          200 => KeyCode::BracketedPasteStart,
+          201 => KeyCode::BracketedPasteEnd,
           _ => return,
         };
         KeyEvent(key, mods)
@@ -481,16 +535,11 @@ impl Perform for KeyCollector {
   }
 
   fn esc_dispatch(&mut self, intermediates: &[u8], _ignore: bool, byte: u8) {
-    // SS3 sequences (ESC O P/Q/R/S for F1-F4)
-    if intermediates == [b'O'] {
-      let key = match byte {
-        b'P' => KeyCode::F(1),
-        b'Q' => KeyCode::F(2),
-        b'R' => KeyCode::F(3),
-        b'S' => KeyCode::F(4),
-        _ => return,
-      };
-      self.push(KeyEvent(key, ModKeys::empty()));
+    log::trace!("ESC dispatch: intermediates={intermediates:?}, byte={byte:#04x}");
+    // SS3 sequences
+    if byte == b'O' {
+      self.ss3_pending = true;
+      return;
     }
   }
 }
@@ -498,9 +547,9 @@ impl Perform for KeyCollector {
 pub struct PollReader {
   parser: Parser,
   collector: KeyCollector,
-	byte_buf: VecDeque<u8>,
-	pub verbatim_single: bool,
-	pub verbatim: bool,
+  byte_buf: VecDeque<u8>,
+  pub verbatim_single: bool,
+  pub verbatim: bool,
 }
 
 impl PollReader {
@@ -508,42 +557,45 @@ impl PollReader {
     Self {
       parser: Parser::new(),
       collector: KeyCollector::new(),
-			byte_buf: VecDeque::new(),
-			verbatim_single: false,
-			verbatim: false,
+      byte_buf: VecDeque::new(),
+      verbatim_single: false,
+      verbatim: false,
     }
   }
 
-	pub fn handle_bracket_paste(&mut self) -> Option<KeyEvent> {
-		let end_marker = b"\x1b[201~";
-		let mut raw = vec![];
-		while let Some(byte) = self.byte_buf.pop_front() {
-			raw.push(byte);
-			if raw.ends_with(end_marker) {
-				// Strip the end marker from the raw sequence
-				raw.truncate(raw.len() - end_marker.len());
-				let paste = String::from_utf8_lossy(&raw).to_string();
-				self.verbatim = false;
-				return Some(KeyEvent(KeyCode::Verbatim(paste.into()), ModKeys::empty()));
-			}
-		}
+  pub fn handle_bracket_paste(&mut self) -> Option<KeyEvent> {
+    let end_marker = b"\x1b[201~";
+    let mut raw = vec![];
+    while let Some(byte) = self.byte_buf.pop_front() {
+      raw.push(byte);
+      if raw.ends_with(end_marker) {
+        // Strip the end marker from the raw sequence
+        raw.truncate(raw.len() - end_marker.len());
+        let paste = String::from_utf8_lossy(&raw).to_string();
+        self.verbatim = false;
+        return Some(KeyEvent(KeyCode::Verbatim(paste.into()), ModKeys::empty()));
+      }
+    }
 
-		self.verbatim = true;
-		self.byte_buf.extend(raw);
-		None
-	}
+    self.verbatim = true;
+    self.byte_buf.extend(raw);
+    None
+  }
 
-	pub fn read_one_verbatim(&mut self) -> Option<KeyEvent> {
-		if self.byte_buf.is_empty() {
-			return None;
-		}
-		let bytes: Vec<u8> = self.byte_buf.drain(..).collect();
-		let verbatim_str = String::from_utf8_lossy(&bytes).to_string();
-		Some(KeyEvent(KeyCode::Verbatim(verbatim_str.into()), ModKeys::empty()))
-	}
+  pub fn read_one_verbatim(&mut self) -> Option<KeyEvent> {
+    if self.byte_buf.is_empty() {
+      return None;
+    }
+    let bytes: Vec<u8> = self.byte_buf.drain(..).collect();
+    let verbatim_str = String::from_utf8_lossy(&bytes).to_string();
+    Some(KeyEvent(
+      KeyCode::Verbatim(verbatim_str.into()),
+      ModKeys::empty(),
+    ))
+  }
 
   pub fn feed_bytes(&mut self, bytes: &[u8]) {
-		self.byte_buf.extend(bytes);
+    self.byte_buf.extend(bytes);
   }
 }
 
@@ -555,44 +607,42 @@ impl Default for PollReader {
 
 impl KeyReader for PollReader {
   fn read_key(&mut self) -> Result<Option<KeyEvent>, ShErr> {
-		if self.verbatim_single {
-			if let Some(key) = self.read_one_verbatim() {
-				self.verbatim_single = false;
-				return Ok(Some(key));
-			}
-			return Ok(None);
-		}
-		if self.verbatim {
-			if let Some(paste) = self.handle_bracket_paste() {
-				return Ok(Some(paste));
-			}
-			// If we're in verbatim mode but haven't seen the end marker yet, don't attempt to parse keys
-			return Ok(None);
-		} else if self.byte_buf.front() == Some(&b'\x1b') {
-			// Escape: if it's the only byte, or the next byte isn't a valid
-			// escape sequence prefix ([ or O), emit a standalone Escape
-			if self.byte_buf.len() == 1
-				|| !matches!(self.byte_buf.get(1), Some(b'[') | Some(b'O'))
-			{
-				self.byte_buf.pop_front();
-				return Ok(Some(KeyEvent(KeyCode::Esc, ModKeys::empty())));
-			}
-		}
-		while let Some(byte) = self.byte_buf.pop_front() {
-			self.parser.advance(&mut self.collector, &[byte]);
-			if let Some(key) = self.collector.pop() {
-				match key {
-					KeyEvent(KeyCode::BracketedPasteStart, _) => {
-						if let Some(paste) = self.handle_bracket_paste() {
-							return Ok(Some(paste));
-						} else {
-							continue;
-						}
-					}
-					_ => return Ok(Some(key))
-				}
-			}
-		}
+    if self.verbatim_single {
+      if let Some(key) = self.read_one_verbatim() {
+        self.verbatim_single = false;
+        return Ok(Some(key));
+      }
+      return Ok(None);
+    }
+    if self.verbatim {
+      if let Some(paste) = self.handle_bracket_paste() {
+        return Ok(Some(paste));
+      }
+      // If we're in verbatim mode but haven't seen the end marker yet, don't attempt to parse keys
+      return Ok(None);
+    } else if self.byte_buf.front() == Some(&b'\x1b') {
+      // Escape: if it's the only byte, or the next byte isn't a valid
+      // escape sequence prefix ([ or O), emit a standalone Escape
+      if self.byte_buf.len() == 1 || !matches!(self.byte_buf.get(1), Some(b'[') | Some(b'O')) {
+        self.byte_buf.pop_front();
+        return Ok(Some(KeyEvent(KeyCode::Esc, ModKeys::empty())));
+      }
+    }
+    while let Some(byte) = self.byte_buf.pop_front() {
+      self.parser.advance(&mut self.collector, &[byte]);
+      if let Some(key) = self.collector.pop() {
+        match key {
+          KeyEvent(KeyCode::BracketedPasteStart, _) => {
+            if let Some(paste) = self.handle_bracket_paste() {
+              return Ok(Some(paste));
+            } else {
+              continue;
+            }
+          }
+          _ => return Ok(Some(key)),
+        }
+      }
+    }
     Ok(None)
   }
 }
@@ -844,7 +894,7 @@ impl Default for Layout {
 }
 
 pub struct TermWriter {
-	last_bell: Option<Instant>,
+  last_bell: Option<Instant>,
   out: RawFd,
   pub t_cols: Col, // terminal width
   buffer: String,
@@ -854,7 +904,7 @@ impl TermWriter {
   pub fn new(out: RawFd) -> Self {
     let (t_cols, _) = get_win_size(out);
     Self {
-			last_bell: None,
+      last_bell: None,
       out,
       t_cols,
       buffer: String::new(),
@@ -1091,24 +1141,24 @@ impl LineWriter for TermWriter {
     Ok(())
   }
 
-	fn send_bell(&mut self) -> ShResult<()> {
-		if read_shopts(|o| o.core.bell_enabled) {
-			// we use a cooldown because I don't like having my ears assaulted by 1 million bells
-			// whenever i finish clearing the line using backspace.
-			let now = Instant::now();
+  fn send_bell(&mut self) -> ShResult<()> {
+    if read_shopts(|o| o.core.bell_enabled) {
+      // we use a cooldown because I don't like having my ears assaulted by 1 million bells
+      // whenever i finish clearing the line using backspace.
+      let now = Instant::now();
 
-			// surprisingly, a fixed cooldown like '100' is actually more annoying than 1 million bells.
-			// I've found this range of 50-150 to be the best balance
-			let cooldown = rand::random_range(50..150);
-			let should_send = match self.last_bell {
-				None => true,
-				Some(time) => now.duration_since(time).as_millis() > cooldown,
-			};
-			if should_send {
-				self.flush_write("\x07")?;
-				self.last_bell = Some(now);
-			}
-		}
-		Ok(())
-	}
+      // surprisingly, a fixed cooldown like '100' is actually more annoying than 1 million bells.
+      // I've found this range of 50-150 to be the best balance
+      let cooldown = rand::random_range(50..150);
+      let should_send = match self.last_bell {
+        None => true,
+        Some(time) => now.duration_since(time).as_millis() > cooldown,
+      };
+      if should_send {
+        self.flush_write("\x07")?;
+        self.last_bell = Some(now);
+      }
+    }
+    Ok(())
+  }
 }

src/readline/tests.rs

@@ -1,7 +1,15 @@
 #![allow(non_snake_case)]
 use std::os::fd::AsRawFd;
 
-use crate::{readline::{Prompt, ShedVi}, testutil::TestGuard};
+use crate::{
+  readline::{Prompt, ShedVi, annotate_input},
+  testutil::TestGuard,
+};
+
+fn assert_annotated(input: &str, expected: &str) {
+  let result = annotate_input(input);
+  assert_eq!(result, expected, "\nInput: {input:?}");
+}
 
 /// Tests for our vim logic emulation. Each test consists of an initial text, a sequence of keys to feed, and the expected final text and cursor position.
 macro_rules! vi_test {
@@ -23,207 +31,488 @@ macro_rules! vi_test {
     };
 }
 
-fn test_vi(initial: &str) -> (ShedVi, TestGuard) {
-	let g = TestGuard::new();
-	let prompt = Prompt::default();
-	let vi = ShedVi::new_no_hist(prompt, g.pty_slave().as_raw_fd())
-		.unwrap()
-		.with_initial(initial);
+// ===================== Annotation Tests =====================
 
-	(vi, g)
+#[test]
+fn annotate_simple_command() {
+  assert_annotated("echo hello", "\u{e101}echo\u{e11a} \u{e102}hello\u{e11a}");
+}
+
+#[test]
+fn annotate_pipeline() {
+  assert_annotated(
+    "ls | grep foo",
+    "\u{e100}ls\u{e11a} \u{e104}|\u{e11a} \u{e100}grep\u{e11a} \u{e102}foo\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_conjunction() {
+  assert_annotated(
+    "echo foo && echo bar",
+    "\u{e101}echo\u{e11a} \u{e102}foo\u{e11a} \u{e104}&&\u{e11a} \u{e101}echo\u{e11a} \u{e102}bar\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_redirect_output() {
+  assert_annotated(
+    "echo hello > file.txt",
+    "\u{e101}echo\u{e11a} \u{e102}hello\u{e11a} \u{e105}>\u{e11a} \u{e102}file.txt\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_redirect_append() {
+  assert_annotated(
+    "echo hello >> file.txt",
+    "\u{e101}echo\u{e11a} \u{e102}hello\u{e11a} \u{e105}>>\u{e11a} \u{e102}file.txt\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_redirect_input() {
+  assert_annotated(
+    "cat < file.txt",
+    "\u{e100}cat\u{e11a} \u{e105}<\u{e11a} \u{e102}file.txt\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_fd_redirect() {
+  assert_annotated("cmd 2>&1", "\u{e100}cmd\u{e11a} \u{e105}2>&1\u{e11a}");
+}
+
+#[test]
+fn annotate_variable_sub() {
+  assert_annotated(
+    "echo $HOME",
+    "\u{e101}echo\u{e11a} \u{e102}\u{e10c}$HOME\u{e10d}\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_variable_brace_sub() {
+  assert_annotated(
+    "echo ${HOME}",
+    "\u{e101}echo\u{e11a} \u{e102}\u{e10c}${HOME}\u{e10d}\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_command_sub() {
+  assert_annotated(
+    "echo $(ls)",
+    "\u{e101}echo\u{e11a} \u{e102}\u{e10e}$(ls)\u{e10f}\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_single_quoted_string() {
+  assert_annotated(
+    "echo 'hello world'",
+    "\u{e101}echo\u{e11a} \u{e102}\u{e114}'hello world'\u{e115}\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_double_quoted_string() {
+  assert_annotated(
+    "echo \"hello world\"",
+    "\u{e101}echo\u{e11a} \u{e102}\u{e112}\"hello world\"\u{e113}\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_assignment() {
+  assert_annotated("FOO=bar", "\u{e107}FOO=bar\u{e11a}");
+}
+
+#[test]
+fn annotate_assignment_with_command() {
+  assert_annotated(
+    "FOO=bar echo hello",
+    "\u{e107}FOO=bar\u{e11a} \u{e101}echo\u{e11a} \u{e102}hello\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_if_statement() {
+  assert_annotated(
+    "if true; then echo yes; fi",
+    "\u{e103}if\u{e11a} \u{e101}true\u{e11a}\u{e108}; \u{e11a}\u{e103}then\u{e11a} \u{e101}echo\u{e11a} \u{e102}yes\u{e11a}\u{e108}; \u{e11a}\u{e103}fi\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_for_loop() {
+  assert_annotated(
+    "for i in a b c; do echo $i; done",
+    "\u{e103}for\u{e11a} \u{e102}i\u{e11a} \u{e103}in\u{e11a} \u{e102}a\u{e11a} \u{e102}b\u{e11a} \u{e102}c\u{e11a}\u{e108}; \u{e11a}\u{e103}do\u{e11a} \u{e101}echo\u{e11a} \u{e102}\u{e10c}$i\u{e10d}\u{e11a}\u{e108}; \u{e11a}\u{e103}done\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_while_loop() {
+  assert_annotated(
+    "while true; do echo hello; done",
+    "\u{e103}while\u{e11a} \u{e101}true\u{e11a}\u{e108}; \u{e11a}\u{e103}do\u{e11a} \u{e101}echo\u{e11a} \u{e102}hello\u{e11a}\u{e108}; \u{e11a}\u{e103}done\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_case_statement() {
+  assert_annotated(
+    "case foo in bar) echo bar;; esac",
+    "\u{e103}case\u{e11a} \u{e102}foo\u{e11a} \u{e103}in\u{e11a} \u{e104}bar\u{e109})\u{e11a} \u{e101}echo\u{e11a} \u{e102}bar\u{e11a}\u{e108};; \u{e11a}\u{e103}esac\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_brace_group() {
+  assert_annotated(
+    "{ echo hello; }",
+    "\u{e104}{\u{e11a} \u{e101}echo\u{e11a} \u{e102}hello\u{e11a}\u{e108}; \u{e11a}\u{e104}}\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_comment() {
+  assert_annotated(
+    "echo hello # this is a comment",
+    "\u{e101}echo\u{e11a} \u{e102}hello\u{e11a} \u{e106}# this is a comment\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_semicolon_sep() {
+  assert_annotated(
+    "echo foo; echo bar",
+    "\u{e101}echo\u{e11a} \u{e102}foo\u{e11a}\u{e108}; \u{e11a}\u{e101}echo\u{e11a} \u{e102}bar\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_escaped_char() {
+  assert_annotated(
+    "echo hello\\ world",
+    "\u{e101}echo\u{e11a} \u{e102}hello\\ world\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_glob() {
+  assert_annotated(
+    "ls *.txt",
+    "\u{e100}ls\u{e11a} \u{e102}\u{e117}*\u{e11a}.txt\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_heredoc_operator() {
+  assert_annotated(
+    "cat <<EOF",
+    "\u{e100}cat\u{e11a} \u{e105}<<\u{e11a}\u{e102}EOF\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_herestring_operator() {
+  assert_annotated(
+    "cat <<< hello",
+    "\u{e100}cat\u{e11a} \u{e105}<<<\u{e11a} \u{e102}hello\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_nested_command_sub() {
+  assert_annotated(
+    "echo $(echo $(ls))",
+    "\u{e101}echo\u{e11a} \u{e102}\u{e10e}$(echo $(ls))\u{e10f}\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_var_in_double_quotes() {
+  assert_annotated(
+    "echo \"hello $USER\"",
+    "\u{e101}echo\u{e11a} \u{e102}\u{e112}\"hello \u{e10c}$USER\u{e10d}\"\u{e113}\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_func_def() {
+  assert_annotated(
+    "foo() { echo hello; }",
+    "\u{e103}foo()\u{e11a} \u{e104}{\u{e11a} \u{e101}echo\u{e11a} \u{e102}hello\u{e11a}\u{e108}; \u{e11a}\u{e104}}\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_negate() {
+  assert_annotated(
+    "! echo hello",
+    "\u{e104}!\u{e11a} \u{e101}echo\u{e11a} \u{e102}hello\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_or_conjunction() {
+  assert_annotated(
+    "false || echo fallback",
+    "\u{e101}false\u{e11a} \u{e104}||\u{e11a} \u{e101}echo\u{e11a} \u{e102}fallback\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_complex_pipeline() {
+  assert_annotated(
+    "cat file.txt | grep pattern | wc -l",
+    "\u{e100}cat\u{e11a} \u{e102}file.txt\u{e11a} \u{e104}|\u{e11a} \u{e100}grep\u{e11a} \u{e102}pattern\u{e11a} \u{e104}|\u{e11a} \u{e100}wc\u{e11a} \u{e102}-l\u{e11a}",
+  );
+}
+
+#[test]
+fn annotate_multiple_redirects() {
+  assert_annotated(
+    "cmd > out.txt 2> err.txt",
+    "\u{e100}cmd\u{e11a} \u{e105}>\u{e11a} \u{e102}out.txt\u{e11a} \u{e105}2>\u{e11a} \u{e102}err.txt\u{e11a}",
+  );
+}
+
+// ===================== Vi Tests =====================
+
+fn test_vi(initial: &str) -> (ShedVi, TestGuard) {
+  let g = TestGuard::new();
+  let prompt = Prompt::default();
+  let vi = ShedVi::new_no_hist(prompt, g.pty_slave().as_raw_fd())
+    .unwrap()
+    .with_initial(initial);
+
+  (vi, g)
 }
 
 // Why can't I marry a programming language
 vi_test! {
-	vi_dw_basic          : "hello world"        => "dw"           => "world", 0;
-	vi_dw_middle         : "one two three"      => "wdw"          => "one three", 4;
-	vi_dd_whole_line     : "hello world"        => "dd"           => "", 0;
-	vi_x_single          : "hello"              => "x"            => "ello", 0;
-	vi_x_middle          : "hello"              => "llx"          => "helo", 2;
-	vi_X_backdelete      : "hello"              => "llX"          => "hllo", 1;
-	vi_h_motion          : "hello"              => "$h"           => "hello", 3;
-	vi_l_motion          : "hello"              => "l"            => "hello", 1;
-	vi_h_at_start        : "hello"              => "h"            => "hello", 0;
-	vi_l_at_end          : "hello"              => "$l"           => "hello", 4;
-	vi_w_forward         : "one two three"      => "w"            => "one two three", 4;
-	vi_b_backward        : "one two three"      => "$b"           => "one two three", 8;
-	vi_e_end             : "one two three"      => "e"            => "one two three", 2;
-	vi_ge_back_end       : "one two three"      => "$ge"          => "one two three", 6;
-	vi_w_punctuation     : "foo.bar baz"        => "w"            => "foo.bar baz", 3;
-	vi_e_punctuation     : "foo.bar baz"        => "e"            => "foo.bar baz", 2;
-	vi_b_punctuation     : "foo.bar baz"        => "$b"           => "foo.bar baz", 8;
-	vi_w_at_eol          : "hello"              => "$w"           => "hello", 4;
-	vi_b_at_bol          : "hello"              => "b"            => "hello", 0;
-	vi_W_forward         : "foo.bar baz"        => "W"            => "foo.bar baz", 8;
-	vi_B_backward        : "foo.bar baz"        => "$B"           => "foo.bar baz", 8;
-	vi_E_end             : "foo.bar baz"        => "E"            => "foo.bar baz", 6;
-	vi_gE_back_end       : "one two three"      => "$gE"          => "one two three", 6;
-	vi_W_skip_punct      : "one-two three"      => "W"            => "one-two three", 8;
-	vi_B_skip_punct      : "one two-three"      => "$B"           => "one two-three", 4;
-	vi_E_skip_punct      : "one-two three"      => "E"            => "one-two three", 6;
-	vi_dW_big            : "foo.bar baz"        => "dW"           => "baz", 0;
-	vi_cW_big            : "foo.bar baz"        => "cWx\x1b"      => "x baz", 0;
-	vi_zero_bol          : "  hello"            => "$0"           => "  hello", 0;
-	vi_caret_first_char  : "  hello"            => "$^"           => "  hello", 2;
-	vi_dollar_eol        : "hello world"        => "$"            => "hello world", 10;
-	vi_g_last_nonws      : "hello   "           => "g_"           => "hello   ", 4;
-	vi_g_no_trailing     : "hello"              => "g_"           => "hello", 4;
-	vi_pipe_column       : "hello world"        => "6|"           => "hello world", 5;
-	vi_pipe_col1         : "hello world"        => "1|"           => "hello world", 0;
-	vi_I_insert_front    : "  hello"            => "Iworld \x1b"  => "  world hello", 7;
-	vi_A_append_end      : "hello"              => "A world\x1b"  => "hello world", 10;
-	vi_f_find            : "hello world"        => "fo"           => "hello world", 4;
-	vi_F_find_back       : "hello world"        => "$Fo"          => "hello world", 7;
-	vi_t_till            : "hello world"        => "tw"           => "hello world", 5;
-	vi_T_till_back       : "hello world"        => "$To"          => "hello world", 8;
-	vi_f_no_match        : "hello"              => "fz"           => "hello", 0;
-	vi_semicolon_repeat  : "abcabc"             => "fa;;"         => "abcabc", 3;
-	vi_comma_reverse     : "abcabc"             => "fa;;,"        => "abcabc", 0;
-	vi_df_semicolon      : "abcabc"             => "fa;;dfa"      => "abcabc", 3;
-	vi_t_at_target       : "aab"                => "lta"          => "aab", 1;
-	vi_D_to_end          : "hello world"        => "wD"           => "hello ", 5;
-	vi_d_dollar          : "hello world"        => "wd$"          => "hello ", 5;
-	vi_d0_to_start       : "hello world"        => "$d0"          => "d", 0;
-	vi_dw_multiple       : "one two three"      => "d2w"          => "three", 0;
-	vi_dt_char           : "hello world"        => "dtw"          => "world", 0;
-	vi_df_char           : "hello world"        => "dfw"          => "orld", 0;
-	vi_dh_back           : "hello"              => "lldh"         => "hllo", 1;
-	vi_dl_forward        : "hello"              => "dl"           => "ello", 0;
-	vi_dge_back_end      : "one two three"      => "$dge"         => "one tw", 5;
-	vi_dG_to_end         : "hello world"        => "dG"           => "", 0;
-	vi_dgg_to_start      : "hello world"        => "$dgg"         => "", 0;
-	vi_d_semicolon       : "abcabc"             => "fad;"         => "abcabc", 3;
-	vi_cw_basic          : "hello world"        => "cwfoo\x1b"    => "foo world", 2;
-	vi_C_to_end          : "hello world"        => "wCfoo\x1b"    => "hello foo", 8;
-	vi_cc_whole          : "hello world"        => "ccfoo\x1b"    => "foo", 2;
-	vi_ct_char           : "hello world"        => "ctwfoo\x1b"   => "fooworld", 2;
-	vi_s_single          : "hello"              => "sfoo\x1b"     => "fooello", 2;
-	vi_S_whole_line      : "hello world"        => "Sfoo\x1b"     => "foo", 2;
-	vi_cl_forward        : "hello"              => "clX\x1b"      => "Xello", 0;
-	vi_ch_backward       : "hello"              => "llchX\x1b"    => "hXllo", 1;
-	vi_cb_word_back      : "hello world"        => "$cbfoo\x1b"   => "hello food", 8;
-	vi_ce_word_end       : "hello world"        => "cefoo\x1b"    => "foo world", 2;
-	vi_c0_to_start       : "hello world"        => "wc0foo\x1b"   => "fooworld", 2;
-	vi_yw_p_basic        : "hello world"        => "ywwP"         => "hello hello world", 11;
-	vi_dw_p_paste        : "hello world"        => "dwP"          => "hello world", 5;
-	vi_dd_p_paste        : "hello world"        => "ddp"          => "\nhello world", 1;
-	vi_y_dollar_p        : "hello world"        => "wy$P"         => "hello worldworld", 10;
-	vi_ye_p              : "hello world"        => "yewP"         => "hello helloworld", 10;
-	vi_yy_p              : "hello world"        => "yyp"          => "hello world\nhello world", 12;
-	vi_Y_p               : "hello world"        => "Yp"           => "hhello worldello world", 11;
-	vi_p_after_x         : "hello"              => "xp"           => "ehllo", 1;
-	vi_P_before          : "hello"              => "llxP"         => "hello", 2;
-	vi_paste_empty       : "hello"              => "p"            => "hello", 0;
-	vi_r_replace         : "hello"              => "ra"           => "aello", 0;
-	vi_r_middle          : "hello"              => "llra"         => "healo", 2;
-	vi_r_at_end          : "hello"              => "$ra"          => "hella", 4;
-	vi_r_space           : "hello"              => "r "           => " ello", 0;
-	vi_r_with_count      : "hello"              => "3rx"          => "xxxlo", 2;
-	vi_tilde_single      : "hello"              => "~"            => "Hello", 1;
-	vi_tilde_count       : "hello"              => "3~"           => "HELlo", 3;
-	vi_tilde_at_end      : "HELLO"              => "$~"           => "HELLo", 4;
-	vi_tilde_mixed       : "hElLo"              => "5~"           => "HeLlO", 4;
-	vi_gu_word           : "HELLO world"        => "guw"          => "hello world", 0;
-	vi_gU_word           : "hello WORLD"        => "gUw"          => "HELLO WORLD", 0;
-	vi_gu_dollar         : "HELLO WORLD"        => "gu$"          => "hello world", 0;
-	vi_gU_dollar         : "hello world"        => "gU$"          => "HELLO WORLD", 0;
-	vi_gu_0              : "HELLO WORLD"        => "$gu0"         => "hello worlD", 0;
-	vi_gU_0              : "hello world"        => "$gU0"         => "HELLO WORLd", 0;
-	vi_gtilde_word       : "hello WORLD"        => "g~w"          => "HELLO WORLD", 0;
-	vi_gtilde_dollar     : "hello WORLD"        => "g~$"          => "HELLO world", 0;
-	vi_diw_inner         : "one two three"      => "wdiw"         => "one  three", 4;
-	vi_ciw_replace       : "hello world"        => "ciwfoo\x1b"   => "foo world", 2;
-	vi_daw_around        : "one two three"      => "wdaw"         => "one three", 4;
-	vi_yiw_p             : "hello world"        => "yiwAp \x1bp"  => "hello worldp hello", 17;
-	vi_diW_big_inner     : "one-two three"      => "diW"          => " three", 0;
-	vi_daW_big_around    : "one two-three end"  => "wdaW"         => "one end", 4;
-	vi_ciW_big           : "one-two three"      => "ciWx\x1b"     => "x three", 0;
-	vi_di_dquote         : "one \"two\" three"  => "f\"di\""      => "one \"\" three", 5;
-	vi_da_dquote         : "one \"two\" three"  => "f\"da\""      => "one three", 4;
-	vi_ci_dquote         : "one \"two\" three"  => "f\"ci\"x\x1b" => "one \"x\" three", 5;
-	vi_di_squote         : "one 'two' three"    => "f'di'"        => "one '' three", 5;
-	vi_da_squote         : "one 'two' three"    => "f'da'"        => "one three", 4;
-	vi_di_backtick       : "one `two` three"    => "f`di`"        => "one `` three", 5;
-	vi_da_backtick       : "one `two` three"    => "f`da`"        => "one three", 4;
-	vi_ci_dquote_empty   : "one \"\" three"     => "f\"ci\"x\x1b" => "one \"x\" three", 5;
-	vi_di_paren          : "one (two) three"    => "f(di("        => "one () three", 5;
-	vi_da_paren          : "one (two) three"    => "f(da("        => "one  three", 4;
-	vi_ci_paren          : "one (two) three"    => "f(ci(x\x1b"   => "one (x) three", 5;
-	vi_di_brace          : "one {two} three"    => "f{di{"        => "one {} three", 5;
-	vi_da_brace          : "one {two} three"    => "f{da{"        => "one  three", 4;
-	vi_di_bracket        : "one [two] three"    => "f[di["        => "one [] three", 5;
-	vi_da_bracket        : "one [two] three"    => "f[da["        => "one  three", 4;
-	vi_di_angle          : "one <two> three"    => "f<di<"        => "one <> three", 5;
-	vi_da_angle          : "one <two> three"    => "f<da<"        => "one  three", 4;
-	vi_di_paren_nested   : "fn(a, (b, c))"      => "f(di("        => "fn()", 3;
-	vi_di_paren_empty    : "fn() end"           => "f(di("        => "fn() end", 3;
-	vi_dib_alias         : "one (two) three"    => "f(dib"        => "one () three", 5;
-	vi_diB_alias         : "one {two} three"    => "f{diB"        => "one {} three", 5;
-	vi_percent_paren     : "(hello) world"      => "%"            => "(hello) world", 6;
-	vi_percent_brace     : "{hello} world"      => "%"            => "{hello} world", 6;
-	vi_percent_bracket   : "[hello] world"      => "%"            => "[hello] world", 6;
-	vi_percent_from_close: "(hello) world"      => "f)%"          => "(hello) world", 0;
-	vi_d_percent_paren   : "(hello) world"      => "d%"           => " world", 0;
-	vi_i_insert          : "hello"              => "iX\x1b"       => "Xhello", 0;
-	vi_a_append          : "hello"              => "aX\x1b"       => "hXello", 1;
-	vi_I_front           : "  hello"            => "IX\x1b"       => "  Xhello", 2;
-	vi_A_end             : "hello"              => "AX\x1b"       => "helloX", 5;
-	vi_o_open_below      : "hello"              => "oworld\x1b"   => "hello\nworld", 10;
-	vi_O_open_above      : "hello"              => "Oworld\x1b"   => "world\nhello", 4;
-	vi_empty_input       : ""                   => "i hello\x1b"  => " hello", 5;
-	vi_insert_escape     : "hello"              => "aX\x1b"       => "hXello", 1;
-	vi_ctrl_w_del_word   : "hello world"        => "A\x17\x1b"    => "hello ", 5;
-	vi_ctrl_h_backspace  : "hello"              => "A\x08\x1b"    => "hell", 3;
-	vi_u_undo_delete     : "hello world"        => "dwu"          => "hello world", 0;
-	vi_u_undo_change     : "hello world"        => "ciwfoo\x1bu"  => "hello world", 0;
-	vi_u_undo_x          : "hello"              => "xu"           => "hello", 0;
-	vi_ctrl_r_redo       : "hello"              => "xu\x12"       => "ello", 0;
-	vi_u_multiple        : "hello world"        => "xdwu"         => "ello world", 0;
-	vi_redo_after_undo   : "hello world"        => "dwu\x12"      => "world", 0;
-	vi_dot_repeat_x      : "hello"              => "x."           => "llo", 0;
-	vi_dot_repeat_dw     : "one two three"      => "dw."          => "three", 0;
-	vi_dot_repeat_cw     : "one two three"      => "cwfoo\x1bw."  => "foo foo three", 6;
-	vi_dot_repeat_r      : "hello"              => "ra.."         => "aello", 0;
-	vi_dot_repeat_s      : "hello"              => "sX\x1bl."     => "XXllo", 1;
-	vi_count_h           : "hello world"        => "$3h"          => "hello world", 7;
-	vi_count_l           : "hello world"        => "3l"           => "hello world", 3;
-	vi_count_w           : "one two three four" => "2w"           => "one two three four", 8;
-	vi_count_b           : "one two three four" => "$2b"          => "one two three four", 8;
-	vi_count_x           : "hello"              => "3x"           => "lo", 0;
-	vi_count_dw          : "one two three four" => "2dw"          => "three four", 0;
-	vi_verb_count_motion : "one two three four" => "d2w"          => "three four", 0;
-	vi_count_s           : "hello"              => "3sX\x1b"      => "Xlo", 0;
-	vi_indent_line       : "hello"              => ">>"           => "\thello", 0;
-	vi_dedent_line       : "\thello"            => "<<"           => "hello", 0;
-	vi_indent_double     : "hello"              => ">>>>"         => "\t\thello", 0;
-	vi_J_join_lines      : "hello\nworld"       => "J"            => "hello world", 5;
-	vi_v_u_lower         : "HELLO"              => "vlllu"        => "hellO", 0;
-	vi_v_U_upper         : "hello"              => "vlllU"        => "HELLo", 0;
-	vi_v_d_delete        : "hello world"        => "vwwd"         => "", 0;
-	vi_v_x_delete        : "hello world"        => "vwwx"         => "", 0;
-	vi_v_c_change        : "hello world"        => "vwcfoo\x1b"   => "fooorld", 2;
-	vi_v_y_p_yank        : "hello world"        => "vwyAp \x1bp"  => "hello worldp hello w", 19;
-	vi_v_dollar_d        : "hello world"        => "wv$d"         => "hello ", 5;
-	vi_v_0_d             : "hello world"        => "$v0d"         => "", 0;
-	vi_ve_d              : "hello world"        => "ved"          => " world", 0;
-	vi_v_o_swap          : "hello world"        => "vllod"        => "lo world", 0;
-	vi_v_r_replace       : "hello"              => "vlllrx"       => "xxxxo", 0;
-	vi_v_tilde_case      : "hello"              => "vlll~"        => "HELLo", 0;
-	vi_V_d_delete        : "hello world"        => "Vd"           => "", 0;
-	vi_V_y_p             : "hello world"        => "Vyp"          => "hello world\nhello world", 12;
-	vi_V_S_change        : "hello world"        => "VSfoo\x1b"    => "foo", 2;
-	vi_ctrl_a_inc        : "num 5 end"          => "w\x01"        => "num 6 end", 4;
-	vi_ctrl_x_dec        : "num 5 end"          => "w\x18"        => "num 4 end", 4;
-	vi_ctrl_a_negative   : "num -3 end"         => "w\x01"        => "num -2 end", 4;
-	vi_ctrl_x_to_neg     : "num 0 end"          => "w\x18"        => "num -1 end", 4;
-	vi_ctrl_a_count      : "num 5 end"          => "w3\x01"       => "num 8 end", 4;
-	vi_ctrl_a_width      : "num -00001 end"     => "w\x01"        => "num 00000 end", 4;
-	vi_delete_empty      : ""                   => "x"            => "", 0;
-	vi_undo_on_empty     : ""                   => "u"            => "", 0;
-	vi_w_single_char     : "a b c"              => "w"            => "a b c", 2;
-	vi_dw_last_word      : "hello"              => "dw"           => "", 0;
-	vi_dollar_single     : "h"                  => "$"            => "h", 0;
-	vi_caret_no_ws       : "hello"              => "$^"           => "hello", 0;
-	vi_f_last_char       : "hello"              => "fo"           => "hello", 4;
-	vi_r_on_space        : "hello world"        => "5|r-"         => "hell- world", 4
+  vi_dw_basic          : "hello world"            => "dw"           => "world", 0;
+  vi_dw_middle         : "one two three"          => "wdw"          => "one three", 4;
+  vi_dd_whole_line     : "hello world"            => "dd"           => "", 0;
+  vi_x_single          : "hello"                  => "x"            => "ello", 0;
+  vi_x_middle          : "hello"                  => "llx"          => "helo", 2;
+  vi_X_backdelete      : "hello"                  => "llX"          => "hllo", 1;
+  vi_h_motion          : "hello"                  => "$h"           => "hello", 3;
+  vi_l_motion          : "hello"                  => "l"            => "hello", 1;
+  vi_h_at_start        : "hello"                  => "h"            => "hello", 0;
+  vi_l_at_end          : "hello"                  => "$l"           => "hello", 4;
+  vi_w_forward         : "one two three"          => "w"            => "one two three", 4;
+  vi_b_backward        : "one two three"          => "$b"           => "one two three", 8;
+  vi_e_end             : "one two three"          => "e"            => "one two three", 2;
+  vi_ge_back_end       : "one two three"          => "$ge"          => "one two three", 6;
+  vi_w_punctuation     : "foo.bar baz"            => "w"            => "foo.bar baz", 3;
+  vi_e_punctuation     : "foo.bar baz"            => "e"            => "foo.bar baz", 2;
+  vi_b_punctuation     : "foo.bar baz"            => "$b"           => "foo.bar baz", 8;
+  vi_w_at_eol          : "hello"                  => "$w"           => "hello", 4;
+  vi_b_at_bol          : "hello"                  => "b"            => "hello", 0;
+  vi_W_forward         : "foo.bar baz"            => "W"            => "foo.bar baz", 8;
+  vi_B_backward        : "foo.bar baz"            => "$B"           => "foo.bar baz", 8;
+  vi_E_end             : "foo.bar baz"            => "E"            => "foo.bar baz", 6;
+  vi_gE_back_end       : "one two three"          => "$gE"          => "one two three", 6;
+  vi_W_skip_punct      : "one-two three"          => "W"            => "one-two three", 8;
+  vi_B_skip_punct      : "one two-three"          => "$B"           => "one two-three", 4;
+  vi_E_skip_punct      : "one-two three"          => "E"            => "one-two three", 6;
+  vi_dW_big            : "foo.bar baz"            => "dW"           => "baz", 0;
+  vi_cW_big            : "foo.bar baz"            => "cWx\x1b"      => "x baz", 0;
+  vi_zero_bol          : "  hello"                => "$0"           => "  hello", 0;
+  vi_caret_first_char  : "  hello"                => "$^"           => "  hello", 2;
+  vi_dollar_eol        : "hello world"            => "$"            => "hello world", 10;
+  vi_g_last_nonws      : "hello   "               => "g_"           => "hello   ", 4;
+  vi_g_no_trailing     : "hello"                  => "g_"           => "hello", 4;
+  vi_pipe_column       : "hello world"            => "6|"           => "hello world", 5;
+  vi_pipe_col1         : "hello world"            => "1|"           => "hello world", 0;
+  vi_I_insert_front    : "  hello"                => "Iworld \x1b"  => "  world hello", 7;
+  vi_A_append_end      : "hello"                  => "A world\x1b"  => "hello world", 10;
+  vi_f_find            : "hello world"            => "fo"           => "hello world", 4;
+  vi_F_find_back       : "hello world"            => "$Fo"          => "hello world", 7;
+  vi_t_till            : "hello world"            => "tw"           => "hello world", 5;
+  vi_T_till_back       : "hello world"            => "$To"          => "hello world", 8;
+  vi_f_no_match        : "hello"                  => "fz"           => "hello", 0;
+  vi_semicolon_repeat  : "abcabc"                 => "fa;;"         => "abcabc", 3;
+  vi_comma_reverse     : "abcabc"                 => "fa;;,"        => "abcabc", 0;
+  vi_df_semicolon      : "abcabc"                 => "fa;;dfa"      => "abcabc", 3;
+  vi_t_at_target       : "aab"                    => "lta"          => "aab", 1;
+  vi_D_to_end          : "hello world"            => "wD"           => "hello ", 5;
+  vi_d_dollar          : "hello world"            => "wd$"          => "hello ", 5;
+  vi_d0_to_start       : "hello world"            => "$d0"          => "d", 0;
+  vi_dw_multiple       : "one two three"          => "d2w"          => "three", 0;
+  vi_dt_char           : "hello world"            => "dtw"          => "world", 0;
+  vi_df_char           : "hello world"            => "dfw"          => "orld", 0;
+  vi_dh_back           : "hello"                  => "lldh"         => "hllo", 1;
+  vi_dl_forward        : "hello"                  => "dl"           => "ello", 0;
+  vi_dge_back_end      : "one two three"          => "$dge"         => "one tw", 5;
+  vi_dG_to_end         : "hello world"            => "dG"           => "", 0;
+  vi_dgg_to_start      : "hello world"            => "$dgg"         => "", 0;
+  vi_d_semicolon       : "abcabc"                 => "fad;"         => "abcabc", 3;
+  vi_cw_basic          : "hello world"            => "cwfoo\x1b"    => "foo world", 2;
+  vi_C_to_end          : "hello world"            => "wCfoo\x1b"    => "hello foo", 8;
+  vi_cc_whole          : "hello world"            => "ccfoo\x1b"    => "foo", 2;
+  vi_ct_char           : "hello world"            => "ctwfoo\x1b"   => "fooworld", 2;
+  vi_s_single          : "hello"                  => "sfoo\x1b"     => "fooello", 2;
+  vi_S_whole_line      : "hello world"            => "Sfoo\x1b"     => "foo", 2;
+  vi_cl_forward        : "hello"                  => "clX\x1b"      => "Xello", 0;
+  vi_ch_backward       : "hello"                  => "llchX\x1b"    => "hXllo", 1;
+  vi_cb_word_back      : "hello world"            => "$cbfoo\x1b"   => "hello food", 8;
+  vi_ce_word_end       : "hello world"            => "cefoo\x1b"    => "foo world", 2;
+  vi_c0_to_start       : "hello world"            => "wc0foo\x1b"   => "fooworld", 2;
+  vi_yw_p_basic        : "hello world"            => "ywwP"         => "hello hello world", 11;
+  vi_dw_p_paste        : "hello world"            => "dwP"          => "hello world", 5;
+  vi_dd_p_paste        : "hello world"            => "ddp"          => "\nhello world", 1;
+  vi_y_dollar_p        : "hello world"            => "wy$P"         => "hello worldworld", 10;
+  vi_ye_p              : "hello world"            => "yewP"         => "hello helloworld", 10;
+  vi_yy_p              : "hello world"            => "yyp"          => "hello world\nhello world", 12;
+  vi_Y_p               : "hello world"            => "Yp"           => "hhello worldello world", 11;
+  vi_p_after_x         : "hello"                  => "xp"           => "ehllo", 1;
+  vi_P_before          : "hello"                  => "llxP"         => "hello", 2;
+  vi_paste_empty       : "hello"                  => "p"            => "hello", 0;
+  vi_r_replace         : "hello"                  => "ra"           => "aello", 0;
+  vi_r_middle          : "hello"                  => "llra"         => "healo", 2;
+  vi_r_at_end          : "hello"                  => "$ra"          => "hella", 4;
+  vi_r_space           : "hello"                  => "r "           => " ello", 0;
+  vi_r_with_count      : "hello"                  => "3rx"          => "xxxlo", 2;
+  vi_tilde_single      : "hello"                  => "~"            => "Hello", 1;
+  vi_tilde_count       : "hello"                  => "3~"           => "HELlo", 3;
+  vi_tilde_at_end      : "HELLO"                  => "$~"           => "HELLo", 4;
+  vi_tilde_mixed       : "hElLo"                  => "5~"           => "HeLlO", 4;
+  vi_gu_word           : "HELLO world"            => "guw"          => "hello world", 0;
+  vi_gU_word           : "hello WORLD"            => "gUw"          => "HELLO WORLD", 0;
+  vi_gu_dollar         : "HELLO WORLD"            => "gu$"          => "hello world", 0;
+  vi_gU_dollar         : "hello world"            => "gU$"          => "HELLO WORLD", 0;
+  vi_gu_0              : "HELLO WORLD"            => "$gu0"         => "hello worlD", 0;
+  vi_gU_0              : "hello world"            => "$gU0"         => "HELLO WORLd", 0;
+  vi_gtilde_word       : "hello WORLD"            => "g~w"          => "HELLO WORLD", 0;
+  vi_gtilde_dollar     : "hello WORLD"            => "g~$"          => "HELLO world", 0;
+  vi_diw_inner         : "one two three"          => "wdiw"         => "one  three", 4;
+  vi_ciw_replace       : "hello world"            => "ciwfoo\x1b"   => "foo world", 2;
+  vi_daw_around        : "one two three"          => "wdaw"         => "one three", 4;
+  vi_yiw_p             : "hello world"            => "yiwAp \x1bp"  => "hello worldp hello", 17;
+  vi_diW_big_inner     : "one-two three"          => "diW"          => " three", 0;
+  vi_daW_big_around    : "one two-three end"      => "wdaW"         => "one end", 4;
+  vi_ciW_big           : "one-two three"          => "ciWx\x1b"     => "x three", 0;
+  vi_di_dquote         : "one \"two\" three"      => "f\"di\""      => "one \"\" three", 5;
+  vi_da_dquote         : "one \"two\" three"      => "f\"da\""      => "one three", 4;
+  vi_ci_dquote         : "one \"two\" three"      => "f\"ci\"x\x1b" => "one \"x\" three", 5;
+  vi_di_squote         : "one 'two' three"        => "f'di'"        => "one '' three", 5;
+  vi_da_squote         : "one 'two' three"        => "f'da'"        => "one three", 4;
+  vi_di_backtick       : "one `two` three"        => "f`di`"        => "one `` three", 5;
+  vi_da_backtick       : "one `two` three"        => "f`da`"        => "one three", 4;
+  vi_ci_dquote_empty   : "one \"\" three"         => "f\"ci\"x\x1b" => "one \"x\" three", 5;
+  vi_di_paren          : "one (two) three"        => "f(di("        => "one () three", 5;
+  vi_da_paren          : "one (two) three"        => "f(da("        => "one  three", 4;
+  vi_ci_paren          : "one (two) three"        => "f(ci(x\x1b"   => "one (x) three", 5;
+  vi_di_brace          : "one {two} three"        => "f{di{"        => "one {} three", 5;
+  vi_da_brace          : "one {two} three"        => "f{da{"        => "one  three", 4;
+  vi_di_bracket        : "one [two] three"        => "f[di["        => "one [] three", 5;
+  vi_da_bracket        : "one [two] three"        => "f[da["        => "one  three", 4;
+  vi_di_angle          : "one <two> three"        => "f<di<"        => "one <> three", 5;
+  vi_da_angle          : "one <two> three"        => "f<da<"        => "one  three", 4;
+  vi_di_paren_nested   : "fn(a, (b, c))"          => "f(di("        => "fn()", 3;
+  vi_di_paren_empty    : "fn() end"               => "f(di("        => "fn() end", 3;
+  vi_dib_alias         : "one (two) three"        => "f(dib"        => "one () three", 5;
+  vi_diB_alias         : "one {two} three"        => "f{diB"        => "one {} three", 5;
+  vi_percent_paren     : "(hello) world"          => "%"            => "(hello) world", 6;
+  vi_percent_brace     : "{hello} world"          => "%"            => "{hello} world", 6;
+  vi_percent_bracket   : "[hello] world"          => "%"            => "[hello] world", 6;
+  vi_percent_from_close: "(hello) world"          => "f)%"          => "(hello) world", 0;
+  vi_d_percent_paren   : "(hello) world"          => "d%"           => " world", 0;
+  vi_i_insert          : "hello"                  => "iX\x1b"       => "Xhello", 0;
+  vi_a_append          : "hello"                  => "aX\x1b"       => "hXello", 1;
+  vi_I_front           : "  hello"                => "IX\x1b"       => "  Xhello", 2;
+  vi_A_end             : "hello"                  => "AX\x1b"       => "helloX", 5;
+  vi_o_open_below      : "hello"                  => "oworld\x1b"   => "hello\nworld", 10;
+  vi_O_open_above      : "hello"                  => "Oworld\x1b"   => "world\nhello", 4;
+  vi_empty_input       : ""                       => "i hello\x1b"  => " hello", 5;
+  vi_insert_escape     : "hello"                  => "aX\x1b"       => "hXello", 1;
+  vi_ctrl_w_del_word   : "hello world"            => "A\x17\x1b"    => "hello ", 5;
+  vi_ctrl_h_backspace  : "hello"                  => "A\x08\x1b"    => "hell", 3;
+  vi_u_undo_delete     : "hello world"            => "dwu"          => "hello world", 0;
+  vi_u_undo_change     : "hello world"            => "ciwfoo\x1bu"  => "hello world", 0;
+  vi_u_undo_x          : "hello"                  => "xu"           => "hello", 0;
+  vi_ctrl_r_redo       : "hello"                  => "xu\x12"       => "ello", 0;
+  vi_u_multiple        : "hello world"            => "xdwu"         => "ello world", 0;
+  vi_redo_after_undo   : "hello world"            => "dwu\x12"      => "world", 0;
+  vi_dot_repeat_x      : "hello"                  => "x."           => "llo", 0;
+  vi_dot_repeat_dw     : "one two three"          => "dw."          => "three", 0;
+  vi_dot_repeat_cw     : "one two three"          => "cwfoo\x1bw."  => "foo foo three", 6;
+  vi_dot_repeat_r      : "hello"                  => "ra.."         => "aello", 0;
+  vi_dot_repeat_s      : "hello"                  => "sX\x1bl."     => "XXllo", 1;
+  vi_count_h           : "hello world"            => "$3h"          => "hello world", 7;
+  vi_count_l           : "hello world"            => "3l"           => "hello world", 3;
+  vi_count_w           : "one two three four"     => "2w"           => "one two three four", 8;
+  vi_count_b           : "one two three four"     => "$2b"          => "one two three four", 8;
+  vi_count_x           : "hello"                  => "3x"           => "lo", 0;
+  vi_count_dw          : "one two three four"     => "2dw"          => "three four", 0;
+  vi_verb_count_motion : "one two three four"     => "d2w"          => "three four", 0;
+  vi_count_s           : "hello"                  => "3sX\x1b"      => "Xlo", 0;
+  vi_indent_line       : "hello"                  => ">>"           => "\thello", 1;
+  vi_dedent_line       : "\thello"                => "<<"           => "hello", 0;
+  vi_indent_double     : "hello"                  => ">>>>"         => "\t\thello", 2;
+  vi_J_join_lines      : "hello\nworld"           => "J"            => "hello world", 5;
+  vi_v_u_lower         : "HELLO"                  => "vlllu"        => "hellO", 0;
+  vi_v_U_upper         : "hello"                  => "vlllU"        => "HELLo", 0;
+  vi_v_d_delete        : "hello world"            => "vwwd"         => "", 0;
+  vi_v_x_delete        : "hello world"            => "vwwx"         => "", 0;
+  vi_v_c_change        : "hello world"            => "vwcfoo\x1b"   => "fooorld", 2;
+  vi_v_y_p_yank        : "hello world"            => "vwyAp \x1bp"  => "hello worldp hello w", 19;
+  vi_v_dollar_d        : "hello world"            => "wv$d"         => "hello ", 5;
+  vi_v_0_d             : "hello world"            => "$v0d"         => "", 0;
+  vi_ve_d              : "hello world"            => "ved"          => " world", 0;
+  vi_v_o_swap          : "hello world"            => "vllod"        => "lo world", 0;
+  vi_v_r_replace       : "hello"                  => "vlllrx"       => "xxxxo", 0;
+  vi_v_tilde_case      : "hello"                  => "vlll~"        => "HELLo", 0;
+  vi_V_d_delete        : "hello world"            => "Vd"           => "", 0;
+  vi_V_y_p             : "hello world"            => "Vyp"          => "hello world\nhello world", 12;
+  vi_V_S_change        : "hello world"            => "VSfoo\x1b"    => "foo", 2;
+  vi_ctrl_a_inc        : "num 5 end"              => "w\x01"        => "num 6 end", 4;
+  vi_ctrl_x_dec        : "num 5 end"              => "w\x18"        => "num 4 end", 4;
+  vi_ctrl_a_negative   : "num -3 end"             => "w\x01"        => "num -2 end", 4;
+  vi_ctrl_x_to_neg     : "num 0 end"              => "w\x18"        => "num -1 end", 4;
+  vi_ctrl_a_count      : "num 5 end"              => "w3\x01"       => "num 8 end", 4;
+  vi_ctrl_a_width      : "num -00001 end"         => "w\x01"        => "num 00000 end", 4;
+  vi_delete_empty      : ""                       => "x"            => "", 0;
+  vi_undo_on_empty     : ""                       => "u"            => "", 0;
+  vi_w_single_char     : "a b c"                  => "w"            => "a b c", 2;
+  vi_dw_last_word      : "hello"                  => "dw"           => "", 0;
+  vi_dollar_single     : "h"                      => "$"            => "h", 0;
+  vi_caret_no_ws       : "hello"                  => "$^"           => "hello", 0;
+  vi_f_last_char       : "hello"                  => "fo"           => "hello", 4;
+  vi_r_on_space        : "hello world"            => "5|r-"         => "hell- world", 4;
+  vi_vw_doesnt_crash   : ""        					      => "vw"           => "", 0;
+  vi_indent_cursor_pos : "echo foo"               => ">>"           => "\techo foo", 1;
+  vi_join_indent_lines : "echo foo\n\t\techo bar" => "J"        => "echo foo echo bar", 8
+}
+
+#[test]
+fn vi_auto_indent() {
+  let (mut vi, _g) = test_vi("");
+
+  // Type each line and press Enter separately so auto-indent triggers
+  let lines = [
+    "func() {",
+    "case foo in",
+    "bar)",
+    "while true; do",
+    "echo foo \\\rbar \\\rbiz \\\rbazz\rbreak\rdone\r;;\resac\r}",
+  ];
+
+  for (i, line) in lines.iter().enumerate() {
+    vi.feed_bytes(line.as_bytes());
+    if i != lines.len() - 1 {
+      vi.feed_bytes(b"\r");
+    }
+    vi.process_input().unwrap();
+  }
+
+  assert_eq!(
+    vi.editor.as_str(),
+    "func() {\n\tcase foo in\n\t\tbar)\n\t\t\twhile true; do\n\t\t\t\techo foo \\\n\t\t\t\t\tbar \\\n\t\t\t\t\tbiz \\\n\t\t\t\t\tbazz\n\t\t\t\tbreak\n\t\t\tdone\n\t\t;;\n\tesac\n}"
+  );
 }

src/readline/vicmd.rs

@@ -64,6 +64,7 @@ bitflags! {
     const VISUAL_LINE = 1<<1;
     const VISUAL_BLOCK = 1<<2;
     const EXIT_CUR_MODE = 1<<3;
+		const IS_EX_CMD = 1<<4;
   }
 }
 

src/readline/vimode/ex.rs

@@ -6,6 +6,7 @@ use itertools::Itertools;
 
 use crate::bitflags;
 use crate::libsh::error::{ShErr, ShErrKind, ShResult};
+use crate::readline::history::History;
 use crate::readline::keys::KeyEvent;
 use crate::readline::linebuf::LineBuf;
 use crate::readline::vicmd::{
@@ -33,16 +34,64 @@ bitflags! {
 struct ExEditor {
   buf: LineBuf,
   mode: ViInsert,
+	history: History
 }
 
 impl ExEditor {
+	pub fn new(history: History) -> Self {
+		let mut new = Self {
+			history,
+			..Default::default()
+		};
+		new.buf.update_graphemes();
+		new
+	}
   pub fn clear(&mut self) {
     *self = Self::default()
   }
+  pub fn should_grab_history(&mut self, cmd: &ViCmd) -> bool {
+    cmd.verb().is_none()
+      && (cmd
+        .motion()
+        .is_some_and(|m| matches!(m, MotionCmd(_, Motion::LineUpCharwise)))
+        && self.buf.start_of_line() == 0)
+      || (cmd
+        .motion()
+        .is_some_and(|m| matches!(m, MotionCmd(_, Motion::LineDownCharwise)))
+        && self.buf.end_of_line() == self.buf.cursor_max())
+  }
+  pub fn scroll_history(&mut self, cmd: ViCmd) {
+    let count = &cmd.motion().unwrap().0;
+    let motion = &cmd.motion().unwrap().1;
+    let count = match motion {
+      Motion::LineUpCharwise => -(*count as isize),
+      Motion::LineDownCharwise => *count as isize,
+      _ => unreachable!(),
+    };
+    let entry = self.history.scroll(count);
+    if let Some(entry) = entry {
+      let buf = std::mem::take(&mut self.buf);
+      self.buf.set_buffer(entry.command().to_string());
+      if self.history.pending.is_none() {
+        self.history.pending = Some(buf);
+      }
+      self.buf.set_hint(None);
+      self.buf.move_cursor_to_end();
+    } else if let Some(pending) = self.history.pending.take() {
+      self.buf = pending;
+    }
+  }
   pub fn handle_key(&mut self, key: KeyEvent) -> ShResult<()> {
-    let Some(cmd) = self.mode.handle_key(key) else {
+    let Some(mut cmd) = self.mode.handle_key(key) else {
       return Ok(());
     };
+		cmd.alter_line_motion_if_no_verb();
+		log::debug!("ExEditor got cmd: {:?}", cmd);
+		if self.should_grab_history(&cmd) {
+			log::debug!("Grabbing history for cmd: {:?}", cmd);
+			self.scroll_history(cmd);
+			return Ok(())
+		}
     self.buf.exec_cmd(cmd)
   }
 }
@@ -53,8 +102,8 @@ pub struct ViEx {
 }
 
 impl ViEx {
-  pub fn new() -> Self {
-    Self::default()
+  pub fn new(history: History) -> Self {
+		Self { pending_cmd: ExEditor::new(history) }
   }
 }
 
@@ -62,18 +111,14 @@ impl ViMode for ViEx {
   // Ex mode can return errors, so we use this fallible method instead of the normal one
   fn handle_key_fallible(&mut self, key: KeyEvent) -> ShResult<Option<ViCmd>> {
     use crate::readline::keys::{KeyCode as C, KeyEvent as E, ModKeys as M};
-    log::debug!("[ViEx] handle_key_fallible: key={:?}", key);
     match key {
       E(C::Char('\r'), M::NONE) | E(C::Enter, M::NONE) => {
         let input = self.pending_cmd.buf.as_str();
-        log::debug!("[ViEx] Enter pressed, pending_cmd={:?}", input);
         match parse_ex_cmd(input) {
           Ok(cmd) => {
-            log::debug!("[ViEx] parse_ex_cmd Ok: {:?}", cmd);
             Ok(cmd)
           }
           Err(e) => {
-            log::debug!("[ViEx] parse_ex_cmd Err: {:?}", e);
             let msg = e.unwrap_or(format!("Not an editor command: {}", input));
             write_meta(|m| m.post_system_message(msg.clone()));
             Err(ShErr::simple(ShErrKind::ParseErr, msg))
@@ -81,12 +126,10 @@ impl ViMode for ViEx {
         }
       }
       E(C::Char('C'), M::CTRL) => {
-        log::debug!("[ViEx] Ctrl-C, clearing");
         self.pending_cmd.clear();
         Ok(None)
       }
       E(C::Esc, M::NONE) => {
-        log::debug!("[ViEx] Esc, returning to normal mode");
         Ok(Some(ViCmd {
           register: RegisterName::default(),
           verb: Some(VerbCmd(1, Verb::NormalMode)),
@@ -96,14 +139,12 @@ impl ViMode for ViEx {
         }))
       }
       _ => {
-        log::debug!("[ViEx] forwarding key to ExEditor");
         self.pending_cmd.handle_key(key).map(|_| None)
       }
     }
   }
   fn handle_key(&mut self, key: KeyEvent) -> Option<ViCmd> {
     let result = self.handle_key_fallible(key);
-    log::debug!("[ViEx] handle_key result: {:?}", result);
     result.ok().flatten()
   }
   fn is_repeatable(&self) -> bool {
@@ -177,7 +218,7 @@ fn parse_ex_cmd(raw: &str) -> Result<Option<ViCmd>, Option<String>> {
     verb,
     motion,
     raw_seq: raw.to_string(),
-    flags: CmdFlags::EXIT_CUR_MODE,
+    flags: CmdFlags::EXIT_CUR_MODE | CmdFlags::IS_EX_CMD,
   }))
 }
 
@@ -224,6 +265,10 @@ fn parse_ex_command(chars: &mut Peekable<Chars<'_>>) -> Result<Option<Verb>, Opt
       let cmd = unescape_shell_cmd(&cmd);
       Ok(Some(Verb::ShellCmd(cmd)))
     }
+		_ if "help".starts_with(&cmd_name) => {
+			let cmd = "help ".to_string() + chars.collect::<String>().trim();
+			Ok(Some(Verb::ShellCmd(cmd)))
+		}
     "normal!" => parse_normal(chars),
     _ if "delete".starts_with(&cmd_name) => Ok(Some(Verb::Delete)),
     _ if "yank".starts_with(&cmd_name) => Ok(Some(Verb::Yank)),

src/readline/vimode/insert.rs

@@ -13,10 +13,10 @@ impl ViInsert {
   pub fn new() -> Self {
     Self::default()
   }
-	pub fn record_cmd(mut self, cmd: ViCmd) -> Self {
-		self.cmds.push(cmd);
-		self
-	}
+  pub fn record_cmd(mut self, cmd: ViCmd) -> Self {
+    self.cmds.push(cmd);
+    self
+  }
   pub fn with_count(mut self, repeat_count: u16) -> Self {
     self.repeat_count = repeat_count;
     self
@@ -65,10 +65,12 @@ impl ViMode for ViInsert {
         raw_seq: String::new(),
         flags: Default::default(),
       }),
-			E(K::Verbatim(seq), _) => {
-				self.pending_cmd.set_verb(VerbCmd(1, Verb::Insert(seq.to_string())));
-				self.register_and_return()
-			}
+      E(K::Verbatim(seq), _) => {
+        self
+          .pending_cmd
+          .set_verb(VerbCmd(1, Verb::Insert(seq.to_string())));
+        self.register_and_return()
+      }
       E(K::Char('W'), M::CTRL) => {
         self.pending_cmd.set_verb(VerbCmd(1, Verb::Delete));
         self.pending_cmd.set_motion(MotionCmd(

src/readline/vimode/visual.rs

@@ -213,7 +213,7 @@ impl ViVisual {
           let ch = chars_clone.next()?;
           return Some(ViCmd {
             register,
-            verb: Some(VerbCmd(1, Verb::ReplaceCharInplace(ch,1))),
+            verb: Some(VerbCmd(1, Verb::ReplaceCharInplace(ch, 1))),
             motion: None,
             raw_seq: self.take_cmd(),
             flags: CmdFlags::empty(),
@@ -301,13 +301,13 @@ impl ViVisual {
           });
         }
         'y' => {
-					return Some(ViCmd {
-						register,
-						verb: Some(VerbCmd(count, Verb::Yank)),
-						motion: None,
-						raw_seq: self.take_cmd(),
-						flags: CmdFlags::empty(),
-					});
+          return Some(ViCmd {
+            register,
+            verb: Some(VerbCmd(count, Verb::Yank)),
+            motion: None,
+            raw_seq: self.take_cmd(),
+            flags: CmdFlags::empty(),
+          });
         }
         'd' => {
           chars = chars_clone;

src/shopt.rs

@@ -146,6 +146,7 @@ pub struct ShOptCore {
   pub bell_enabled: bool,
   pub max_recurse_depth: usize,
   pub xpg_echo: bool,
+  pub noclobber: bool,
 }
 
 impl ShOptCore {
@@ -185,12 +186,12 @@ impl ShOptCore {
             "shopt: expected an integer for max_hist value (-1 for unlimited)",
           ));
         };
-				if val < -1 {
-					return Err(ShErr::simple(
-						ShErrKind::SyntaxErr,
-						"shopt: expected a non-negative integer or -1 for max_hist value",
-					));
-				}
+        if val < -1 {
+          return Err(ShErr::simple(
+            ShErrKind::SyntaxErr,
+            "shopt: expected a non-negative integer or -1 for max_hist value",
+          ));
+        }
         self.max_hist = val;
       }
       "interactive_comments" => {
@@ -238,6 +239,15 @@ impl ShOptCore {
         };
         self.xpg_echo = val;
       }
+      "noclobber" => {
+        let Ok(val) = val.parse::<bool>() else {
+          return Err(ShErr::simple(
+            ShErrKind::SyntaxErr,
+            "shopt: expected 'true' or 'false' for noclobber value",
+          ));
+        };
+        self.noclobber = val;
+      }
       _ => {
         return Err(ShErr::simple(
           ShErrKind::SyntaxErr,
@@ -304,6 +314,12 @@ impl ShOptCore {
         output.push_str(&format!("{}", self.xpg_echo));
         Ok(Some(output))
       }
+      "noclobber" => {
+        let mut output =
+          String::from("Prevent > from overwriting existing files (use >| to override)\n");
+        output.push_str(&format!("{}", self.noclobber));
+        Ok(Some(output))
+      }
       _ => Err(ShErr::simple(
         ShErrKind::SyntaxErr,
         format!("shopt: Unexpected 'core' option '{query}'"),
@@ -327,6 +343,7 @@ impl Display for ShOptCore {
     output.push(format!("bell_enabled = {}", self.bell_enabled));
     output.push(format!("max_recurse_depth = {}", self.max_recurse_depth));
     output.push(format!("xpg_echo = {}", self.xpg_echo));
+    output.push(format!("noclobber = {}", self.noclobber));
 
     let final_output = output.join("\n");
 
@@ -346,6 +363,7 @@ impl Default for ShOptCore {
       bell_enabled: true,
       max_recurse_depth: 1000,
       xpg_echo: false,
+      noclobber: false,
     }
   }
 }
@@ -360,6 +378,8 @@ pub struct ShOptPrompt {
   pub linebreak_on_incomplete: bool,
   pub leader: String,
   pub line_numbers: bool,
+  pub screensaver_cmd: String,
+  pub screensaver_idle_time: usize,
 }
 
 impl ShOptPrompt {
@@ -431,6 +451,18 @@ impl ShOptPrompt {
         };
         self.line_numbers = val;
       }
+      "screensaver_cmd" => {
+        self.screensaver_cmd = val.to_string();
+      }
+      "screensaver_idle_time" => {
+        let Ok(val) = val.parse::<usize>() else {
+          return Err(ShErr::simple(
+            ShErrKind::SyntaxErr,
+            "shopt: expected a positive integer for screensaver_idle_time value",
+          ));
+        };
+        self.screensaver_idle_time = val;
+      }
       "custom" => {
         todo!()
       }
@@ -496,6 +528,17 @@ impl ShOptPrompt {
         output.push_str(&format!("{}", self.line_numbers));
         Ok(Some(output))
       }
+      "screensaver_cmd" => {
+        let mut output = String::from("Command to execute as a screensaver after idle timeout\n");
+        output.push_str(&self.screensaver_cmd);
+        Ok(Some(output))
+      }
+      "screensaver_idle_time" => {
+        let mut output =
+          String::from("Idle time in seconds before running screensaver_cmd (0 = disabled)\n");
+        output.push_str(&format!("{}", self.screensaver_idle_time));
+        Ok(Some(output))
+      }
       _ => Err(ShErr::simple(
         ShErrKind::SyntaxErr,
         format!("shopt: Unexpected 'prompt' option '{query}'"),
@@ -519,6 +562,11 @@ impl Display for ShOptPrompt {
     ));
     output.push(format!("leader = {}", self.leader));
     output.push(format!("line_numbers = {}", self.line_numbers));
+    output.push(format!("screensaver_cmd = {}", self.screensaver_cmd));
+    output.push(format!(
+      "screensaver_idle_time = {}",
+      self.screensaver_idle_time
+    ));
 
     let final_output = output.join("\n");
 
@@ -537,6 +585,8 @@ impl Default for ShOptPrompt {
       linebreak_on_incomplete: true,
       leader: "\\".to_string(),
       line_numbers: true,
+      screensaver_cmd: String::new(),
+      screensaver_idle_time: 0,
     }
   }
 }
@@ -547,23 +597,31 @@ mod tests {
 
   #[test]
   fn all_core_fields_covered() {
-      let ShOptCore {
-          dotglob, autocd, hist_ignore_dupes, max_hist,
-          interactive_comments, auto_hist, bell_enabled, max_recurse_depth,
-          xpg_echo,
-      } = ShOptCore::default();
-      // If a field is added to the struct, this destructure fails to compile.
-      let _ = (
-				dotglob,
-				autocd,
-				hist_ignore_dupes,
-				max_hist,
-				interactive_comments,
-				auto_hist,
-				bell_enabled,
-				max_recurse_depth,
-				xpg_echo,
-			);
+    let ShOptCore {
+      dotglob,
+      autocd,
+      hist_ignore_dupes,
+      max_hist,
+      interactive_comments,
+      auto_hist,
+      bell_enabled,
+      max_recurse_depth,
+      xpg_echo,
+      noclobber,
+    } = ShOptCore::default();
+    // If a field is added to the struct, this destructure fails to compile.
+    let _ = (
+      dotglob,
+      autocd,
+      hist_ignore_dupes,
+      max_hist,
+      interactive_comments,
+      auto_hist,
+      bell_enabled,
+      max_recurse_depth,
+      xpg_echo,
+      noclobber,
+    );
   }
 
   #[test]
@@ -589,7 +647,7 @@ mod tests {
     opts.set("core.max_hist", "-1").unwrap();
     assert_eq!(opts.core.max_hist, -1);
 
-		assert!(opts.set("core.max_hist", "-500").is_err());
+    assert!(opts.set("core.max_hist", "-500").is_err());
   }
 
   #[test]

src/signal.rs

@@ -165,10 +165,10 @@ pub fn reset_signals(is_fg: bool) {
       if sig == Signal::SIGKILL || sig == Signal::SIGSTOP {
         continue;
       }
-			if is_fg && (sig == Signal::SIGTTIN || sig == Signal::SIGTTOU) {
-				log::debug!("Not resetting SIGTTIN/SIGTTOU in foreground child");
-				continue;
-			}
+      if is_fg && (sig == Signal::SIGTTIN || sig == Signal::SIGTTOU) {
+        log::debug!("Not resetting SIGTTIN/SIGTTOU in foreground child");
+        continue;
+      }
       let _ = sigaction(sig, &default);
     }
   }

src/state.rs

@@ -1,5 +1,11 @@
 use std::{
-  cell::RefCell, collections::{HashMap, HashSet, VecDeque, hash_map::Entry}, fmt::Display, ops::{BitAnd, BitAndAssign, BitOr, BitOrAssign}, os::unix::fs::PermissionsExt, str::FromStr, time::Duration
+  cell::RefCell,
+  collections::{HashMap, HashSet, VecDeque, hash_map::Entry},
+  fmt::Display,
+  ops::{BitAnd, BitAndAssign, BitOr, BitOrAssign},
+  os::unix::fs::PermissionsExt,
+  str::FromStr,
+  time::Duration,
 };
 
 use nix::unistd::{User, gethostname, getppid};
@@ -36,7 +42,7 @@ thread_local! {
   pub static SHED: Shed = Shed::new();
 }
 
-#[derive(Clone,Debug)]
+#[derive(Clone, Debug)]
 pub struct Shed {
   pub jobs: RefCell<JobTab>,
   pub var_scopes: RefCell<ScopeStack>,
@@ -44,8 +50,8 @@ pub struct Shed {
   pub logic: RefCell<LogTab>,
   pub shopts: RefCell<ShOpts>,
 
-	#[cfg(test)]
-	saved: RefCell<Option<Box<Self>>>,
+  #[cfg(test)]
+  saved: RefCell<Option<Box<Self>>>,
 }
 
 impl Shed {
@@ -57,8 +63,8 @@ impl Shed {
       logic: RefCell::new(LogTab::new()),
       shopts: RefCell::new(ShOpts::default()),
 
-			#[cfg(test)]
-			saved: RefCell::new(None),
+      #[cfg(test)]
+      saved: RefCell::new(None),
     }
   }
 }
@@ -71,27 +77,27 @@ impl Default for Shed {
 
 #[cfg(test)]
 impl Shed {
-	pub fn save(&self) {
-		let saved = Self {
-			jobs: RefCell::new(self.jobs.borrow().clone()),
-			var_scopes: RefCell::new(self.var_scopes.borrow().clone()),
-			meta: RefCell::new(self.meta.borrow().clone()),
-			logic: RefCell::new(self.logic.borrow().clone()),
-			shopts: RefCell::new(self.shopts.borrow().clone()),
-			saved: RefCell::new(None),
-		};
-		*self.saved.borrow_mut() = Some(Box::new(saved));
-	}
+  pub fn save(&self) {
+    let saved = Self {
+      jobs: RefCell::new(self.jobs.borrow().clone()),
+      var_scopes: RefCell::new(self.var_scopes.borrow().clone()),
+      meta: RefCell::new(self.meta.borrow().clone()),
+      logic: RefCell::new(self.logic.borrow().clone()),
+      shopts: RefCell::new(self.shopts.borrow().clone()),
+      saved: RefCell::new(None),
+    };
+    *self.saved.borrow_mut() = Some(Box::new(saved));
+  }
 
-	pub fn restore(&self) {
-		if let Some(saved) = self.saved.take() {
-			*self.jobs.borrow_mut() = saved.jobs.into_inner();
-			*self.var_scopes.borrow_mut() = saved.var_scopes.into_inner();
-			*self.meta.borrow_mut() = saved.meta.into_inner();
-			*self.logic.borrow_mut() = saved.logic.into_inner();
-			*self.shopts.borrow_mut() = saved.shopts.into_inner();
-		}
-	}
+  pub fn restore(&self) {
+    if let Some(saved) = self.saved.take() {
+      *self.jobs.borrow_mut() = saved.jobs.into_inner();
+      *self.var_scopes.borrow_mut() = saved.var_scopes.into_inner();
+      *self.meta.borrow_mut() = saved.meta.into_inner();
+      *self.logic.borrow_mut() = saved.logic.into_inner();
+      *self.shopts.borrow_mut() = saved.shopts.into_inner();
+    }
+  }
 }
 
 #[derive(Hash, Eq, PartialEq, Debug, Clone, Copy)]
@@ -315,6 +321,34 @@ impl ScopeStack {
     };
     scope.set_var(var_name, val, flags)
   }
+  pub fn get_magic_var(&self, var_name: &str) -> Option<String> {
+    match var_name {
+      "SECONDS" => {
+        let shell_time = read_meta(|m| m.shell_time());
+        let secs = Instant::now().duration_since(shell_time).as_secs();
+        Some(secs.to_string())
+      }
+      "EPOCHREALTIME" => {
+        let epoch = std::time::SystemTime::now()
+          .duration_since(std::time::UNIX_EPOCH)
+          .unwrap_or(Duration::from_secs(0))
+          .as_secs_f64();
+        Some(epoch.to_string())
+      }
+      "EPOCHSECONDS" => {
+        let epoch = std::time::SystemTime::now()
+          .duration_since(std::time::UNIX_EPOCH)
+          .unwrap_or(Duration::from_secs(0))
+          .as_secs();
+        Some(epoch.to_string())
+      }
+      "RANDOM" => {
+        let random = rand::random_range(0..32768);
+        Some(random.to_string())
+      }
+      _ => None,
+    }
+  }
   pub fn get_arr_elems(&self, var_name: &str) -> ShResult<Vec<String>> {
     for scope in self.scopes.iter().rev() {
       if scope.var_exists(var_name)
@@ -440,7 +474,9 @@ impl ScopeStack {
   pub fn try_get_var(&self, var_name: &str) -> Option<String> {
     // This version of get_var() is mainly used internally
     // so that we have access to Option methods
-    if let Ok(param) = var_name.parse::<ShellParam>() {
+    if let Some(magic) = self.get_magic_var(var_name) {
+      return Some(magic);
+    } else if let Ok(param) = var_name.parse::<ShellParam>() {
       let val = self.get_param(param);
       if !val.is_empty() {
         return Some(val);
@@ -463,6 +499,9 @@ impl ScopeStack {
     var
   }
   pub fn get_var(&self, var_name: &str) -> String {
+    if let Some(magic) = self.get_magic_var(var_name) {
+      return magic;
+    }
     if let Ok(param) = var_name.parse::<ShellParam>() {
       return self.get_param(param);
     }
@@ -495,7 +534,10 @@ impl ScopeStack {
       return val.clone();
     }
     // Positional params are scope-local; only check the current scope
-    if matches!(param, ShellParam::Pos(_) | ShellParam::AllArgs | ShellParam::AllArgsStr | ShellParam::ArgCount) {
+    if matches!(
+      param,
+      ShellParam::Pos(_) | ShellParam::AllArgs | ShellParam::AllArgsStr | ShellParam::ArgCount
+    ) {
       if let Some(scope) = self.scopes.last() {
         return scope.get_param(param);
       }
@@ -954,17 +996,17 @@ impl Display for Var {
 }
 
 impl From<Vec<String>> for Var {
-	fn from(value: Vec<String>) -> Self {
-	  Self::new(VarKind::Arr(value.into()), VarFlags::NONE)
-	}
+  fn from(value: Vec<String>) -> Self {
+    Self::new(VarKind::Arr(value.into()), VarFlags::NONE)
+  }
 }
 
 impl From<&[String]> for Var {
-	fn from(value: &[String]) -> Self {
-		let mut new = VecDeque::new();
-		new.extend(value.iter().cloned());
-	  Self::new(VarKind::Arr(new), VarFlags::NONE)
-	}
+  fn from(value: &[String]) -> Self {
+    let mut new = VecDeque::new();
+    new.extend(value.iter().cloned());
+    Self::new(VarKind::Arr(new), VarFlags::NONE)
+  }
 }
 
 macro_rules! impl_var_from {
@@ -978,19 +1020,7 @@ macro_rules! impl_var_from {
 }
 
 impl_var_from!(
-	i8,
-	i16,
-	i32,
-	i64,
-	isize,
-	u8,
-	u16,
-	u32,
-	u64,
-	usize,
-	String,
-	&str,
-	bool
+  i8, i16, i32, i64, isize, u8, u16, u32, u64, usize, String, &str, bool
 );
 
 #[derive(Default, Clone, Debug)]
@@ -1012,7 +1042,7 @@ impl VarTab {
     }
   }
   pub fn new() -> Self {
-    let vars = HashMap::new();
+    let vars = Self::init_sh_vars();
     let params = Self::init_params();
     Self::init_env();
     let mut var_tab = Self {
@@ -1031,6 +1061,11 @@ impl VarTab {
     params.insert(ShellParam::LastJob, "".into()); // PID of the last background job (if any)
     params
   }
+  fn init_sh_vars() -> HashMap<String, Var> {
+    let mut vars = HashMap::new();
+    vars.insert("COMP_WORDBREAKS".into(), " \t\n\"'@><=;|&(".into());
+    vars
+  }
   fn init_env() {
     let pathbuf_to_string =
       |pb: Result<PathBuf, std::io::Error>| pb.unwrap_or_default().to_string_lossy().to_string();
@@ -1063,6 +1098,8 @@ impl VarTab {
       .map(|hname| hname.to_string_lossy().to_string())
       .unwrap_or_default();
 
+		let help_paths = format!("/usr/share/shed/doc:{home}/.local/share/shed/doc");
+
     unsafe {
       env::set_var("IFS", " \t\n");
       env::set_var("HOST", hostname.clone());
@@ -1079,6 +1116,7 @@ impl VarTab {
       env::set_var("SHELL", pathbuf_to_string(std::env::current_exe()));
       env::set_var("SHED_HIST", format!("{}/.shedhist", home));
       env::set_var("SHED_RC", format!("{}/.shedrc", home));
+			env::set_var("SHED_HPATH", help_paths);
     }
   }
   pub fn init_sh_argv(&mut self) {
@@ -1295,6 +1333,15 @@ impl VarTab {
         .get(&ShellParam::Status)
         .map(|s| s.to_string())
         .unwrap_or("0".into()),
+      ShellParam::AllArgsStr => {
+        let ifs = get_separator();
+        self
+          .params
+          .get(&ShellParam::AllArgs)
+          .map(|s| s.replace(markers::ARG_SEP, &ifs).to_string())
+          .unwrap_or_default()
+      }
+
       _ => self
         .params
         .get(&param)
@@ -1305,8 +1352,11 @@ impl VarTab {
 }
 
 /// A table of metadata for the shell
-#[derive(Clone, Default, Debug)]
+#[derive(Clone, Debug)]
 pub struct MetaTab {
+  // Time when the shell was started, used for calculating shell uptime
+  shell_time: Instant,
+
   // command running duration
   runtime_start: Option<Instant>,
   runtime_stop: Option<Instant>,
@@ -1331,6 +1381,25 @@ pub struct MetaTab {
   pending_widget_keys: Vec<KeyEvent>,
 }
 
+impl Default for MetaTab {
+  fn default() -> Self {
+    Self {
+      shell_time: Instant::now(),
+      runtime_start: None,
+      runtime_stop: None,
+      system_msg: vec![],
+      dir_stack: VecDeque::new(),
+      getopts_offset: 0,
+      old_path: None,
+      old_pwd: None,
+      path_cache: HashSet::new(),
+      cwd_cache: HashSet::new(),
+      comp_specs: HashMap::new(),
+      pending_widget_keys: vec![],
+    }
+  }
+}
+
 impl MetaTab {
   pub fn new() -> Self {
     Self {
@@ -1338,6 +1407,9 @@ impl MetaTab {
       ..Default::default()
     }
   }
+  pub fn shell_time(&self) -> Instant {
+    self.shell_time
+  }
   pub fn set_pending_widget_keys(&mut self, keys: &str) {
     let exp = expand_keymap(keys);
     self.pending_widget_keys = exp;
@@ -1782,6 +1854,15 @@ pub fn change_dir<P: AsRef<Path>>(dir: P) -> ShResult<()> {
   Ok(())
 }
 
+pub fn get_separator() -> String {
+  env::var("IFS")
+    .unwrap_or(String::from(" "))
+    .chars()
+    .next()
+    .unwrap()
+    .to_string()
+}
+
 pub fn get_status() -> i32 {
   read_vars(|v| v.get_param(ShellParam::Status))
     .parse::<i32>()

src/testutil.rs

@@ -1,219 +1,240 @@
 use std::{
-	collections::{HashMap, HashSet},
-	env,
-	os::fd::{AsRawFd, BorrowedFd, OwnedFd},
-	path::PathBuf,
-	sync::{self, Arc, MutexGuard},
+  collections::{HashMap, HashSet},
+  env,
+  os::fd::{AsRawFd, BorrowedFd, OwnedFd},
+  path::PathBuf,
+  sync::{self, Arc, MutexGuard},
 };
 
 use nix::{
-	fcntl::{FcntlArg, OFlag, fcntl},
-	pty::openpty,
-	sys::termios::{OutputFlags, SetArg, tcgetattr, tcsetattr},
-	unistd::read,
+  fcntl::{FcntlArg, OFlag, fcntl},
+  pty::openpty,
+  sys::termios::{OutputFlags, SetArg, tcgetattr, tcsetattr},
+  unistd::read,
 };
 
 use crate::{
-	expand::expand_aliases, libsh::error::ShResult, parse::{ParsedSrc, Redir, RedirType, execute::exec_input, lex::LexFlags}, procio::{IoFrame, IoMode, RedirGuard}, readline::register::{restore_registers, save_registers}, state::{MetaTab, SHED, read_logic}
+  expand::expand_aliases,
+  libsh::error::ShResult,
+  parse::{ParsedSrc, Redir, RedirType, execute::exec_input, lex::LexFlags},
+  procio::{IoFrame, IoMode, RedirGuard},
+  readline::register::{restore_registers, save_registers},
+  state::{MetaTab, SHED, read_logic},
 };
 
 static TEST_MUTEX: sync::Mutex<()> = sync::Mutex::new(());
 
 pub fn has_cmds(cmds: &[&str]) -> bool {
-	let path_cmds = MetaTab::get_cmds_in_path();
-	path_cmds.iter().all(|c| cmds.iter().any(|&cmd| c == cmd))
+  let path_cmds = MetaTab::get_cmds_in_path();
+  path_cmds.iter().all(|c| cmds.iter().any(|&cmd| c == cmd))
 }
 
 pub fn has_cmd(cmd: &str) -> bool {
-	MetaTab::get_cmds_in_path().into_iter().any(|c| c == cmd)
+  MetaTab::get_cmds_in_path().into_iter().any(|c| c == cmd)
 }
 
 pub fn test_input(input: impl Into<String>) -> ShResult<()> {
-	exec_input(input.into(), None, false, None)
+  exec_input(input.into(), None, false, None)
 }
 
 pub struct TestGuard {
-	_lock: MutexGuard<'static, ()>,
-	_redir_guard: RedirGuard,
-	old_cwd: PathBuf,
-	saved_env: HashMap<String, String>,
-	pty_master: OwnedFd,
-	pty_slave: OwnedFd,
+  _lock: MutexGuard<'static, ()>,
+  _redir_guard: RedirGuard,
+  old_cwd: PathBuf,
+  saved_env: HashMap<String, String>,
+  pty_master: OwnedFd,
+  pty_slave: OwnedFd,
 
-	cleanups: Vec<Box<dyn FnOnce()>>
+  cleanups: Vec<Box<dyn FnOnce()>>,
 }
 
 impl TestGuard {
-	pub fn new() -> Self {
-		let _lock = TEST_MUTEX.lock().unwrap();
+  pub fn new() -> Self {
+    let _lock = TEST_MUTEX.lock().unwrap();
 
-		let pty = openpty(None, None).unwrap();
-		let (pty_master,pty_slave) = (pty.master, pty.slave);
-		let mut attrs = tcgetattr(&pty_slave).unwrap();
-		attrs.output_flags &= !OutputFlags::ONLCR;
-		tcsetattr(&pty_slave, SetArg::TCSANOW, &attrs).unwrap();
+    let pty = openpty(None, None).unwrap();
+    let (pty_master, pty_slave) = (pty.master, pty.slave);
+    let mut attrs = tcgetattr(&pty_slave).unwrap();
+    attrs.output_flags &= !OutputFlags::ONLCR;
+    tcsetattr(&pty_slave, SetArg::TCSANOW, &attrs).unwrap();
 
-		let mut frame = IoFrame::new();
-		frame.push(
-			Redir::new(
-				IoMode::Fd {
-					tgt_fd: 0,
-					src_fd: pty_slave.as_raw_fd(),
-				},
-				RedirType::Input,
-			),
-		);
-		frame.push(
-			Redir::new(
-				IoMode::Fd {
-					tgt_fd: 1,
-					src_fd: pty_slave.as_raw_fd(),
-				},
-				RedirType::Output,
-			),
-		);
-		frame.push(
-			Redir::new(
-				IoMode::Fd {
-					tgt_fd: 2,
-					src_fd: pty_slave.as_raw_fd(),
-				},
-				RedirType::Output,
-			),
-		);
+    let mut frame = IoFrame::new();
+    frame.push(Redir::new(
+      IoMode::Fd {
+        tgt_fd: 0,
+        src_fd: pty_slave.as_raw_fd(),
+      },
+      RedirType::Input,
+    ));
+    frame.push(Redir::new(
+      IoMode::Fd {
+        tgt_fd: 1,
+        src_fd: pty_slave.as_raw_fd(),
+      },
+      RedirType::Output,
+    ));
+    frame.push(Redir::new(
+      IoMode::Fd {
+        tgt_fd: 2,
+        src_fd: pty_slave.as_raw_fd(),
+      },
+      RedirType::Output,
+    ));
 
-		let _redir_guard = frame.redirect().unwrap();
+    let _redir_guard = frame.redirect().unwrap();
 
-		let old_cwd = env::current_dir().unwrap();
-		let saved_env = env::vars().collect();
-		SHED.with(|s| s.save());
-		save_registers();
-		Self {
-			_lock,
-			_redir_guard,
-			old_cwd,
-			saved_env,
-			pty_master,
-			pty_slave,
-			cleanups: vec![],
-		}
-	}
+    let old_cwd = env::current_dir().unwrap();
+    let saved_env = env::vars().collect();
+    SHED.with(|s| s.save());
+    save_registers();
+    Self {
+      _lock,
+      _redir_guard,
+      old_cwd,
+      saved_env,
+      pty_master,
+      pty_slave,
+      cleanups: vec![],
+    }
+  }
 
-	pub fn pty_slave(&self) -> BorrowedFd {
-		unsafe { BorrowedFd::borrow_raw(self.pty_slave.as_raw_fd()) }
-	}
+  pub fn pty_slave(&self) -> BorrowedFd<'_> {
+    unsafe { BorrowedFd::borrow_raw(self.pty_slave.as_raw_fd()) }
+  }
 
-	pub fn add_cleanup(&mut self, f: impl FnOnce() + 'static) {
-		self.cleanups.push(Box::new(f));
-	}
+  pub fn add_cleanup(&mut self, f: impl FnOnce() + 'static) {
+    self.cleanups.push(Box::new(f));
+  }
 
-	pub fn read_output(&self) -> String {
-		let flags = fcntl(self.pty_master.as_raw_fd(), FcntlArg::F_GETFL).unwrap();
-		let flags = OFlag::from_bits_truncate(flags);
-		fcntl(
-			self.pty_master.as_raw_fd(),
-			FcntlArg::F_SETFL(flags | OFlag::O_NONBLOCK),
-		).unwrap();
+  pub fn read_output(&self) -> String {
+    let flags = fcntl(self.pty_master.as_raw_fd(), FcntlArg::F_GETFL).unwrap();
+    let flags = OFlag::from_bits_truncate(flags);
+    fcntl(
+      self.pty_master.as_raw_fd(),
+      FcntlArg::F_SETFL(flags | OFlag::O_NONBLOCK),
+    )
+    .unwrap();
 
-		let mut out = vec![];
-		let mut buf = [0;4096];
-		loop {
-			match read(self.pty_master.as_raw_fd(), &mut buf) {
-				Ok(0) => break,
-				Ok(n) => out.extend_from_slice(&buf[..n]),
-				Err(_) => break,
-			}
-		}
+    let mut out = vec![];
+    let mut buf = [0; 4096];
+    loop {
+      match read(self.pty_master.as_raw_fd(), &mut buf) {
+        Ok(0) => break,
+        Ok(n) => out.extend_from_slice(&buf[..n]),
+        Err(_) => break,
+      }
+    }
 
-		fcntl(
-			self.pty_master.as_raw_fd(),
-			FcntlArg::F_SETFL(flags),
-		).unwrap();
+    fcntl(self.pty_master.as_raw_fd(), FcntlArg::F_SETFL(flags)).unwrap();
 
-		String::from_utf8_lossy(&out).to_string()
-	}
+    String::from_utf8_lossy(&out).to_string()
+  }
 }
 
 impl Default for TestGuard {
-	fn default() -> Self {
-		Self::new()
-	}
+  fn default() -> Self {
+    Self::new()
+  }
 }
 
 impl Drop for TestGuard {
-	fn drop(&mut self) {
-		env::set_current_dir(&self.old_cwd).ok();
-		for (k, _) in env::vars() {
-			unsafe { env::remove_var(&k); }
-		}
-		for (k, v) in &self.saved_env {
-			unsafe { env::set_var(k, v); }
-		}
-		for cleanup in self.cleanups.drain(..).rev() {
-			cleanup();
-		}
-		SHED.with(|s| s.restore());
-		restore_registers();
-	}
+  fn drop(&mut self) {
+    env::set_current_dir(&self.old_cwd).ok();
+    for (k, _) in env::vars() {
+      unsafe {
+        env::remove_var(&k);
+      }
+    }
+    for (k, v) in &self.saved_env {
+      unsafe {
+        env::set_var(k, v);
+      }
+    }
+    for cleanup in self.cleanups.drain(..).rev() {
+      cleanup();
+    }
+    SHED.with(|s| s.restore());
+    restore_registers();
+  }
 }
 
 pub fn get_ast(input: &str) -> ShResult<Vec<crate::parse::Node>> {
-		let log_tab = read_logic(|l| l.clone());
-		let input = expand_aliases(input.into(), HashSet::new(), &log_tab);
+  let log_tab = read_logic(|l| l.clone());
+  let input = expand_aliases(input.into(), HashSet::new(), &log_tab);
 
-		let source_name = "test_input".to_string();
-		let mut parser = ParsedSrc::new(Arc::new(input))
-			.with_lex_flags(LexFlags::empty())
-			.with_name(source_name.clone());
+  let source_name = "test_input".to_string();
+  let mut parser = ParsedSrc::new(Arc::new(input))
+    .with_lex_flags(LexFlags::empty())
+    .with_name(source_name.clone());
 
-		parser.parse_src().map_err(|e| e.into_iter().next().unwrap())?;
+  parser
+    .parse_src()
+    .map_err(|e| e.into_iter().next().unwrap())?;
 
-		Ok(parser.extract_nodes())
+  Ok(parser.extract_nodes())
 }
 
 impl crate::parse::Node {
-	pub fn assert_structure(&mut self, expected: &mut impl Iterator<Item = NdKind>) -> Result<(), String> {
-		let mut full_structure = vec![];
-		let mut before = vec![];
-		let mut after = vec![];
-		let mut offender = None;
+  pub fn assert_structure(
+    &mut self,
+    expected: &mut impl Iterator<Item = NdKind>,
+  ) -> Result<(), String> {
+    let mut full_structure = vec![];
+    let mut before = vec![];
+    let mut after = vec![];
+    let mut offender = None;
 
-		self.walk_tree(&mut |s| {
-			let expected_rule = expected.next();
-			full_structure.push(s.class.as_nd_kind());
+    self.walk_tree(&mut |s| {
+      let expected_rule = expected.next();
+      full_structure.push(s.class.as_nd_kind());
 
-			if offender.is_none() && expected_rule.as_ref().map_or(true, |e| *e != s.class.as_nd_kind()) {
-				offender = Some((s.class.as_nd_kind(), expected_rule));
-			} else if offender.is_none() {
-				before.push(s.class.as_nd_kind());
-			} else {
-				after.push(s.class.as_nd_kind());
-			}
-		});
+      if offender.is_none()
+        && expected_rule
+          .as_ref()
+          .is_none_or(|e| *e != s.class.as_nd_kind())
+      {
+        offender = Some((s.class.as_nd_kind(), expected_rule));
+      } else if offender.is_none() {
+        before.push(s.class.as_nd_kind());
+      } else {
+        after.push(s.class.as_nd_kind());
+      }
+    });
 
-		assert!(expected.next().is_none(), "Expected structure has more nodes than actual structure");
+    assert!(
+      expected.next().is_none(),
+      "Expected structure has more nodes than actual structure"
+    );
 
-		if let Some((nd_kind, expected_rule)) = offender {
-			let expected_rule = expected_rule.map_or("(none — expected array too short)".into(), |e| format!("{e:?}"));
-			let full_structure_hint = full_structure.into_iter()
-				.map(|s| format!("\tNdKind::{s:?},"))
-				.collect::<Vec<String>>()
-				.join("\n");
-			let full_structure_hint = format!("let expected = &mut [\n{full_structure_hint}\n].into_iter();");
+    if let Some((nd_kind, expected_rule)) = offender {
+      let expected_rule = expected_rule.map_or("(none — expected array too short)".into(), |e| {
+        format!("{e:?}")
+      });
+      let full_structure_hint = full_structure
+        .into_iter()
+        .map(|s| format!("\tNdKind::{s:?},"))
+        .collect::<Vec<String>>()
+        .join("\n");
+      let full_structure_hint =
+        format!("let expected = &mut [\n{full_structure_hint}\n].into_iter();");
 
-			let output = [
-				"Structure assertion failed!\n".into(),
-				format!("Expected node type '{:?}', found '{:?}'", expected_rule, nd_kind),
-				format!("Before offender: {:?}", before),
-				format!("After offender: {:?}\n", after),
-				format!("hint: here is the full structure as an array\n {full_structure_hint}"),
-			].join("\n");
+      let output = [
+        "Structure assertion failed!\n".into(),
+        format!(
+          "Expected node type '{:?}', found '{:?}'",
+          expected_rule, nd_kind
+        ),
+        format!("Before offender: {:?}", before),
+        format!("After offender: {:?}\n", after),
+        format!("hint: here is the full structure as an array\n {full_structure_hint}"),
+      ]
+      .join("\n");
 
-			Err(output)
-		} else {
-			Ok(())
-		}
-	}
+      Err(output)
+    } else {
+      Ok(())
+    }
+  }
 }
 
 #[derive(Clone, Debug, PartialEq)]
@@ -227,26 +248,26 @@ pub enum NdKind {
   Conjunction,
   Assignment,
   BraceGrp,
-	Negate,
+  Negate,
   Test,
   FuncDef,
 }
 
 impl crate::parse::NdRule {
-	pub fn as_nd_kind(&self) -> NdKind {
-		match self {
-			Self::Negate { .. } => NdKind::Negate,
-			Self::IfNode { .. } => NdKind::IfNode,
-			Self::LoopNode { .. } => NdKind::LoopNode,
-			Self::ForNode { .. } => NdKind::ForNode,
-			Self::CaseNode { .. } => NdKind::CaseNode,
-			Self::Command { .. } => NdKind::Command,
-			Self::Pipeline { .. } => NdKind::Pipeline,
-			Self::Conjunction { .. } => NdKind::Conjunction,
-			Self::Assignment { .. } => NdKind::Assignment,
-			Self::BraceGrp { .. } => NdKind::BraceGrp,
-			Self::Test { .. } => NdKind::Test,
-			Self::FuncDef { .. } => NdKind::FuncDef,
-		}
-	}
+  pub fn as_nd_kind(&self) -> NdKind {
+    match self {
+      Self::Negate { .. } => NdKind::Negate,
+      Self::IfNode { .. } => NdKind::IfNode,
+      Self::LoopNode { .. } => NdKind::LoopNode,
+      Self::ForNode { .. } => NdKind::ForNode,
+      Self::CaseNode { .. } => NdKind::CaseNode,
+      Self::Command { .. } => NdKind::Command,
+      Self::Pipeline { .. } => NdKind::Pipeline,
+      Self::Conjunction { .. } => NdKind::Conjunction,
+      Self::Assignment { .. } => NdKind::Assignment,
+      Self::BraceGrp { .. } => NdKind::BraceGrp,
+      Self::Test { .. } => NdKind::Test,
+      Self::FuncDef { .. } => NdKind::FuncDef,
+    }
+  }
 }